diff mbox series

[v2,1/2] arm64: dts: mediatek: mt7622: readd syscon to pciesys node

Message ID 20240628105542.5456-1-ansuelsmth@gmail.com (mailing list archive)
State New
Headers show
Series [v2,1/2] arm64: dts: mediatek: mt7622: readd syscon to pciesys node | expand

Commit Message

Christian Marangi June 28, 2024, 10:55 a.m. UTC
Sata node reference the pciesys with the property mediatek,phy-node
and that is used as a syscon to access the pciesys regs.

Readd the syscon compatible to pciesys node to restore correct
functionality of the SATA interface.

Fixes: 3ba5a6159434 ("arm64: dts: mediatek: mt7622: fix clock controllers")
Reported-by: Frank Wunderlich <frank-w@public-files.de>
Co-developed-by: Frank Wunderlich <frank-w@public-files.de>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Cc: stable@vger.kernel.org
---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Markus Elfring June 29, 2024, 5:35 p.m. UTC | #1
> Sata node reference the pciesys with the property mediatek,phy-node
> and that is used as a syscon to access the pciesys regs.
>
> Readd the syscon compatible to pciesys node to restore correct
> functionality of the SATA interface.> Reported-by: Frank Wunderlich …

Was any related information published?

Regards,
Markus
Frank Wunderlich June 29, 2024, 5:58 p.m. UTC | #2
Am 29. Juni 2024 19:35:01 MESZ schrieb Markus Elfring <Markus.Elfring@web.de>:
>> Sata node reference the pciesys with the property mediatek,phy-node
>> and that is used as a syscon to access the pciesys regs.
>>
>> Readd the syscon compatible to pciesys node to restore correct
>> functionality of the SATA interface.
>…
>> Reported-by: Frank Wunderlich …
>
>Was any related information published?
>
>Regards,
>Markus
>

Hi,

I found this while changing uboot to of_upstream and fixed it there (not yet send to mailinglist). As of_upstream uses linux dts,i rechecked if it is broken there too and yes it is.

But i have not sent issue to mailinglist because we fixed it before :)
regards Frank
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 917fa39a74f8..bb0ec1edbe5b 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
@@ -790,7 +790,7 @@  u2port1: usb-phy@1a0c5000 {
 	};
 
 	pciesys: clock-controller@1a100800 {
-		compatible = "mediatek,mt7622-pciesys";
+		compatible = "mediatek,mt7622-pciesys", "syscon";
 		reg = <0 0x1a100800 0 0x1000>;
 		#clock-cells = <1>;
 		#reset-cells = <1>;