diff mbox series

Disable Clk-gate_tests for s390

Message ID 20240702125539.524489-1-audra@redhat.com (mailing list archive)
State Accepted, archived
Headers show
Series Disable Clk-gate_tests for s390 | expand

Commit Message

Audra Mitchell July 2, 2024, 12:55 p.m. UTC
Currently clk-gate tests for s390 fail as the tests create a pretend
clk-gate and use a "fake_reg" to emulate the expected behavior of the
clk_gate->reg. I added some debug statements to the driver and noticed
that the reg changes after initialization to -1, which is coming from
an error coming from zpci_load(). This is likely because the test is
using fake iomem and the s390 architecture likely isn't designed to
handle that. Turn off the clk-gate tests for s390 for now as there is
no clear work around for this problem as discussed in upstream
conversation [1].

[1] https://lore.kernel.org/all/301cd41e6283c12ac67fb8c0f8d5c929.sboyd@kernel.org/T/#t

Signed-off-by: Audra Mitchell <audra@redhat.com>
---
 drivers/clk/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Boyd July 2, 2024, 10:52 p.m. UTC | #1
Quoting Audra Mitchell (2024-07-02 05:55:39)
> Currently clk-gate tests for s390 fail as the tests create a pretend
> clk-gate and use a "fake_reg" to emulate the expected behavior of the
> clk_gate->reg. I added some debug statements to the driver and noticed
> that the reg changes after initialization to -1, which is coming from
> an error coming from zpci_load(). This is likely because the test is
> using fake iomem and the s390 architecture likely isn't designed to
> handle that. Turn off the clk-gate tests for s390 for now as there is
> no clear work around for this problem as discussed in upstream
> conversation [1].
> 
> [1] https://lore.kernel.org/all/301cd41e6283c12ac67fb8c0f8d5c929.sboyd@kernel.org/T/#t
> 
> Signed-off-by: Audra Mitchell <audra@redhat.com>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 3e9099504fad..3c3e0b969020 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -514,6 +514,7 @@  config CLK_KUNIT_TEST
 config CLK_GATE_KUNIT_TEST
 	tristate "Basic gate type Kunit test" if !KUNIT_ALL_TESTS
 	depends on KUNIT
+	depends on !S390
 	default KUNIT_ALL_TESTS
 	help
 	  Kunit test for the basic clk gate type.