| Message ID | 20240708130836.19273-1-quic_jkona@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: clock: qcom: Remove required-opps from required list on SM8650 | expand |
On Mon, Jul 08, 2024 at 06:38:36PM GMT, Jagadeesh Kona wrote: > On SM8650, the minimum voltage corner supported on MMCX from cmd-db is > sufficient for clock controllers to operate and there is no need to specify > the required-opps. Hence remove the required-opps property from the list of > required properties for SM8650 camcc and videocc bindings. > > This fixes: > arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@aaf0000: > 'required-opps' is a required property > > arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@ade0000: > 'required-opps' is a required property > > Fixes: a6a61b9701d1 ("dt-bindings: clock: qcom: Add SM8650 video clock controller") > Fixes: 1ae3f0578e0e ("dt-bindings: clock: qcom: Add SM8650 camera clock controller") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202407070147.C9c3oTqS-lkp@intel.com/ > Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> You are mentioning just sm8650, but your change applies to other platforms. Could you please check whether other platforms supported by these bindings required the opps or not. Make required: conditional and enabled only for those platforms? > --- > Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 1 - > Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > index f58edfc10f4c..bd9612d9d7f7 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > @@ -57,7 +57,6 @@ required: > - compatible > - clocks > - power-domains > - - required-opps > > unevaluatedProperties: false > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml > index b2792b4bb554..8a42e2a1a158 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml > @@ -44,7 +44,6 @@ required: > - compatible > - clocks > - power-domains > - - required-opps > - '#power-domain-cells' > > allOf: > -- > 2.43.0 >
On 08/07/2024 15:08, Jagadeesh Kona wrote: > On SM8650, the minimum voltage corner supported on MMCX from cmd-db is > sufficient for clock controllers to operate and there is no need to specify > the required-opps. Hence remove the required-opps property from the list of > required properties for SM8650 camcc and videocc bindings. <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. </form letter> > > This fixes: > arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@aaf0000: > 'required-opps' is a required property > > arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@ade0000: > 'required-opps' is a required property > > Fixes: a6a61b9701d1 ("dt-bindings: clock: qcom: Add SM8650 video clock controller") > Fixes: 1ae3f0578e0e ("dt-bindings: clock: qcom: Add SM8650 camera clock controller") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202407070147.C9c3oTqS-lkp@intel.com/ > Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 7/8/2024 7:32 PM, Dmitry Baryshkov wrote: > On Mon, Jul 08, 2024 at 06:38:36PM GMT, Jagadeesh Kona wrote: >> On SM8650, the minimum voltage corner supported on MMCX from cmd-db is >> sufficient for clock controllers to operate and there is no need to specify >> the required-opps. Hence remove the required-opps property from the list of >> required properties for SM8650 camcc and videocc bindings. >> >> This fixes: >> arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@aaf0000: >> 'required-opps' is a required property >> >> arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@ade0000: >> 'required-opps' is a required property >> >> Fixes: a6a61b9701d1 ("dt-bindings: clock: qcom: Add SM8650 video clock controller") >> Fixes: 1ae3f0578e0e ("dt-bindings: clock: qcom: Add SM8650 camera clock controller") >> Reported-by: kernel test robot <lkp@intel.com> >> Closes: https://lore.kernel.org/oe-kbuild-all/202407070147.C9c3oTqS-lkp@intel.com/ >> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> > > You are mentioning just sm8650, but your change applies to other > platforms. Could you please check whether other platforms supported by > these bindings required the opps or not. Make required: conditional and > enabled only for those platforms? > Thanks Dmitry for your review. Yes I will make this conditional. Currently only SM8650 doesn't have the required-opps property in DT, so I will remove the required-opps from required list only for SM8650. Thanks, Jagadeesh >> --- >> Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 1 - >> Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml >> index f58edfc10f4c..bd9612d9d7f7 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml >> @@ -57,7 +57,6 @@ required: >> - compatible >> - clocks >> - power-domains >> - - required-opps >> >> unevaluatedProperties: false >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml >> index b2792b4bb554..8a42e2a1a158 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml >> @@ -44,7 +44,6 @@ required: >> - compatible >> - clocks >> - power-domains >> - - required-opps >> - '#power-domain-cells' >> >> allOf: >> -- >> 2.43.0 >> >
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml index f58edfc10f4c..bd9612d9d7f7 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml @@ -57,7 +57,6 @@ required: - compatible - clocks - power-domains - - required-opps unevaluatedProperties: false diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml index b2792b4bb554..8a42e2a1a158 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml @@ -44,7 +44,6 @@ required: - compatible - clocks - power-domains - - required-opps - '#power-domain-cells' allOf:
On SM8650, the minimum voltage corner supported on MMCX from cmd-db is sufficient for clock controllers to operate and there is no need to specify the required-opps. Hence remove the required-opps property from the list of required properties for SM8650 camcc and videocc bindings. This fixes: arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@aaf0000: 'required-opps' is a required property arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@ade0000: 'required-opps' is a required property Fixes: a6a61b9701d1 ("dt-bindings: clock: qcom: Add SM8650 video clock controller") Fixes: 1ae3f0578e0e ("dt-bindings: clock: qcom: Add SM8650 camera clock controller") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202407070147.C9c3oTqS-lkp@intel.com/ Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> --- Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 1 - Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 1 - 2 files changed, 2 deletions(-)