| Message ID | 20240801064448.29626-2-quic_jkona@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Drop required-opps from required list on SM8650 videocc, camcc | expand |
On 01/08/2024 08:44, Jagadeesh Kona wrote: > On SM8650, the minimum voltage corner supported on MMCX from cmd-db is > sufficient for clock controllers to operate and there is no need to specify > the required-opps. Hence remove the required-opps property from the list of > required properties for SM8650 videocc bindings. > > This fixes: > > arch/arm64/boot/dts/qcom/sm8650-hdk.dtb: clock-controller@aaf0000: > 'required-opps' is a required property > > arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@aaf0000: > 'required-opps' is a required property > > arch/arm64/boot/dts/qcom/sm8650-qrd.dtb: clock-controller@aaf0000: > 'required-opps' is a required property Considering that there is no bug being fixed, you really do not have to stuff so many error messages. One error msg is enough. They are all the same. Last time you had two, but now it grew to three... Write concise yet informative commit messages. > > Fixes: a6a61b9701d1 ("dt-bindings: clock: qcom: Add SM8650 video clock controller") > Reported-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > Closes: https://lore.kernel.org/all/0f13ab6b-dff1-4b26-9707-704ae2e2b535@linaro.org/ Does not look right, Vladimir did not report videocc. v4 for such simple fix is already too many, so I give up. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 8/1/24 09:44, Jagadeesh Kona wrote: > On SM8650, the minimum voltage corner supported on MMCX from cmd-db is > sufficient for clock controllers to operate and there is no need to specify > the required-opps. Hence remove the required-opps property from the list of > required properties for SM8650 videocc bindings. > > This fixes: > > arch/arm64/boot/dts/qcom/sm8650-hdk.dtb: clock-controller@aaf0000: > 'required-opps' is a required property > > arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@aaf0000: > 'required-opps' is a required property > > arch/arm64/boot/dts/qcom/sm8650-qrd.dtb: clock-controller@aaf0000: > 'required-opps' is a required property > > Fixes: a6a61b9701d1 ("dt-bindings: clock: qcom: Add SM8650 video clock controller") > Reported-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > Closes: https://lore.kernel.org/all/0f13ab6b-dff1-4b26-9707-704ae2e2b535@linaro.org/ As Krzysztof said absolutely fairly, this one warning was not reported by me. > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202407070147.C9c3oTqS-lkp@intel.com/ > Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> But I'm happy to review the change. Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> -- Best wishes, Vladimir
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml index b2792b4bb554..9829ba28fe0e 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml @@ -44,11 +44,20 @@ required: - compatible - clocks - power-domains - - required-opps - '#power-domain-cells' allOf: - $ref: qcom,gcc.yaml# + - if: + properties: + compatible: + contains: + enum: + - qcom,sm8450-videocc + - qcom,sm8550-videocc + then: + required: + - required-opps unevaluatedProperties: false
On SM8650, the minimum voltage corner supported on MMCX from cmd-db is sufficient for clock controllers to operate and there is no need to specify the required-opps. Hence remove the required-opps property from the list of required properties for SM8650 videocc bindings. This fixes: arch/arm64/boot/dts/qcom/sm8650-hdk.dtb: clock-controller@aaf0000: 'required-opps' is a required property arch/arm64/boot/dts/qcom/sm8650-mtp.dtb: clock-controller@aaf0000: 'required-opps' is a required property arch/arm64/boot/dts/qcom/sm8650-qrd.dtb: clock-controller@aaf0000: 'required-opps' is a required property Fixes: a6a61b9701d1 ("dt-bindings: clock: qcom: Add SM8650 video clock controller") Reported-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> Closes: https://lore.kernel.org/all/0f13ab6b-dff1-4b26-9707-704ae2e2b535@linaro.org/ Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202407070147.C9c3oTqS-lkp@intel.com/ Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> --- .../bindings/clock/qcom,sm8450-videocc.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)