From patchwork Wed Oct 9 06:32:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Zekun X-Patchwork-Id: 13827608 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 087FD15B0FE for ; Wed, 9 Oct 2024 06:36:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728455814; cv=none; b=rPcecAvKctM9DOXiQGtctGwKCKAay1ftxK3RI8LELkUpm2PZC+ujZRWb2gDZmTQdOttNSAjNdpoI+zegTEXZUlah0EQpGEMMHEr9pAs4hrS2jRB4nJjPgr9wxOi2ZmXHBDMGN/7yFGO7KOPO52h7DNYjJ2D0LGDpUcw3W2hGTJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728455814; c=relaxed/simple; bh=8fd4Mcz9d/Dg4W389ZyHJuBMUL0wE2AvyQGU3KncKZU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=M4ZxwO5DGVdQf+b5XbC/mmaWHruib4lL046F9S2v7QE4lPggZq8MaBv/Tr/0anW4MHwkAr4VeR62WMBZdBCD4dUn7HkLBu1jsSTINiYi8VMXI7SFg+q6pOV9+ph99TzO5iL+pETmvJCNfDe6fIiNpOEpkSKvfCn+4a+WnJo7kqg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4XNjmW2F3zzpWXX; Wed, 9 Oct 2024 14:34:51 +0800 (CST) Received: from kwepemf500003.china.huawei.com (unknown [7.202.181.241]) by mail.maildlp.com (Postfix) with ESMTPS id 248921800DE; Wed, 9 Oct 2024 14:36:51 +0800 (CST) Received: from huawei.com (10.175.112.208) by kwepemf500003.china.huawei.com (7.202.181.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 9 Oct 2024 14:36:50 +0800 From: Zhang Zekun To: , , , , , , , CC: , Subject: [PATCH 4/4] clk: socfpga: clk-pll: Fix the use of uninitialized variable Date: Wed, 9 Oct 2024 14:32:29 +0800 Message-ID: <20241009063229.121258-5-zhangzekun11@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20241009063229.121258-1-zhangzekun11@huawei.com> References: <20241009063229.121258-1-zhangzekun11@huawei.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemf500003.china.huawei.com (7.202.181.241) The of_property_read_u32() can fail and leave the variable uninitialized, which will then be used. Return before using the uninitialized variable. Fixes: 97259e99bdc9 ("clk: socfpga: split clk code") Signed-off-by: Zhang Zekun --- drivers/clk/socfpga/clk-pll.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/socfpga/clk-pll.c b/drivers/clk/socfpga/clk-pll.c index 9dcc1b2d2cc0..9c3ce45cb907 100644 --- a/drivers/clk/socfpga/clk-pll.c +++ b/drivers/clk/socfpga/clk-pll.c @@ -82,7 +82,8 @@ static void __init __socfpga_pll_init(struct device_node *node, struct device_node *clkmgr_np; int rc; - of_property_read_u32(node, "reg", ®); + if (of_property_read_u32(node, "reg", ®)) + return; pll_clk = kzalloc(sizeof(*pll_clk), GFP_KERNEL); if (WARN_ON(!pll_clk))