| Message ID | 20241011045736.308338-3-pengfei.li_1@nxp.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
| Series | Add iMX91 clock driver support | expand |
On Thu, Oct 10, 2024 at 09:57:35PM -0700, Pengfei Li wrote: > i.MX91 is similar with i.MX93, only add few new clock compared to i.MX93. > Add i.MX91 related clock definition. > > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com> > Reviewed-by: Frank Li <Frank.Li@nxp.com> > --- > include/dt-bindings/clock/imx93-clock.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h > index 787c9e74dc96..6c685067288b 100644 > --- a/include/dt-bindings/clock/imx93-clock.h > +++ b/include/dt-bindings/clock/imx93-clock.h > @@ -204,6 +204,10 @@ > #define IMX93_CLK_A55_SEL 199 > #define IMX93_CLK_A55_CORE 200 > #define IMX93_CLK_PDM_IPG 201 > -#define IMX93_CLK_END 202 This is supposed to be separate patch, because you are removing something from ABI. If your maintainer NAKed it, then do not sneak it some other way. Sort the problem with maintainer or entire patchset cannot enter. Best regards, Krzysztof
On Thu, Oct 10, 2024 at 09:57:35PM -0700, Pengfei Li wrote: > i.MX91 is similar with i.MX93, only add few new clock compared to i.MX93. > Add i.MX91 related clock definition. > > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com> > Reviewed-by: Frank Li <Frank.Li@nxp.com> > --- > include/dt-bindings/clock/imx93-clock.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) This belongs with the binding patch. > > diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h > index 787c9e74dc96..6c685067288b 100644 > --- a/include/dt-bindings/clock/imx93-clock.h > +++ b/include/dt-bindings/clock/imx93-clock.h > @@ -204,6 +204,10 @@ > #define IMX93_CLK_A55_SEL 199 > #define IMX93_CLK_A55_CORE 200 > #define IMX93_CLK_PDM_IPG 201 > -#define IMX93_CLK_END 202 > +#define IMX91_CLK_ENET1_QOS_TSN 202 > +#define IMX91_CLK_ENET_TIMER 203 > +#define IMX91_CLK_ENET2_REGULAR 204 > +#define IMX91_CLK_ENET2_REGULAR_GATE 205 > +#define IMX91_CLK_ENET1_QOS_TSN_GATE 206 > > #endif > -- > 2.34.1 >
On Fri, Oct 11, 2024 at 04:40:35PM +0200, Krzysztof Kozlowski wrote: > On Thu, Oct 10, 2024 at 09:57:35PM -0700, Pengfei Li wrote: > > i.MX91 is similar with i.MX93, only add few new clock compared to i.MX93. > > Add i.MX91 related clock definition. > > > > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com> > > Reviewed-by: Frank Li <Frank.Li@nxp.com> > > --- > > include/dt-bindings/clock/imx93-clock.h | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h > > index 787c9e74dc96..6c685067288b 100644 > > --- a/include/dt-bindings/clock/imx93-clock.h > > +++ b/include/dt-bindings/clock/imx93-clock.h > > @@ -204,6 +204,10 @@ > > #define IMX93_CLK_A55_SEL 199 > > #define IMX93_CLK_A55_CORE 200 > > #define IMX93_CLK_PDM_IPG 201 > > -#define IMX93_CLK_END 202 > > This is supposed to be separate patch, because you are removing > something from ABI. But "end" defines are not part of the ABI. > > If your maintainer NAKed it, then do not sneak it some other way. Sort > the problem with maintainer or entire patchset cannot enter. > > Best regards, > Krzysztof >
diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h index 787c9e74dc96..6c685067288b 100644 --- a/include/dt-bindings/clock/imx93-clock.h +++ b/include/dt-bindings/clock/imx93-clock.h @@ -204,6 +204,10 @@ #define IMX93_CLK_A55_SEL 199 #define IMX93_CLK_A55_CORE 200 #define IMX93_CLK_PDM_IPG 201 -#define IMX93_CLK_END 202 +#define IMX91_CLK_ENET1_QOS_TSN 202 +#define IMX91_CLK_ENET_TIMER 203 +#define IMX91_CLK_ENET2_REGULAR 204 +#define IMX91_CLK_ENET2_REGULAR_GATE 205 +#define IMX91_CLK_ENET1_QOS_TSN_GATE 206 #endif