| Message ID | 20241017005800.1175419-2-alexey.klimov@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Qualcomm sm6115 LPASS clock controller | expand |
On Thu, Oct 17, 2024 at 01:57:59AM +0100, Alexey Klimov wrote: > From: Konrad Dybcio <konrad.dybcio@linaro.org> > > SM6115 (and its derivatives or similar SoCs) has an LPASS clock > controller block which provides audio-related resets. > > Add bindings for it. That's a v2. > > Cc: Konrad Dybcio <konradybcio@kernel.org> > Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > [alexey.klimov] slightly changed the commit message > Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> My tag? > --- > .../bindings/clock/qcom,sm6115-lpasscc.yaml | 53 +++++++++++++++++++ > .../dt-bindings/clock/qcom,sm6115-lpasscc.h | 15 ++++++ > 2 files changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6115-lpasscc.yaml > create mode 100644 include/dt-bindings/clock/qcom,sm6115-lpasscc.h > +examples: > + - | > + lpass_audiocc: clock-controller@a6a9000 { > + compatible = "qcom,sm6115-lpassaudiocc"; > + reg = <0x0a6a9000 0x1000>; > + #reset-cells = <1>; > + }; > + > + - | > + lpasscc: clock-controller@a7ec000 { > + compatible = "qcom,sm6115-lpasscc"; > + reg = <0x0a7ec000 0x1000>; > + #reset-cells = <1>; > + }; Not much improved. Don't send same code from whatever repo you got, but go via mailing list. Best regards, Krzysztof
On Thu Oct 17, 2024 at 9:39 AM BST, Krzysztof Kozlowski wrote: > On Thu, Oct 17, 2024 at 01:57:59AM +0100, Alexey Klimov wrote: > > From: Konrad Dybcio <konrad.dybcio@linaro.org> > > > > SM6115 (and its derivatives or similar SoCs) has an LPASS clock > > controller block which provides audio-related resets. > > > > Add bindings for it. > > That's a v2. > > > > > Cc: Konrad Dybcio <konradybcio@kernel.org> > > Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > [alexey.klimov] slightly changed the commit message > > Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> > > My tag? > > > --- > > .../bindings/clock/qcom,sm6115-lpasscc.yaml | 53 +++++++++++++++++++ > > .../dt-bindings/clock/qcom,sm6115-lpasscc.h | 15 ++++++ > > 2 files changed, 68 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6115-lpasscc.yaml > > create mode 100644 include/dt-bindings/clock/qcom,sm6115-lpasscc.h > > +examples: > > + - | > > + lpass_audiocc: clock-controller@a6a9000 { > > + compatible = "qcom,sm6115-lpassaudiocc"; > > + reg = <0x0a6a9000 0x1000>; > > + #reset-cells = <1>; > > + }; > > + > > + - | > > + lpasscc: clock-controller@a7ec000 { > > + compatible = "qcom,sm6115-lpasscc"; > > + reg = <0x0a7ec000 0x1000>; > > + #reset-cells = <1>; > > + }; > > Not much improved. Don't send same code from whatever repo you got, but > go via mailing list. Ok, thanks! I was not aware that there was a previous version on maillist ~ a year ago. My impression was that this was never sent for review. I'll update and resend it as v2 if there are no objections so it will become a proper v2. I am more interested what should be done regarding older email addresses or maybe .mailmap will handle it correctly. Best regards, Alexey
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6115-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6115-lpasscc.yaml new file mode 100644 index 000000000000..58ee84aed073 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/qcom,sm6115-lpasscc.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/qcom,sm6115-lpasscc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm LPASS Core & Audio Clock Controller on SM6115 + +maintainers: + - Konrad Dybcio <konrad.dybcio@linaro.org> + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org> + +description: | + Qualcomm LPASS core and audio clock controllers provide audio-related resets + on SM6115 and its derivatives. + + See also:: + include/dt-bindings/clock/qcom,sm6115-lpasscc.h + +properties: + compatible: + enum: + - qcom,sm6115-lpassaudiocc + - qcom,sm6115-lpasscc + + reg: + maxItems: 1 + + '#reset-cells': + const: 1 + +required: + - compatible + - reg + - '#reset-cells' + +additionalProperties: false + +examples: + - | + lpass_audiocc: clock-controller@a6a9000 { + compatible = "qcom,sm6115-lpassaudiocc"; + reg = <0x0a6a9000 0x1000>; + #reset-cells = <1>; + }; + + - | + lpasscc: clock-controller@a7ec000 { + compatible = "qcom,sm6115-lpasscc"; + reg = <0x0a7ec000 0x1000>; + #reset-cells = <1>; + }; +... diff --git a/include/dt-bindings/clock/qcom,sm6115-lpasscc.h b/include/dt-bindings/clock/qcom,sm6115-lpasscc.h new file mode 100644 index 000000000000..799274517c9a --- /dev/null +++ b/include/dt-bindings/clock/qcom,sm6115-lpasscc.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (c) 2023, Linaro Ltd. + */ + +#ifndef _DT_BINDINGS_CLK_QCOM_LPASSCC_SM6115_H +#define _DT_BINDINGS_CLK_QCOM_LPASSCC_SM6115_H + +/* LPASS CC */ +#define LPASS_SWR_TX_CONFIG_CGCR 0 + +/* LPASS_AUDIO CC */ +#define LPASS_AUDIO_SWR_RX_CGCR 0 + +#endif