diff mbox series

[1/7] dt-bindings: clock: qcom-rpmhcc: Add RPMHCC bindings for SM8750

Message ID 20241021230359.2632414-2-quic_molvera@quicinc.com (mailing list archive)
State Changes Requested, archived
Headers show
Series clks: qcom: Introduce clks for SM8750 | expand

Commit Message

Melody Olvera Oct. 21, 2024, 11:03 p.m. UTC 
From: Taniya Das <quic_tdas@quicinc.com>

Add bindings and update documentation for clock rpmh driver on SM8750
SoCs.

Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
 Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 +
 include/dt-bindings/clock/qcom,rpmh.h                    | 2 ++
 2 files changed, 3 insertions(+)

Comments

Krzysztof Kozlowski Oct. 22, 2024, 6:16 a.m. UTC | #1 
On Mon, Oct 21, 2024 at 04:03:53PM -0700, Melody Olvera wrote:
> From: Taniya Das <quic_tdas@quicinc.com>
> 
> Add bindings and update documentation for clock rpmh driver on SM8750
> SoCs.
> 
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---

A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

This applies to all your patches.

There is already CXO clock, so why pad is needed? All of these clocks
come via some pad, right? Commit msg could explain here this. Otherwise
it just duplicates the diff.

Best regards,
Krzysztof
Taniya Das Nov. 6, 2024, 6:14 p.m. UTC | #2 
On 10/22/2024 11:46 AM, Krzysztof Kozlowski wrote:
> On Mon, Oct 21, 2024 at 04:03:53PM -0700, Melody Olvera wrote:
>> From: Taniya Das <quic_tdas@quicinc.com>
>>
>> Add bindings and update documentation for clock rpmh driver on SM8750
>> SoCs.
>>
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
> 
> A nit, subject: drop second/last, redundant "bindings for". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 
> This applies to all your patches.
> 

I will remove the extra "bindings" in the next patch and also cleanup 
where ever required.

> There is already CXO clock, so why pad is needed? All of these clocks
> come via some pad, right? Commit msg could explain here this. Otherwise
> it just duplicates the diff.
> 

Yes, I will fix the CXO clock and remove the newly added pad clock in 
the next patch.

> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
index ca857942ed6c..b12a233e0e7b 100644
--- a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
@@ -36,6 +36,7 @@  properties:
       - qcom,sm8450-rpmh-clk
       - qcom,sm8550-rpmh-clk
       - qcom,sm8650-rpmh-clk
+      - qcom,sm8750-rpmh-clk
       - qcom,x1e80100-rpmh-clk
 
   clocks:
diff --git a/include/dt-bindings/clock/qcom,rpmh.h b/include/dt-bindings/clock/qcom,rpmh.h
index 0a7d1be0d124..f3e0288420ce 100644
--- a/include/dt-bindings/clock/qcom,rpmh.h
+++ b/include/dt-bindings/clock/qcom,rpmh.h
@@ -33,5 +33,7 @@ 
 #define RPMH_HWKM_CLK				24
 #define RPMH_QLINK_CLK				25
 #define RPMH_QLINK_CLK_A			26
+#define RPMH_CXO_PAD_CLK			27
+#define RPMH_CXO_PAD_CLK_A			28
 
 #endif