| Message ID | 20241106090549.3684963-2-dario.binacchi@amarulasolutions.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Support spread spectrum clocking for i.MX8{M,N,P} PLLs | expand |
On Wed, Nov 06, 2024 at 09:57:57AM +0100, Dario Binacchi wrote: > The patch adds the DT bindings for enabling and tuning spread spectrum > clocking generation. We had long talks about this but nothing of it got reflected in commit msg. Sorry, I don't remember what I was talking in some particular patch month ago, so you will get the same questions over and over... > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > > --- > > Changes in v3: > - Added in v3 > - The dt-bindings have been moved from fsl,imx8m-anatop.yaml to > imx8m-clock.yaml. The anatop device (fsl,imx8m-anatop.yaml) is > indeed more or less a syscon, so it represents a memory area > accessible by ccm (imx8m-clock.yaml) to setup the PLLs. > > .../bindings/clock/imx8m-clock.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > index c643d4a81478..7920393e518e 100644 > --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > @@ -43,6 +43,40 @@ properties: > ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8m-clock.h > for the full list of i.MX8M clock IDs. > > + fsl,ssc-clocks: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: > + Phandles of the PLL with spread spectrum generation hardware capability. > + minItems: 1 > + maxItems: 4 1. How is it possible that you change spread spectrum of some clocks from main Clock Controller, while this device is not a consumer of them? Basically this means that this device does not have these clocks but yet you claim that it needs to configure spread for them! It's contradictory to me and nohing got explained in commit msg about it. I am pretty sure I asked about this alrady. 2. Why is this array flexible in size? Best regards, Krzysztof
On 06/11/2024 15:10, Krzysztof Kozlowski wrote: > On Wed, Nov 06, 2024 at 09:57:57AM +0100, Dario Binacchi wrote: >> The patch adds the DT bindings for enabling and tuning spread spectrum >> clocking generation. > > We had long talks about this but nothing of it got reflected in commit > msg. Sorry, I don't remember what I was talking in some particular patch > month ago, so you will get the same questions over and over... > >> >> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> >> >> --- >> >> Changes in v3: >> - Added in v3 >> - The dt-bindings have been moved from fsl,imx8m-anatop.yaml to >> imx8m-clock.yaml. The anatop device (fsl,imx8m-anatop.yaml) is >> indeed more or less a syscon, so it represents a memory area >> accessible by ccm (imx8m-clock.yaml) to setup the PLLs. >> >> .../bindings/clock/imx8m-clock.yaml | 46 +++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml >> index c643d4a81478..7920393e518e 100644 >> --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml >> +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml >> @@ -43,6 +43,40 @@ properties: >> ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8m-clock.h >> for the full list of i.MX8M clock IDs. >> >> + fsl,ssc-clocks: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: >> + Phandles of the PLL with spread spectrum generation hardware capability. >> + minItems: 1 >> + maxItems: 4 > > 1. How is it possible that you change spread spectrum of some clocks from > main Clock Controller, while this device is not a consumer of them? > Basically this means that this device does not have these clocks but yet > you claim that it needs to configure spread for them! It's contradictory > to me and nohing got explained in commit msg about it. I am pretty sure > I asked about this alrady. I digged my previous answer and it was pretty clear here: 18:44 <krzk> You can, but I still have the same concerns. How this device - which does not take any clock input, has no clocks at all - can depend on spread spectrum of some PLLs? Thsi device does not have clocks. 18:50 <krzk> device has no clocks, I checked now third time 18:50 <krzk> If device has clocks, it must have clocks property So again, you do not need this property at all. I repeated it multiple times - you are supposed to use clocks property. > > 2. Why is this array flexible in size? > > Best regards, > Krzysztof > Best regards, Krzysztof
Hello Krzysztof, On Wed, Nov 6, 2024 at 3:13 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 06/11/2024 15:10, Krzysztof Kozlowski wrote: > > On Wed, Nov 06, 2024 at 09:57:57AM +0100, Dario Binacchi wrote: > >> The patch adds the DT bindings for enabling and tuning spread spectrum > >> clocking generation. > > > > We had long talks about this but nothing of it got reflected in commit > > msg. Sorry, I don't remember what I was talking in some particular patch > > month ago, so you will get the same questions over and over... > > > >> > >> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > >> > >> --- > >> > >> Changes in v3: > >> - Added in v3 > >> - The dt-bindings have been moved from fsl,imx8m-anatop.yaml to > >> imx8m-clock.yaml. The anatop device (fsl,imx8m-anatop.yaml) is > >> indeed more or less a syscon, so it represents a memory area > >> accessible by ccm (imx8m-clock.yaml) to setup the PLLs. > >> > >> .../bindings/clock/imx8m-clock.yaml | 46 +++++++++++++++++++ > >> 1 file changed, 46 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > >> index c643d4a81478..7920393e518e 100644 > >> --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > >> +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > >> @@ -43,6 +43,40 @@ properties: > >> ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8m-clock.h > >> for the full list of i.MX8M clock IDs. > >> > >> + fsl,ssc-clocks: > >> + $ref: /schemas/types.yaml#/definitions/phandle-array > >> + description: > >> + Phandles of the PLL with spread spectrum generation hardware capability. > >> + minItems: 1 > >> + maxItems: 4 > > > > 1. How is it possible that you change spread spectrum of some clocks from > > main Clock Controller, while this device is not a consumer of them? > > Basically this means that this device does not have these clocks but yet > > you claim that it needs to configure spread for them! It's contradictory > > to me and nohing got explained in commit msg about it. I am pretty sure > > I asked about this alrady. > > I digged my previous answer and it was pretty clear here: > > 18:44 <krzk> You can, but I still have the same concerns. How this > device - which does not take any clock input, has no clocks at all - can > depend on spread spectrum of some PLLs? Thsi device does not have clocks. > 18:50 <krzk> device has no clocks, I checked now third time > 18:50 <krzk> If device has clocks, it must have clocks property > The device where the spread spectrum properties are to be set already contains "clocks" properties: clk: clock-controller@30380000 { compatible = "fsl,imx8mn-ccm"; reg = <0x30380000 0x10000>; interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>; #clock-cells = <1>; clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, <&clk_ext3>, <&clk_ext4>; clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", "clk_ext3", "clk_ext4"; assigned-clocks = <&clk IMX8MN_CLK_A53_SRC>, <&clk IMX8MN_CLK_A53_CORE>, <&clk IMX8MN_CLK_NOC>, <&clk IMX8MN_CLK_AUDIO_AHB>, <&clk IMX8MN_CLK_IPG_AUDIO_ROOT>, <&clk IMX8MN_SYS_PLL3>, <&clk IMX8MN_AUDIO_PLL1>, <&clk IMX8MN_AUDIO_PLL2>; assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_800M>, <&clk IMX8MN_ARM_PLL_OUT>, <&clk IMX8MN_SYS_PLL3_OUT>, <&clk IMX8MN_SYS_PLL1_800M>; assigned-clock-rates = <0>, <0>, <0>, <400000000>, <400000000>, <600000000>, <393216000>, <361267200>; }; The spread spectrum is not configurable on these clocks or, more generally, may not be configurable (only 4 PLLs have this capability). Therefore, I need the "fsl,ssc-clocks" property to list the PLLs on which I want to enable and configure spread spectrum. Furthermore, spread spectrum cannot be considered a new device but rather a property available only for some of the clocks managed by the clock controller manager (CCM). Thanks and regards, Dario > So again, you do not need this property at all. I repeated it multiple > times - you are supposed to use clocks property. > > > > > 2. Why is this array flexible in size? > > > > Best regards, > > Krzysztof > > > > Best regards, > Krzysztof > -- Dario Binacchi Senior Embedded Linux Developer dario.binacchi@amarulasolutions.com
On 07/11/2024 15:57, Dario Binacchi wrote: > clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, > <&clk_ext3>, <&clk_ext4>; > clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", > "clk_ext3", "clk_ext4"; > assigned-clocks = <&clk IMX8MN_CLK_A53_SRC>, > <&clk IMX8MN_CLK_A53_CORE>, > <&clk IMX8MN_CLK_NOC>, > <&clk IMX8MN_CLK_AUDIO_AHB>, > <&clk IMX8MN_CLK_IPG_AUDIO_ROOT>, > <&clk IMX8MN_SYS_PLL3>, > <&clk IMX8MN_AUDIO_PLL1>, > <&clk IMX8MN_AUDIO_PLL2>; > assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_800M>, > <&clk IMX8MN_ARM_PLL_OUT>, > <&clk IMX8MN_SYS_PLL3_OUT>, > <&clk IMX8MN_SYS_PLL1_800M>; > assigned-clock-rates = <0>, <0>, <0>, > <400000000>, > <400000000>, > <600000000>, > <393216000>, > <361267200>; > }; > > The spread spectrum is not configurable on these clocks or, more > generally, may not be > configurable (only 4 PLLs have this capability). Therefore, I need the > "fsl,ssc-clocks" No. That's not true. You do not need it. First, the clock inputs for this device are listed in clocks *only*. What is no there, is not an input to the device. Including also Linux aspect (missing devlinks etc). Therefore how can you configure spread spectrum on clocks which are not connected to this device? Second, I do no ask you to configure spread spectrum on other clocks, only on the ones you intent to. List is fixed and ordered, so no problem with that. > property to list the PLLs on which I want to enable and configure > spread spectrum. > > Furthermore, spread spectrum cannot be considered a new device but > rather a property > available only for some of the clocks managed by the clock controller > manager (CCM). > My comment stands and that's a disagreement from me. Feel free to get second DT maintainer opinion, though. Best regards, Krzysztof
> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: support > spread spectrum clocking > > On 07/11/2024 15:57, Dario Binacchi wrote: > > clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, > > <&clk_ext3>, <&clk_ext4>; > > clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", > > "clk_ext3", "clk_ext4"; > > assigned-clocks = <&clk IMX8MN_CLK_A53_SRC>, > > <&clk IMX8MN_CLK_A53_CORE>, > > <&clk IMX8MN_CLK_NOC>, > > <&clk IMX8MN_CLK_AUDIO_AHB>, > > <&clk IMX8MN_CLK_IPG_AUDIO_ROOT>, > > <&clk IMX8MN_SYS_PLL3>, > > <&clk IMX8MN_AUDIO_PLL1>, > > <&clk IMX8MN_AUDIO_PLL2>; > > assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_800M>, > > <&clk IMX8MN_ARM_PLL_OUT>, > > <&clk IMX8MN_SYS_PLL3_OUT>, > > <&clk IMX8MN_SYS_PLL1_800M>; > > assigned-clock-rates = <0>, <0>, <0>, > > <400000000>, > > <400000000>, > > <600000000>, > > <393216000>, > > <361267200>; }; > > > > The spread spectrum is not configurable on these clocks or, more > > generally, may not be configurable (only 4 PLLs have this capability). > > Therefore, I need the "fsl,ssc-clocks" > > No. That's not true. You do not need it. > i.MX8M clock hardware is similar as: OSC->ANATOP->CCM ANATOP will produce PLLs. CCM use PLLs as input source. Currently there is no dedicated ANATOP driver in linux. The CCM linux driver will parse the ANATOP node and register clk_hw for the PLLs. > First, the clock inputs for this device are listed in clocks *only*. > What is no there, is not an input to the device. Including also Linux > aspect (missing devlinks etc). Therefore how can you configure spread > spectrum on clocks which are not connected to this device? I not understand this well, you mean add clocks = <xx CLK_IMX8MM_VIDEO_PLL> in the ccm dtb node? Currently the CLK_IMX8MM_VIDEO_PLL is registers by CCM driver, so impossible the add the upper clocks, unless a dedicated anatop driver is developed. Thanks Peng. > > Second, I do no ask you to configure spread spectrum on other clocks, > only on the ones you intent to. List is fixed and ordered, so no problem > with that. > > > property to list the PLLs on which I want to enable and configure > > spread spectrum. > > > > Furthermore, spread spectrum cannot be considered a new device > but > > rather a property available only for some of the clocks managed by > the > > clock controller manager (CCM). > > > > My comment stands and that's a disagreement from me. Feel free to > get second DT maintainer opinion, though. > > Best regards, > Krzysztof >
On 08/11/2024 13:50, Peng Fan wrote: >> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: support >> spread spectrum clocking >> >> On 07/11/2024 15:57, Dario Binacchi wrote: >>> clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, >>> <&clk_ext3>, <&clk_ext4>; >>> clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", >>> "clk_ext3", "clk_ext4"; >>> assigned-clocks = <&clk IMX8MN_CLK_A53_SRC>, >>> <&clk IMX8MN_CLK_A53_CORE>, >>> <&clk IMX8MN_CLK_NOC>, >>> <&clk IMX8MN_CLK_AUDIO_AHB>, >>> <&clk IMX8MN_CLK_IPG_AUDIO_ROOT>, >>> <&clk IMX8MN_SYS_PLL3>, >>> <&clk IMX8MN_AUDIO_PLL1>, >>> <&clk IMX8MN_AUDIO_PLL2>; >>> assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_800M>, >>> <&clk IMX8MN_ARM_PLL_OUT>, >>> <&clk IMX8MN_SYS_PLL3_OUT>, >>> <&clk IMX8MN_SYS_PLL1_800M>; >>> assigned-clock-rates = <0>, <0>, <0>, >>> <400000000>, >>> <400000000>, >>> <600000000>, >>> <393216000>, >>> <361267200>; }; >>> >>> The spread spectrum is not configurable on these clocks or, more >>> generally, may not be configurable (only 4 PLLs have this capability). >>> Therefore, I need the "fsl,ssc-clocks" >> >> No. That's not true. You do not need it. >> > > i.MX8M clock hardware is similar as: > > OSC->ANATOP->CCM > > ANATOP will produce PLLs. > CCM use PLLs as input source. > > Currently there is no dedicated ANATOP driver in linux. > The CCM linux driver will parse the ANATOP node and > register clk_hw for the PLLs. I do not know what is CCM and how does it fit here. What's more, I don't get driver context here. We talk about bindings. > > >> First, the clock inputs for this device are listed in clocks *only*. >> What is no there, is not an input to the device. Including also Linux >> aspect (missing devlinks etc). Therefore how can you configure spread >> spectrum on clocks which are not connected to this device? > > I not understand this well, you mean > add clocks = <xx CLK_IMX8MM_VIDEO_PLL> in the ccm dtb node? Yes. Let me re-iterate and please respond to this exactly comment instead of ignoring it. How a device can care about spread spectrum of a clock which is not supplied to this device? Why would you care about spread spectrum of some clock which is not coming to this device? Please address these precisely because we talk about this for weeks in multiple places. I finish with this patchset if you do not provide such context. Best regards, Krzysztof
> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: support > spread spectrum clocking > > On 08/11/2024 13:50, Peng Fan wrote: > >> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: > support > >> spread spectrum clocking > >> > >> On 07/11/2024 15:57, Dario Binacchi wrote: > >>> clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, > >>> <&clk_ext3>, <&clk_ext4>; > >>> clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", > >>> "clk_ext3", "clk_ext4"; > >>> assigned-clocks = <&clk IMX8MN_CLK_A53_SRC>, > >>> <&clk IMX8MN_CLK_A53_CORE>, > >>> <&clk IMX8MN_CLK_NOC>, > >>> <&clk IMX8MN_CLK_AUDIO_AHB>, > >>> <&clk IMX8MN_CLK_IPG_AUDIO_ROOT>, > >>> <&clk IMX8MN_SYS_PLL3>, > >>> <&clk IMX8MN_AUDIO_PLL1>, > >>> <&clk IMX8MN_AUDIO_PLL2>; > >>> assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_800M>, > >>> <&clk IMX8MN_ARM_PLL_OUT>, > >>> <&clk IMX8MN_SYS_PLL3_OUT>, > >>> <&clk IMX8MN_SYS_PLL1_800M>; > >>> assigned-clock-rates = <0>, <0>, <0>, > >>> <400000000>, > >>> <400000000>, > >>> <600000000>, > >>> <393216000>, > >>> <361267200>; }; > >>> > >>> The spread spectrum is not configurable on these clocks or, more > >>> generally, may not be configurable (only 4 PLLs have this > capability). > >>> Therefore, I need the "fsl,ssc-clocks" > >> > >> No. That's not true. You do not need it. > >> > > > > i.MX8M clock hardware is similar as: > > > > OSC->ANATOP->CCM > > > > ANATOP will produce PLLs. > > CCM use PLLs as input source. > > > > Currently there is no dedicated ANATOP driver in linux. > > The CCM linux driver will parse the ANATOP node and register clk_hw > > for the PLLs. > > I do not know what is CCM and how does it fit here. What's more, I > don't get driver context here. We talk about bindings. CCM: Clock Control Module, it accepts PLL from anatop as inputs, and outputs clocks to various modules, I2C, CAN, NET, SAI and ... > > > > > > > >> First, the clock inputs for this device are listed in clocks *only*. > >> What is no there, is not an input to the device. Including also Linux > >> aspect (missing devlinks etc). Therefore how can you configure > spread > >> spectrum on clocks which are not connected to this device? > > > > I not understand this well, you mean > > add clocks = <xx CLK_IMX8MM_VIDEO_PLL> in the ccm dtb node? > > Yes. Let me re-iterate and please respond to this exactly comment > instead of ignoring it. > > How a device can care about spread spectrum of a clock which is not > supplied to this device? I hope we are on same page of what spread spectrum means. spread spectrum of a clock is the clock could produce freq in a range, saying [500MHz - 100KHz, 500MHz + 100KHz]. software only need to configure the middle frequency and choose the up/down border range(100KHz here) and enable spread spectrum. device: I suppose you mean the Clock Control Module(CCM) here. CCM does not care, it just accepts the PLL as input, and output divided clock to various IPs(Video here). The video IPs care about the spread spectrum of the clock. The clock hardware path is as below: OSC(24M) --> Anatop(produce PLL with spread spectrum) -> Clock Control Module(output clock to modules) -> Video IP From hardware perspective, Clock Control Module does not care spread spectrum. Video IP cares spread spectrum. > > Why would you care about spread spectrum of some clock which is not > coming to this device? device, I suppose you mean clock control module(CCM). There is no 'clocks = <&ccm CLK_IMX8M_VIDEO_PLL>' under ccm node. Because in current design, ccm is taken as producer of CLK_IMX8M_VIDEO_PLL, not consumer. > > Please address these precisely because we talk about this for weeks in > multiple places. Sorry for coming into this feature in late stage. Dario, thanks for working on such feature, good to see. Spread Spectrum is indeed good feature what makes clock quality high. Thanks, Peng. I finish with this patchset if you do not provide such > context. > > Best regards, > Krzysztof
On Fri, Nov 8, 2024 at 6:37 PM Peng Fan <peng.fan@nxp.com> wrote: > > > Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: support > > spread spectrum clocking > > > > On 08/11/2024 13:50, Peng Fan wrote: > > >> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: > > support > > >> spread spectrum clocking > > >> > > >> On 07/11/2024 15:57, Dario Binacchi wrote: > > >>> clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, > > >>> <&clk_ext3>, <&clk_ext4>; > > >>> clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", > > >>> "clk_ext3", "clk_ext4"; > > >>> assigned-clocks = <&clk IMX8MN_CLK_A53_SRC>, > > >>> <&clk IMX8MN_CLK_A53_CORE>, > > >>> <&clk IMX8MN_CLK_NOC>, > > >>> <&clk IMX8MN_CLK_AUDIO_AHB>, > > >>> <&clk IMX8MN_CLK_IPG_AUDIO_ROOT>, > > >>> <&clk IMX8MN_SYS_PLL3>, > > >>> <&clk IMX8MN_AUDIO_PLL1>, > > >>> <&clk IMX8MN_AUDIO_PLL2>; > > >>> assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_800M>, > > >>> <&clk IMX8MN_ARM_PLL_OUT>, > > >>> <&clk IMX8MN_SYS_PLL3_OUT>, > > >>> <&clk IMX8MN_SYS_PLL1_800M>; > > >>> assigned-clock-rates = <0>, <0>, <0>, > > >>> <400000000>, > > >>> <400000000>, > > >>> <600000000>, > > >>> <393216000>, > > >>> <361267200>; }; > > >>> > > >>> The spread spectrum is not configurable on these clocks or, more > > >>> generally, may not be configurable (only 4 PLLs have this > > capability). > > >>> Therefore, I need the "fsl,ssc-clocks" > > >> > > >> No. That's not true. You do not need it. > > >> > > > > > > i.MX8M clock hardware is similar as: > > > > > > OSC->ANATOP->CCM > > > > > > ANATOP will produce PLLs. > > > CCM use PLLs as input source. > > > > > > Currently there is no dedicated ANATOP driver in linux. > > > The CCM linux driver will parse the ANATOP node and register clk_hw > > > for the PLLs. > > > > I do not know what is CCM and how does it fit here. What's more, I > > don't get driver context here. We talk about bindings. > > > CCM: Clock Control Module, it accepts PLL from anatop as inputs, > and outputs clocks to various modules, I2C, CAN, NET, SAI and ... > > > > > > > > > > > > > >> First, the clock inputs for this device are listed in clocks *only*. > > >> What is no there, is not an input to the device. Including also Linux > > >> aspect (missing devlinks etc). Therefore how can you configure > > spread > > >> spectrum on clocks which are not connected to this device? > > > > > > I not understand this well, you mean > > > add clocks = <xx CLK_IMX8MM_VIDEO_PLL> in the ccm dtb node? > > > > Yes. Let me re-iterate and please respond to this exactly comment > > instead of ignoring it. > > > > How a device can care about spread spectrum of a clock which is not > > supplied to this device? > > I hope we are on same page of what spread spectrum means. > spread spectrum of a clock is the clock could produce freq in a range, > saying [500MHz - 100KHz, 500MHz + 100KHz]. software only need > to configure the middle frequency and choose the up/down border > range(100KHz here) and enable spread spectrum. > > device: I suppose you mean the Clock Control Module(CCM) here. > CCM does not care, it just accepts the PLL as input, and output > divided clock to various IPs(Video here). The video IPs care about > the spread spectrum of the clock. > > The clock hardware path is as below: > > OSC(24M) --> Anatop(produce PLL with spread spectrum) -> > Clock Control Module(output clock to modules) -> Video IP > > From hardware perspective, Clock Control Module does not > care spread spectrum. Video IP cares spread spectrum. > > > > > > Why would you care about spread spectrum of some clock which is not > > coming to this device? > > device, I suppose you mean clock control module(CCM). > > There is no 'clocks = <&ccm CLK_IMX8M_VIDEO_PLL>' under ccm node. > Because in current design, ccm is taken as producer of > CLK_IMX8M_VIDEO_PLL, not consumer. > > > > > Please address these precisely because we talk about this for weeks in > > multiple places. > > Sorry for coming into this feature in late stage. > > Dario, thanks for working on such feature, good to see. Spread Spectrum > is indeed good feature what makes clock quality high. I am also excited to see the spread-spectum clocks enabled. We've struggled with EMC testing in the past, and I want to reevaluate at least one board with the spread-spectrum enabled to see how it compares. Thank you for working on this. adam > > Thanks, > Peng. > > I finish with this patchset if you do not provide such > > context. > > > > Best regards, > > Krzysztof >
On 09/11/2024 01:37, Peng Fan wrote: >> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: support >> spread spectrum clocking >> >> On 08/11/2024 13:50, Peng Fan wrote: >>>> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: >> support >>>> spread spectrum clocking >>>> >>>> On 07/11/2024 15:57, Dario Binacchi wrote: >>>>> clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, >>>>> <&clk_ext3>, <&clk_ext4>; >>>>> clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", >>>>> "clk_ext3", "clk_ext4"; >>>>> assigned-clocks = <&clk IMX8MN_CLK_A53_SRC>, >>>>> <&clk IMX8MN_CLK_A53_CORE>, >>>>> <&clk IMX8MN_CLK_NOC>, >>>>> <&clk IMX8MN_CLK_AUDIO_AHB>, >>>>> <&clk IMX8MN_CLK_IPG_AUDIO_ROOT>, >>>>> <&clk IMX8MN_SYS_PLL3>, >>>>> <&clk IMX8MN_AUDIO_PLL1>, >>>>> <&clk IMX8MN_AUDIO_PLL2>; >>>>> assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_800M>, >>>>> <&clk IMX8MN_ARM_PLL_OUT>, >>>>> <&clk IMX8MN_SYS_PLL3_OUT>, >>>>> <&clk IMX8MN_SYS_PLL1_800M>; >>>>> assigned-clock-rates = <0>, <0>, <0>, >>>>> <400000000>, >>>>> <400000000>, >>>>> <600000000>, >>>>> <393216000>, >>>>> <361267200>; }; >>>>> >>>>> The spread spectrum is not configurable on these clocks or, more >>>>> generally, may not be configurable (only 4 PLLs have this >> capability). >>>>> Therefore, I need the "fsl,ssc-clocks" >>>> >>>> No. That's not true. You do not need it. >>>> >>> >>> i.MX8M clock hardware is similar as: >>> >>> OSC->ANATOP->CCM >>> >>> ANATOP will produce PLLs. >>> CCM use PLLs as input source. >>> >>> Currently there is no dedicated ANATOP driver in linux. >>> The CCM linux driver will parse the ANATOP node and register clk_hw >>> for the PLLs. >> >> I do not know what is CCM and how does it fit here. What's more, I >> don't get driver context here. We talk about bindings. > > > CCM: Clock Control Module, it accepts PLL from anatop as inputs, > and outputs clocks to various modules, I2C, CAN, NET, SAI and ... > >> >> >>> >>> >>>> First, the clock inputs for this device are listed in clocks *only*. >>>> What is no there, is not an input to the device. Including also Linux >>>> aspect (missing devlinks etc). Therefore how can you configure >> spread >>>> spectrum on clocks which are not connected to this device? >>> >>> I not understand this well, you mean >>> add clocks = <xx CLK_IMX8MM_VIDEO_PLL> in the ccm dtb node? >> >> Yes. Let me re-iterate and please respond to this exactly comment >> instead of ignoring it. >> >> How a device can care about spread spectrum of a clock which is not >> supplied to this device? > > I hope we are on same page of what spread spectrum means. > spread spectrum of a clock is the clock could produce freq in a range, > saying [500MHz - 100KHz, 500MHz + 100KHz]. software only need > to configure the middle frequency and choose the up/down border > range(100KHz here) and enable spread spectrum. > > device: I suppose you mean the Clock Control Module(CCM) here. I mean the device we discuss here, in this binding. Whatever this device is. CCM or CCX > CCM does not care, it just accepts the PLL as input, and output Takes PLL as input but you refuse to add it as clocks? Are you really responding to my question? I asked how can you set spread spectrum on clock which you do not receive. Why you do not receive? Because you refuse to add it to clocks even though I speak about this since months. > divided clock to various IPs(Video here). The video IPs care about > the spread spectrum of the clock. So which device do we talk about? I am not a NXP clock developer and I care zero about NXP, so keep it simple. We discuss this one specific binding for specific device which is called "imx8m-clock" - see subject prefix. > > The clock hardware path is as below: > > OSC(24M) --> Anatop(produce PLL with spread spectrum) -> > Clock Control Module(output clock to modules) -> Video IP > > From hardware perspective, Clock Control Module does not > care spread spectrum. Video IP cares spread spectrum. > > >> >> Why would you care about spread spectrum of some clock which is not >> coming to this device? > > device, I suppose you mean clock control module(CCM). > > There is no 'clocks = <&ccm CLK_IMX8M_VIDEO_PLL>' under ccm node. > Because in current design, ccm is taken as producer of > CLK_IMX8M_VIDEO_PLL, not consumer. I don't understand now even more. Or I understand even less now. Why binding references its own clocks via phandle? This makes no sense at all, except of course assigned clocks, but that's because we have one property for multiple cases. Best regards, Krzysztof
On 09/11/2024 11:05, Krzysztof Kozlowski wrote: > On 09/11/2024 01:37, Peng Fan wrote: >>> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: support >>> spread spectrum clocking >>> >>> On 08/11/2024 13:50, Peng Fan wrote: >>>>> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: >>> support >>>>> spread spectrum clocking >>>>> >>>>> On 07/11/2024 15:57, Dario Binacchi wrote: >>>>>> clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, >>>>>> <&clk_ext3>, <&clk_ext4>; >>>>>> clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", >>>>>> "clk_ext3", "clk_ext4"; >>>>>> assigned-clocks = <&clk IMX8MN_CLK_A53_SRC>, >>>>>> <&clk IMX8MN_CLK_A53_CORE>, >>>>>> <&clk IMX8MN_CLK_NOC>, >>>>>> <&clk IMX8MN_CLK_AUDIO_AHB>, >>>>>> <&clk IMX8MN_CLK_IPG_AUDIO_ROOT>, >>>>>> <&clk IMX8MN_SYS_PLL3>, >>>>>> <&clk IMX8MN_AUDIO_PLL1>, >>>>>> <&clk IMX8MN_AUDIO_PLL2>; >>>>>> assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_800M>, >>>>>> <&clk IMX8MN_ARM_PLL_OUT>, >>>>>> <&clk IMX8MN_SYS_PLL3_OUT>, >>>>>> <&clk IMX8MN_SYS_PLL1_800M>; >>>>>> assigned-clock-rates = <0>, <0>, <0>, >>>>>> <400000000>, >>>>>> <400000000>, >>>>>> <600000000>, >>>>>> <393216000>, >>>>>> <361267200>; }; >>>>>> >>>>>> The spread spectrum is not configurable on these clocks or, more >>>>>> generally, may not be configurable (only 4 PLLs have this >>> capability). >>>>>> Therefore, I need the "fsl,ssc-clocks" >>>>> >>>>> No. That's not true. You do not need it. >>>>> >>>> >>>> i.MX8M clock hardware is similar as: >>>> >>>> OSC->ANATOP->CCM >>>> >>>> ANATOP will produce PLLs. >>>> CCM use PLLs as input source. >>>> >>>> Currently there is no dedicated ANATOP driver in linux. >>>> The CCM linux driver will parse the ANATOP node and register clk_hw >>>> for the PLLs. >>> >>> I do not know what is CCM and how does it fit here. What's more, I >>> don't get driver context here. We talk about bindings. >> >> >> CCM: Clock Control Module, it accepts PLL from anatop as inputs, >> and outputs clocks to various modules, I2C, CAN, NET, SAI and ... >> >>> >>> >>>> >>>> >>>>> First, the clock inputs for this device are listed in clocks *only*. >>>>> What is no there, is not an input to the device. Including also Linux >>>>> aspect (missing devlinks etc). Therefore how can you configure >>> spread >>>>> spectrum on clocks which are not connected to this device? >>>> >>>> I not understand this well, you mean >>>> add clocks = <xx CLK_IMX8MM_VIDEO_PLL> in the ccm dtb node? >>> >>> Yes. Let me re-iterate and please respond to this exactly comment >>> instead of ignoring it. >>> >>> How a device can care about spread spectrum of a clock which is not >>> supplied to this device? >> >> I hope we are on same page of what spread spectrum means. >> spread spectrum of a clock is the clock could produce freq in a range, >> saying [500MHz - 100KHz, 500MHz + 100KHz]. software only need >> to configure the middle frequency and choose the up/down border >> range(100KHz here) and enable spread spectrum. >> >> device: I suppose you mean the Clock Control Module(CCM) here. > > I mean the device we discuss here, in this binding. Whatever this device > is. CCM or CCX > >> CCM does not care, it just accepts the PLL as input, and output > > Takes PLL as input but you refuse to add it as clocks? Are you really > responding to my question? > > I asked how can you set spread spectrum on clock which you do not > receive. Why you do not receive? Because you refuse to add it to clocks > even though I speak about this since months. > >> divided clock to various IPs(Video here). The video IPs care about >> the spread spectrum of the clock. > > So which device do we talk about? I am not a NXP clock developer and I > care zero about NXP, so keep it simple. We discuss this one specific > binding for specific device which is called "imx8m-clock" - see subject > prefix. > >> >> The clock hardware path is as below: >> >> OSC(24M) --> Anatop(produce PLL with spread spectrum) -> >> Clock Control Module(output clock to modules) -> Video IP >> >> From hardware perspective, Clock Control Module does not >> care spread spectrum. Video IP cares spread spectrum. >> >> >>> >>> Why would you care about spread spectrum of some clock which is not >>> coming to this device? >> >> device, I suppose you mean clock control module(CCM). >> >> There is no 'clocks = <&ccm CLK_IMX8M_VIDEO_PLL>' under ccm node. >> Because in current design, ccm is taken as producer of >> CLK_IMX8M_VIDEO_PLL, not consumer. > > I don't understand now even more. Or I understand even less now. Why > binding references its own clocks via phandle? This makes no sense at > all, except of course assigned clocks, but that's because we have one > property for multiple cases. And BTW if that was the point then the example is confusing because the &clk phandle is not the device node in the example but it should. Neither description says which device's clocks are these. This is expressed very poorly in the binding, look: "Phandles of the PLL" - it clearly suggests some other clocks, not its own, that's so obvious I did not even think of asking. Patchset goes slow also because of poor explanation, lack of diagrams and expecting me to remember your clock hierarchy. Best regards, Krzysztof
> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: support > spread spectrum clocking > > On 09/11/2024 11:05, Krzysztof Kozlowski wrote: > > On 09/11/2024 01:37, Peng Fan wrote: > >>> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: > support > >>> spread spectrum clocking > >>> > >>> On 08/11/2024 13:50, Peng Fan wrote: > >>>>> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: > >>> support > >>>>> spread spectrum clocking > >>>>> > >>>>> On 07/11/2024 15:57, Dario Binacchi wrote: > >>>>>> clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, > <&clk_ext2>, > >>>>>> <&clk_ext3>, <&clk_ext4>; > >>>>>> clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", > >>>>>> "clk_ext3", "clk_ext4"; > >>>>>> assigned-clocks = <&clk IMX8MN_CLK_A53_SRC>, > >>>>>> <&clk IMX8MN_CLK_A53_CORE>, > >>>>>> <&clk IMX8MN_CLK_NOC>, > >>>>>> <&clk IMX8MN_CLK_AUDIO_AHB>, > >>>>>> <&clk IMX8MN_CLK_IPG_AUDIO_ROOT>, > >>>>>> <&clk IMX8MN_SYS_PLL3>, > >>>>>> <&clk IMX8MN_AUDIO_PLL1>, > >>>>>> <&clk IMX8MN_AUDIO_PLL2>; > >>>>>> assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_800M>, > >>>>>> <&clk IMX8MN_ARM_PLL_OUT>, > >>>>>> <&clk IMX8MN_SYS_PLL3_OUT>, > >>>>>> <&clk IMX8MN_SYS_PLL1_800M>; > >>>>>> assigned-clock-rates = <0>, <0>, <0>, > >>>>>> <400000000>, > >>>>>> <400000000>, > >>>>>> <600000000>, > >>>>>> <393216000>, > >>>>>> <361267200>; }; > >>>>>> > >>>>>> The spread spectrum is not configurable on these clocks or, > more > >>>>>> generally, may not be configurable (only 4 PLLs have this > >>> capability). > >>>>>> Therefore, I need the "fsl,ssc-clocks" > >>>>> > >>>>> No. That's not true. You do not need it. > >>>>> > >>>> > >>>> i.MX8M clock hardware is similar as: > >>>> > >>>> OSC->ANATOP->CCM > >>>> > >>>> ANATOP will produce PLLs. > >>>> CCM use PLLs as input source. > >>>> > >>>> Currently there is no dedicated ANATOP driver in linux. > >>>> The CCM linux driver will parse the ANATOP node and register > clk_hw > >>>> for the PLLs. > >>> > >>> I do not know what is CCM and how does it fit here. What's more, I > >>> don't get driver context here. We talk about bindings. > >> > >> > >> CCM: Clock Control Module, it accepts PLL from anatop as inputs, > and > >> outputs clocks to various modules, I2C, CAN, NET, SAI and ... > >> > >>> > >>> > >>>> > >>>> > >>>>> First, the clock inputs for this device are listed in clocks *only*. > >>>>> What is no there, is not an input to the device. Including also > >>>>> Linux aspect (missing devlinks etc). Therefore how can you > >>>>> configure > >>> spread > >>>>> spectrum on clocks which are not connected to this device? > >>>> > >>>> I not understand this well, you mean add clocks = <xx > >>>> CLK_IMX8MM_VIDEO_PLL> in the ccm dtb node? > >>> > >>> Yes. Let me re-iterate and please respond to this exactly comment > >>> instead of ignoring it. > >>> > >>> How a device can care about spread spectrum of a clock which is > not > >>> supplied to this device? > >> > >> I hope we are on same page of what spread spectrum means. > >> spread spectrum of a clock is the clock could produce freq in a > >> range, saying [500MHz - 100KHz, 500MHz + 100KHz]. software only > need > >> to configure the middle frequency and choose the up/down border > >> range(100KHz here) and enable spread spectrum. > >> > >> device: I suppose you mean the Clock Control Module(CCM) here. > > > > I mean the device we discuss here, in this binding. Whatever this > > device is. CCM or CCX > > > >> CCM does not care, it just accepts the PLL as input, and output > > > > Takes PLL as input but you refuse to add it as clocks? Are you really > > responding to my question? > > > > I asked how can you set spread spectrum on clock which you do not > > receive. Why you do not receive? Because you refuse to add it to > > clocks even though I speak about this since months. > > > >> divided clock to various IPs(Video here). The video IPs care about > >> the spread spectrum of the clock. > > > > So which device do we talk about? I am not a NXP clock developer > and I > > care zero about NXP, so keep it simple. We discuss this one specific > > binding for specific device which is called "imx8m-clock" - see > > subject prefix. > > > >> > >> The clock hardware path is as below: > >> > >> OSC(24M) --> Anatop(produce PLL with spread spectrum) -> Clock > >> Control Module(output clock to modules) -> Video IP > >> > >> From hardware perspective, Clock Control Module does not care > spread > >> spectrum. Video IP cares spread spectrum. > >> > >> > >>> > >>> Why would you care about spread spectrum of some clock which is > not > >>> coming to this device? > >> > >> device, I suppose you mean clock control module(CCM). > >> > >> There is no 'clocks = <&ccm CLK_IMX8M_VIDEO_PLL>' under ccm > node. > >> Because in current design, ccm is taken as producer of > >> CLK_IMX8M_VIDEO_PLL, not consumer. > > > > I don't understand now even more. Or I understand even less now. > Why > > binding references its own clocks via phandle? This makes no sense > at > > all, except of course assigned clocks, but that's because we have one > > property for multiple cases. > > And BTW if that was the point then the example is confusing because > the &clk phandle is not the device node in the example but it should. > Neither description says which device's clocks are these. > > This is expressed very poorly in the binding, look: > "Phandles of the PLL" - it clearly suggests some other clocks, not its > own, that's so obvious I did not even think of asking. Patchset goes > slow also because of poor explanation, lack of diagrams and expecting > me to remember your clock hierarchy. Dario may improve the patchset in new version. But let me just try to explain a bit more about the hardware logic, I hope this could give you some knowledge on i.MX clock and we could get some suggestions on next: OSC will generate 24MHz clock to Anatop module. Anatop module takes 24MHz as input and produces various PLLs. Clock Control Module(CCM) takes PLLs as input, and outputs the final clocks to various IPs, saying video IPs. The Anatop module could produce PLLs with spread spectrum enabled. The Clock Control module just divides the freq and output the end IPs. The end IPs cares about spread spectrum for high quality clock, the Clock Control modules does not care. Now back to binding, There is a imx8m-anatop binding fsl,imx8m-anatop.yaml for anatop and a imx8m-clock.yaml binding for clock control module. I think the patchset is to enable spread spectrum of a PLL globally, not for a specific device saying video IP here. So the patchset put the properties under the clock control module. For example, there are VPU_JPEG, VPU_DECODE, both will use video PLL with high quality. So the clock producer just produce PLLs with Spread Spectrum(SS) enabled, and put the SS properties under CCM or anatop node, not video IP nodes. We could have a talk on IRC if Dario, Abel and you are available to discuss on this topic. Thanks, Peng. > > Best regards, > Krzysztof
On Mon, Nov 11, 2024 at 2:49 AM Peng Fan <peng.fan@nxp.com> wrote: > > > Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: support > > spread spectrum clocking > > > > On 09/11/2024 11:05, Krzysztof Kozlowski wrote: > > > On 09/11/2024 01:37, Peng Fan wrote: > > >>> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: > > support > > >>> spread spectrum clocking > > >>> > > >>> On 08/11/2024 13:50, Peng Fan wrote: > > >>>>> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: > > >>> support > > >>>>> spread spectrum clocking > > >>>>> > > >>>>> On 07/11/2024 15:57, Dario Binacchi wrote: > > >>>>>> clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, > > <&clk_ext2>, > > >>>>>> <&clk_ext3>, <&clk_ext4>; > > >>>>>> clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", > > >>>>>> "clk_ext3", "clk_ext4"; > > >>>>>> assigned-clocks = <&clk IMX8MN_CLK_A53_SRC>, > > >>>>>> <&clk IMX8MN_CLK_A53_CORE>, > > >>>>>> <&clk IMX8MN_CLK_NOC>, > > >>>>>> <&clk IMX8MN_CLK_AUDIO_AHB>, > > >>>>>> <&clk IMX8MN_CLK_IPG_AUDIO_ROOT>, > > >>>>>> <&clk IMX8MN_SYS_PLL3>, > > >>>>>> <&clk IMX8MN_AUDIO_PLL1>, > > >>>>>> <&clk IMX8MN_AUDIO_PLL2>; > > >>>>>> assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_800M>, > > >>>>>> <&clk IMX8MN_ARM_PLL_OUT>, > > >>>>>> <&clk IMX8MN_SYS_PLL3_OUT>, > > >>>>>> <&clk IMX8MN_SYS_PLL1_800M>; > > >>>>>> assigned-clock-rates = <0>, <0>, <0>, > > >>>>>> <400000000>, > > >>>>>> <400000000>, > > >>>>>> <600000000>, > > >>>>>> <393216000>, > > >>>>>> <361267200>; }; > > >>>>>> > > >>>>>> The spread spectrum is not configurable on these clocks or, > > more > > >>>>>> generally, may not be configurable (only 4 PLLs have this > > >>> capability). > > >>>>>> Therefore, I need the "fsl,ssc-clocks" > > >>>>> > > >>>>> No. That's not true. You do not need it. > > >>>>> > > >>>> > > >>>> i.MX8M clock hardware is similar as: > > >>>> > > >>>> OSC->ANATOP->CCM > > >>>> > > >>>> ANATOP will produce PLLs. > > >>>> CCM use PLLs as input source. > > >>>> > > >>>> Currently there is no dedicated ANATOP driver in linux. > > >>>> The CCM linux driver will parse the ANATOP node and register > > clk_hw > > >>>> for the PLLs. > > >>> > > >>> I do not know what is CCM and how does it fit here. What's more, I > > >>> don't get driver context here. We talk about bindings. > > >> > > >> > > >> CCM: Clock Control Module, it accepts PLL from anatop as inputs, > > and > > >> outputs clocks to various modules, I2C, CAN, NET, SAI and ... > > >> > > >>> > > >>> > > >>>> > > >>>> > > >>>>> First, the clock inputs for this device are listed in clocks *only*. > > >>>>> What is no there, is not an input to the device. Including also > > >>>>> Linux aspect (missing devlinks etc). Therefore how can you > > >>>>> configure > > >>> spread > > >>>>> spectrum on clocks which are not connected to this device? > > >>>> > > >>>> I not understand this well, you mean add clocks = <xx > > >>>> CLK_IMX8MM_VIDEO_PLL> in the ccm dtb node? > > >>> > > >>> Yes. Let me re-iterate and please respond to this exactly comment > > >>> instead of ignoring it. > > >>> > > >>> How a device can care about spread spectrum of a clock which is > > not > > >>> supplied to this device? > > >> > > >> I hope we are on same page of what spread spectrum means. > > >> spread spectrum of a clock is the clock could produce freq in a > > >> range, saying [500MHz - 100KHz, 500MHz + 100KHz]. software only > > need > > >> to configure the middle frequency and choose the up/down border > > >> range(100KHz here) and enable spread spectrum. > > >> > > >> device: I suppose you mean the Clock Control Module(CCM) here. > > > > > > I mean the device we discuss here, in this binding. Whatever this > > > device is. CCM or CCX > > > > > >> CCM does not care, it just accepts the PLL as input, and output > > > > > > Takes PLL as input but you refuse to add it as clocks? Are you really > > > responding to my question? > > > > > > I asked how can you set spread spectrum on clock which you do not > > > receive. Why you do not receive? Because you refuse to add it to > > > clocks even though I speak about this since months. > > > > > >> divided clock to various IPs(Video here). The video IPs care about > > >> the spread spectrum of the clock. > > > > > > So which device do we talk about? I am not a NXP clock developer > > and I > > > care zero about NXP, so keep it simple. We discuss this one specific > > > binding for specific device which is called "imx8m-clock" - see > > > subject prefix. > > > > > >> > > >> The clock hardware path is as below: > > >> > > >> OSC(24M) --> Anatop(produce PLL with spread spectrum) -> Clock > > >> Control Module(output clock to modules) -> Video IP > > >> > > >> From hardware perspective, Clock Control Module does not care > > spread > > >> spectrum. Video IP cares spread spectrum. > > >> > > >> > > >>> > > >>> Why would you care about spread spectrum of some clock which is > > not > > >>> coming to this device? > > >> > > >> device, I suppose you mean clock control module(CCM). > > >> > > >> There is no 'clocks = <&ccm CLK_IMX8M_VIDEO_PLL>' under ccm > > node. > > >> Because in current design, ccm is taken as producer of > > >> CLK_IMX8M_VIDEO_PLL, not consumer. > > > > > > I don't understand now even more. Or I understand even less now. > > Why > > > binding references its own clocks via phandle? This makes no sense > > at > > > all, except of course assigned clocks, but that's because we have one > > > property for multiple cases. > > > > And BTW if that was the point then the example is confusing because > > the &clk phandle is not the device node in the example but it should. > > Neither description says which device's clocks are these. > > > > This is expressed very poorly in the binding, look: > > "Phandles of the PLL" - it clearly suggests some other clocks, not its > > own, that's so obvious I did not even think of asking. Patchset goes > > slow also because of poor explanation, lack of diagrams and expecting > > me to remember your clock hierarchy. > > > Dario may improve the patchset in new version. But let me just try > to explain a bit more about the hardware logic, I hope this could > give you some knowledge on i.MX clock and we could get some > suggestions on next: > > > OSC will generate 24MHz clock to Anatop module. > Anatop module takes 24MHz as input and produces various PLLs. > Clock Control Module(CCM) takes PLLs as input, and outputs the final > clocks to various IPs, saying video IPs. > > The Anatop module could produce PLLs with spread spectrum enabled. > The Clock Control module just divides the freq and output the end IPs. > The end IPs cares about spread spectrum for high quality clock, the > Clock Control modules does not care. Now back to binding, > > There is a imx8m-anatop binding fsl,imx8m-anatop.yaml for anatop > and a imx8m-clock.yaml binding for clock control module. > > I think the patchset is to enable spread spectrum of a PLL globally, > not for a specific device saying video IP here. So the patchset put > the properties under the clock control module. > > For example, there are VPU_JPEG, VPU_DECODE, both will use > video PLL with high quality. So the clock producer just produce > PLLs with Spread Spectrum(SS) enabled, and put the SS properties > under CCM or anatop node, not video IP nodes. Thank you Peng, for the information. Do you think it would make sense to add the PLL nodes with SSCG to the anatop node? anatop: clock-controller@30360000 { compatible = "fsl,imx8mn-anatop", "fsl,imx8mm-anatop"; reg = <0x30360000 0x10000>; #clock-cells = <1>; clk_video_pll1_ref_sel: clock-video-pll1-ref-sel@28 { compatible = "fsl,imx8mn-mux-clock"; #clock-cells = <0>; clocks = <&osc_24m>, <&clk_dummy>, <&clk_dummy>, <&clk_dummy>; fsl,anatop = <&anatop 0x28>; fsl,bit-shift = <0>; clock-output-names = "video_pll1_ref_sel"; }; clk_video_pll1: clock-video-pll1@28 { compatible = "fsl,pll14xx-clock"; #clock-cells = <0>; clocks = <&clk_video_pll1_ref_sel>; ... fsl,ssc-modfreq-hz = <6000>; fsl,ssc-modrate-percent = <3>; fsl,ssc-modmethod = "down-spread"; }; }; This example only considers the video PLL, so to be complete, it should also add the clk_audio_pll1, clk_audio_pll2 and clk_dram_pll nodes. It is based on an RFC series that I sent about a year ago, which was not accepted. In this way, the SSCG properties (i.e., "fsl,ssc-modfreq-hz", "fsl,ssc-modrate-percent" and "fsl,ssc-modmethod") would be added to the relevant nodes, and I would take only the essential parts from that series. This would still mean implementing the PLL driver ("fsl,pll14xx-clock") and its mux ("fsl,imx8mn-mux-clock"). These clocks can then be added to the "clocks" list of the "ccm" node: clk: clock-controller@30380000 { compatible = "fsl,imx8mn-ccm"; ... clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, <&clk_ext3>, <&clk_ext4>, <&clk_video_pll1>, <&clk_audio_pll1>, <&clk_audio_pll2>, <&clk_dram_pll>; ... } > > > We could have a talk on IRC if Dario, Abel and you are available to > discuss on this topic. Yes, I am available. Thanks and regards, Dario > > Thanks, > Peng. > > > > > Best regards, > > Krzysztof >
On Mon, Nov 11, 2024 at 12:57 PM Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: > > On Mon, Nov 11, 2024 at 2:49 AM Peng Fan <peng.fan@nxp.com> wrote: > > > > > Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: support > > > spread spectrum clocking > > > > > > On 09/11/2024 11:05, Krzysztof Kozlowski wrote: > > > > On 09/11/2024 01:37, Peng Fan wrote: > > > >>> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: > > > support > > > >>> spread spectrum clocking > > > >>> > > > >>> On 08/11/2024 13:50, Peng Fan wrote: > > > >>>>> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: > > > >>> support > > > >>>>> spread spectrum clocking > > > >>>>> > > > >>>>> On 07/11/2024 15:57, Dario Binacchi wrote: > > > >>>>>> clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, > > > <&clk_ext2>, > > > >>>>>> <&clk_ext3>, <&clk_ext4>; > > > >>>>>> clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", > > > >>>>>> "clk_ext3", "clk_ext4"; > > > >>>>>> assigned-clocks = <&clk IMX8MN_CLK_A53_SRC>, > > > >>>>>> <&clk IMX8MN_CLK_A53_CORE>, > > > >>>>>> <&clk IMX8MN_CLK_NOC>, > > > >>>>>> <&clk IMX8MN_CLK_AUDIO_AHB>, > > > >>>>>> <&clk IMX8MN_CLK_IPG_AUDIO_ROOT>, > > > >>>>>> <&clk IMX8MN_SYS_PLL3>, > > > >>>>>> <&clk IMX8MN_AUDIO_PLL1>, > > > >>>>>> <&clk IMX8MN_AUDIO_PLL2>; > > > >>>>>> assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_800M>, > > > >>>>>> <&clk IMX8MN_ARM_PLL_OUT>, > > > >>>>>> <&clk IMX8MN_SYS_PLL3_OUT>, > > > >>>>>> <&clk IMX8MN_SYS_PLL1_800M>; > > > >>>>>> assigned-clock-rates = <0>, <0>, <0>, > > > >>>>>> <400000000>, > > > >>>>>> <400000000>, > > > >>>>>> <600000000>, > > > >>>>>> <393216000>, > > > >>>>>> <361267200>; }; > > > >>>>>> > > > >>>>>> The spread spectrum is not configurable on these clocks or, > > > more > > > >>>>>> generally, may not be configurable (only 4 PLLs have this > > > >>> capability). > > > >>>>>> Therefore, I need the "fsl,ssc-clocks" > > > >>>>> > > > >>>>> No. That's not true. You do not need it. > > > >>>>> > > > >>>> > > > >>>> i.MX8M clock hardware is similar as: > > > >>>> > > > >>>> OSC->ANATOP->CCM > > > >>>> > > > >>>> ANATOP will produce PLLs. > > > >>>> CCM use PLLs as input source. > > > >>>> > > > >>>> Currently there is no dedicated ANATOP driver in linux. > > > >>>> The CCM linux driver will parse the ANATOP node and register > > > clk_hw > > > >>>> for the PLLs. > > > >>> > > > >>> I do not know what is CCM and how does it fit here. What's more, I > > > >>> don't get driver context here. We talk about bindings. > > > >> > > > >> > > > >> CCM: Clock Control Module, it accepts PLL from anatop as inputs, > > > and > > > >> outputs clocks to various modules, I2C, CAN, NET, SAI and ... > > > >> > > > >>> > > > >>> > > > >>>> > > > >>>> > > > >>>>> First, the clock inputs for this device are listed in clocks *only*. > > > >>>>> What is no there, is not an input to the device. Including also > > > >>>>> Linux aspect (missing devlinks etc). Therefore how can you > > > >>>>> configure > > > >>> spread > > > >>>>> spectrum on clocks which are not connected to this device? > > > >>>> > > > >>>> I not understand this well, you mean add clocks = <xx > > > >>>> CLK_IMX8MM_VIDEO_PLL> in the ccm dtb node? > > > >>> > > > >>> Yes. Let me re-iterate and please respond to this exactly comment > > > >>> instead of ignoring it. > > > >>> > > > >>> How a device can care about spread spectrum of a clock which is > > > not > > > >>> supplied to this device? > > > >> > > > >> I hope we are on same page of what spread spectrum means. > > > >> spread spectrum of a clock is the clock could produce freq in a > > > >> range, saying [500MHz - 100KHz, 500MHz + 100KHz]. software only > > > need > > > >> to configure the middle frequency and choose the up/down border > > > >> range(100KHz here) and enable spread spectrum. > > > >> > > > >> device: I suppose you mean the Clock Control Module(CCM) here. > > > > > > > > I mean the device we discuss here, in this binding. Whatever this > > > > device is. CCM or CCX > > > > > > > >> CCM does not care, it just accepts the PLL as input, and output > > > > > > > > Takes PLL as input but you refuse to add it as clocks? Are you really > > > > responding to my question? > > > > > > > > I asked how can you set spread spectrum on clock which you do not > > > > receive. Why you do not receive? Because you refuse to add it to > > > > clocks even though I speak about this since months. > > > > > > > >> divided clock to various IPs(Video here). The video IPs care about > > > >> the spread spectrum of the clock. > > > > > > > > So which device do we talk about? I am not a NXP clock developer > > > and I > > > > care zero about NXP, so keep it simple. We discuss this one specific > > > > binding for specific device which is called "imx8m-clock" - see > > > > subject prefix. > > > > > > > >> > > > >> The clock hardware path is as below: > > > >> > > > >> OSC(24M) --> Anatop(produce PLL with spread spectrum) -> Clock > > > >> Control Module(output clock to modules) -> Video IP > > > >> > > > >> From hardware perspective, Clock Control Module does not care > > > spread > > > >> spectrum. Video IP cares spread spectrum. > > > >> > > > >> > > > >>> > > > >>> Why would you care about spread spectrum of some clock which is > > > not > > > >>> coming to this device? > > > >> > > > >> device, I suppose you mean clock control module(CCM). > > > >> > > > >> There is no 'clocks = <&ccm CLK_IMX8M_VIDEO_PLL>' under ccm > > > node. > > > >> Because in current design, ccm is taken as producer of > > > >> CLK_IMX8M_VIDEO_PLL, not consumer. > > > > > > > > I don't understand now even more. Or I understand even less now. > > > Why > > > > binding references its own clocks via phandle? This makes no sense > > > at > > > > all, except of course assigned clocks, but that's because we have one > > > > property for multiple cases. > > > > > > And BTW if that was the point then the example is confusing because > > > the &clk phandle is not the device node in the example but it should. > > > Neither description says which device's clocks are these. > > > > > > This is expressed very poorly in the binding, look: > > > "Phandles of the PLL" - it clearly suggests some other clocks, not its > > > own, that's so obvious I did not even think of asking. Patchset goes > > > slow also because of poor explanation, lack of diagrams and expecting > > > me to remember your clock hierarchy. > > > > > > Dario may improve the patchset in new version. But let me just try > > to explain a bit more about the hardware logic, I hope this could > > give you some knowledge on i.MX clock and we could get some > > suggestions on next: > > > > > > OSC will generate 24MHz clock to Anatop module. > > Anatop module takes 24MHz as input and produces various PLLs. > > Clock Control Module(CCM) takes PLLs as input, and outputs the final > > clocks to various IPs, saying video IPs. > > > > The Anatop module could produce PLLs with spread spectrum enabled. > > The Clock Control module just divides the freq and output the end IPs. > > The end IPs cares about spread spectrum for high quality clock, the > > Clock Control modules does not care. Now back to binding, > > > > There is a imx8m-anatop binding fsl,imx8m-anatop.yaml for anatop > > and a imx8m-clock.yaml binding for clock control module. > > > > I think the patchset is to enable spread spectrum of a PLL globally, > > not for a specific device saying video IP here. So the patchset put > > the properties under the clock control module. > > > > For example, there are VPU_JPEG, VPU_DECODE, both will use > > video PLL with high quality. So the clock producer just produce > > PLLs with Spread Spectrum(SS) enabled, and put the SS properties > > under CCM or anatop node, not video IP nodes. > > Thank you Peng, for the information. > > Do you think it would make sense to add the PLL nodes with SSCG to the > anatop node? > > anatop: clock-controller@30360000 { > compatible = "fsl,imx8mn-anatop", "fsl,imx8mm-anatop"; > reg = <0x30360000 0x10000>; > #clock-cells = <1>; > > clk_video_pll1_ref_sel: clock-video-pll1-ref-sel@28 { > compatible = "fsl,imx8mn-mux-clock"; > #clock-cells = <0>; > clocks = <&osc_24m>, <&clk_dummy>, <&clk_dummy>, <&clk_dummy>; > fsl,anatop = <&anatop 0x28>; > fsl,bit-shift = <0>; > clock-output-names = "video_pll1_ref_sel"; > }; > > clk_video_pll1: clock-video-pll1@28 { > compatible = "fsl,pll14xx-clock"; > #clock-cells = <0>; > clocks = <&clk_video_pll1_ref_sel>; > ... > fsl,ssc-modfreq-hz = <6000>; > fsl,ssc-modrate-percent = <3>; > fsl,ssc-modmethod = "down-spread"; > }; > }; > > This example only considers the video PLL, so to be complete, it > should also add the clk_audio_pll1, > clk_audio_pll2 and clk_dram_pll nodes. It is based on an RFC series > that I sent about a year ago, > which was not accepted. In this way, the SSCG properties (i.e., > "fsl,ssc-modfreq-hz", "fsl,ssc-modrate-percent" > and "fsl,ssc-modmethod") would be added to the relevant nodes, and I > would take only the essential parts > from that series. This would still mean implementing the PLL driver > ("fsl,pll14xx-clock") and its mux ("fsl,imx8mn-mux-clock"). > > These clocks can then be added to the "clocks" list of the "ccm" node: > > clk: clock-controller@30380000 { > compatible = "fsl,imx8mn-ccm"; > ... > clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, > <&clk_ext3>, <&clk_ext4>, <&clk_video_pll1>, > <&clk_audio_pll1>, <&clk_audio_pll2>, <&clk_dram_pll>; > ... > } > > > > > Next the series I forgot to reference in the previous email: https://lore.kernel.org/lkml/20230101175740.1010258-1-dario.binacchi@amarulasolutions.com/ Thanks and regards, Dario > > We could have a talk on IRC if Dario, Abel and you are available to > > discuss on this topic. > > Yes, I am available. > > Thanks and regards, > Dario > > > > > Thanks, > > Peng. > > > > > > > > Best regards, > > > Krzysztof > > > > > -- > > Dario Binacchi > > Senior Embedded Linux Developer > > dario.binacchi@amarulasolutions.com > > __________________________________ > > > Amarula Solutions SRL > > Via Le Canevare 30, 31100 Treviso, Veneto, IT > > T. +39 042 243 5310 > info@amarulasolutions.com > > www.amarulasolutions.com
> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: support > spread spectrum clocking > > On Mon, Nov 11, 2024 at 12:57 PM Dario Binacchi > <dario.binacchi@amarulasolutions.com> wrote: > > > > On Mon, Nov 11, 2024 at 2:49 AM Peng Fan <peng.fan@nxp.com> > wrote: > > > > > > > Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: > > > > support spread spectrum clocking > > > > > > > > On 09/11/2024 11:05, Krzysztof Kozlowski wrote: > > > > > On 09/11/2024 01:37, Peng Fan wrote: > > > > >>> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: > > > > support > > > > >>> spread spectrum clocking > > > > >>> > > > > >>> On 08/11/2024 13:50, Peng Fan wrote: > > > > >>>>> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m- > clock: > > > > >>> support > > > > >>>>> spread spectrum clocking > > > > >>>>> > > > > >>>>> On 07/11/2024 15:57, Dario Binacchi wrote: > > > > >>>>>> clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, > > > > <&clk_ext2>, > > > > >>>>>> <&clk_ext3>, <&clk_ext4>; > > > > >>>>>> clock-names = "osc_32k", "osc_24m", "clk_ext1", > "clk_ext2", > > > > >>>>>> "clk_ext3", "clk_ext4"; > > > > >>>>>> assigned-clocks = <&clk IMX8MN_CLK_A53_SRC>, > > > > >>>>>> <&clk IMX8MN_CLK_A53_CORE>, > > > > >>>>>> <&clk IMX8MN_CLK_NOC>, > > > > >>>>>> <&clk IMX8MN_CLK_AUDIO_AHB>, > > > > >>>>>> <&clk > IMX8MN_CLK_IPG_AUDIO_ROOT>, > > > > >>>>>> <&clk IMX8MN_SYS_PLL3>, > > > > >>>>>> <&clk IMX8MN_AUDIO_PLL1>, > > > > >>>>>> <&clk IMX8MN_AUDIO_PLL2>; > > > > >>>>>> assigned-clock-parents = <&clk > IMX8MN_SYS_PLL1_800M>, > > > > >>>>>> <&clk > IMX8MN_ARM_PLL_OUT>, > > > > >>>>>> <&clk > IMX8MN_SYS_PLL3_OUT>, > > > > >>>>>> <&clk > IMX8MN_SYS_PLL1_800M>; > > > > >>>>>> assigned-clock-rates = <0>, <0>, <0>, > > > > >>>>>> <400000000>, > > > > >>>>>> <400000000>, > > > > >>>>>> <600000000>, > > > > >>>>>> <393216000>, > > > > >>>>>> <361267200>; }; > > > > >>>>>> > > > > >>>>>> The spread spectrum is not configurable on these clocks or, > > > > more > > > > >>>>>> generally, may not be configurable (only 4 PLLs have this > > > > >>> capability). > > > > >>>>>> Therefore, I need the "fsl,ssc-clocks" > > > > >>>>> > > > > >>>>> No. That's not true. You do not need it. > > > > >>>>> > > > > >>>> > > > > >>>> i.MX8M clock hardware is similar as: > > > > >>>> > > > > >>>> OSC->ANATOP->CCM > > > > >>>> > > > > >>>> ANATOP will produce PLLs. > > > > >>>> CCM use PLLs as input source. > > > > >>>> > > > > >>>> Currently there is no dedicated ANATOP driver in linux. > > > > >>>> The CCM linux driver will parse the ANATOP node and > register > > > > clk_hw > > > > >>>> for the PLLs. > > > > >>> > > > > >>> I do not know what is CCM and how does it fit here. What's > > > > >>> more, I don't get driver context here. We talk about bindings. > > > > >> > > > > >> > > > > >> CCM: Clock Control Module, it accepts PLL from anatop as > > > > >> inputs, > > > > and > > > > >> outputs clocks to various modules, I2C, CAN, NET, SAI and ... > > > > >> > > > > >>> > > > > >>> > > > > >>>> > > > > >>>> > > > > >>>>> First, the clock inputs for this device are listed in clocks > *only*. > > > > >>>>> What is no there, is not an input to the device. Including > > > > >>>>> also Linux aspect (missing devlinks etc). Therefore how can > > > > >>>>> you configure > > > > >>> spread > > > > >>>>> spectrum on clocks which are not connected to this device? > > > > >>>> > > > > >>>> I not understand this well, you mean add clocks = <xx > > > > >>>> CLK_IMX8MM_VIDEO_PLL> in the ccm dtb node? > > > > >>> > > > > >>> Yes. Let me re-iterate and please respond to this exactly > > > > >>> comment instead of ignoring it. > > > > >>> > > > > >>> How a device can care about spread spectrum of a clock > which > > > > >>> is > > > > not > > > > >>> supplied to this device? > > > > >> > > > > >> I hope we are on same page of what spread spectrum means. > > > > >> spread spectrum of a clock is the clock could produce freq in a > > > > >> range, saying [500MHz - 100KHz, 500MHz + 100KHz]. software > only > > > > need > > > > >> to configure the middle frequency and choose the up/down > border > > > > >> range(100KHz here) and enable spread spectrum. > > > > >> > > > > >> device: I suppose you mean the Clock Control Module(CCM) > here. > > > > > > > > > > I mean the device we discuss here, in this binding. Whatever > > > > > this device is. CCM or CCX > > > > > > > > > >> CCM does not care, it just accepts the PLL as input, and output > > > > > > > > > > Takes PLL as input but you refuse to add it as clocks? Are you > > > > > really responding to my question? > > > > > > > > > > I asked how can you set spread spectrum on clock which you do > > > > > not receive. Why you do not receive? Because you refuse to add > > > > > it to clocks even though I speak about this since months. > > > > > > > > > >> divided clock to various IPs(Video here). The video IPs care > > > > >> about the spread spectrum of the clock. > > > > > > > > > > So which device do we talk about? I am not a NXP clock > developer > > > > and I > > > > > care zero about NXP, so keep it simple. We discuss this one > > > > > specific binding for specific device which is called > > > > > "imx8m-clock" - see subject prefix. > > > > > > > > > >> > > > > >> The clock hardware path is as below: > > > > >> > > > > >> OSC(24M) --> Anatop(produce PLL with spread spectrum) -> > Clock > > > > >> Control Module(output clock to modules) -> Video IP > > > > >> > > > > >> From hardware perspective, Clock Control Module does not > care > > > > spread > > > > >> spectrum. Video IP cares spread spectrum. > > > > >> > > > > >> > > > > >>> > > > > >>> Why would you care about spread spectrum of some clock > which > > > > >>> is > > > > not > > > > >>> coming to this device? > > > > >> > > > > >> device, I suppose you mean clock control module(CCM). > > > > >> > > > > >> There is no 'clocks = <&ccm CLK_IMX8M_VIDEO_PLL>' under > ccm > > > > node. > > > > >> Because in current design, ccm is taken as producer of > > > > >> CLK_IMX8M_VIDEO_PLL, not consumer. > > > > > > > > > > I don't understand now even more. Or I understand even less > now. > > > > Why > > > > > binding references its own clocks via phandle? This makes no > > > > > sense > > > > at > > > > > all, except of course assigned clocks, but that's because we > > > > > have one property for multiple cases. > > > > > > > > And BTW if that was the point then the example is confusing > > > > because the &clk phandle is not the device node in the example > but it should. > > > > Neither description says which device's clocks are these. > > > > > > > > This is expressed very poorly in the binding, look: > > > > "Phandles of the PLL" - it clearly suggests some other clocks, not > > > > its own, that's so obvious I did not even think of asking. > > > > Patchset goes slow also because of poor explanation, lack of > > > > diagrams and expecting me to remember your clock hierarchy. > > > > > > > > > Dario may improve the patchset in new version. But let me just try > > > to explain a bit more about the hardware logic, I hope this could > > > give you some knowledge on i.MX clock and we could get some > > > suggestions on next: > > > > > > > > > OSC will generate 24MHz clock to Anatop module. > > > Anatop module takes 24MHz as input and produces various PLLs. > > > Clock Control Module(CCM) takes PLLs as input, and outputs the > final > > > clocks to various IPs, saying video IPs. > > > > > > The Anatop module could produce PLLs with spread spectrum > enabled. > > > The Clock Control module just divides the freq and output the end > IPs. > > > The end IPs cares about spread spectrum for high quality clock, the > > > Clock Control modules does not care. Now back to binding, > > > > > > There is a imx8m-anatop binding fsl,imx8m-anatop.yaml for anatop > and > > > a imx8m-clock.yaml binding for clock control module. > > > > > > I think the patchset is to enable spread spectrum of a PLL globally, > > > not for a specific device saying video IP here. So the patchset put > > > the properties under the clock control module. > > > > > > For example, there are VPU_JPEG, VPU_DECODE, both will use > video PLL > > > with high quality. So the clock producer just produce PLLs with > > > Spread Spectrum(SS) enabled, and put the SS properties under CCM > or > > > anatop node, not video IP nodes. > > > > Thank you Peng, for the information. > > > > Do you think it would make sense to add the PLL nodes with SSCG to > the > > anatop node? I not know Krzysztof's view on what he expects on spread spectrum of a clock. I just think we are not on same page, but not know where we misunderstands, or I am wrong. For your below dt, I think clock maintainer would not agree. So my idea is Using clocks to replace fsl,ssc-clocks is possible under ccm mode, but you need to develop the fsl,imx8mm-anatop clock driver. Or just replace fsl,ssc-clocks with clock id under anatop node, no phandle under anatop node. Then let ccm driver to handle it. Regards, Peng. > > > > anatop: clock-controller@30360000 { > > compatible = "fsl,imx8mn-anatop", "fsl,imx8mm-anatop"; > > reg = <0x30360000 0x10000>; > > #clock-cells = <1>; > > > > clk_video_pll1_ref_sel: clock-video-pll1-ref-sel@28 { > > compatible = "fsl,imx8mn-mux-clock"; > > #clock-cells = <0>; > > clocks = <&osc_24m>, <&clk_dummy>, <&clk_dummy>, > <&clk_dummy>; > > fsl,anatop = <&anatop 0x28>; > > fsl,bit-shift = <0>; > > clock-output-names = "video_pll1_ref_sel"; > > }; > > > > clk_video_pll1: clock-video-pll1@28 { > > compatible = "fsl,pll14xx-clock"; > > #clock-cells = <0>; > > clocks = <&clk_video_pll1_ref_sel>; > > ... > > fsl,ssc-modfreq-hz = <6000>; > > fsl,ssc-modrate-percent = <3>; > > fsl,ssc-modmethod = "down-spread"; > > }; > > }; > > > > This example only considers the video PLL, so to be complete, it > > should also add the clk_audio_pll1, > > clk_audio_pll2 and clk_dram_pll nodes. It is based on an RFC series > > that I sent about a year ago, which was not accepted. In this way, the > > SSCG properties (i.e., "fsl,ssc-modfreq-hz", "fsl,ssc-modrate-percent" > > and "fsl,ssc-modmethod") would be added to the relevant nodes, and > I > > would take only the essential parts from that series. This would still > > mean implementing the PLL driver > > ("fsl,pll14xx-clock") and its mux ("fsl,imx8mn-mux-clock"). > > > > These clocks can then be added to the "clocks" list of the "ccm" node: > > > > clk: clock-controller@30380000 { > > compatible = "fsl,imx8mn-ccm"; > > ... > > clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, > > <&clk_ext3>, <&clk_ext4>, <&clk_video_pll1>, > > <&clk_audio_pll1>, <&clk_audio_pll2>, <&clk_dram_pll>; > > ... > > } > > > > > > > > > > Next the series I forgot to reference in the previous email: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F > lore.kernel.org%2Flkml%2F20230101175740.1010258-1- > dario.binacchi%40amarulasolutions.com%2F&data=05%7C02%7Cpeng. > fan%40nxp.com%7C47c26bb6c16549ff778d08dd0257261d%7C686ea > 1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63866929551955069 > 0%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiO > iIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D% > 3D%7C0%7C%7C%7C&sdata=1uWbb%2Fxa4PjemrEpSFbsBQP2X466i2c > jYaxjQKl1xfE%3D&reserved=0 > > Thanks and regards, > Dario > > > > We could have a talk on IRC if Dario, Abel and you are available to > > > discuss on this topic. > > > > Yes, I am available. > > > > Thanks and regards, > > Dario > > > > > > > > Thanks, > > > Peng. > > > > > > > > > > > Best regards, > > > > Krzysztof > > > > > > > > > -- > > > > Dario Binacchi > > > > Senior Embedded Linux Developer > > > > dario.binacchi@amarulasolutions.com > > > > __________________________________ > > > > > > Amarula Solutions SRL > > > > Via Le Canevare 30, 31100 Treviso, Veneto, IT > > > > T. +39 042 243 5310 > > info@amarulasolutions.com > > > > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2F > www.a > > > marulasolutions.com%2F&data=05%7C02%7Cpeng.fan%40nxp.com%7 > C47c26bb6c16 > > > 549ff778d08dd0257261d%7C686ea1d3bc2b4c6fa92cd99c5c301635% > 7C0%7C0%7C638 > > > 669295519581821%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcG > kiOnRydWUsIlYiOi > > > IwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3 > D%7C0%7C% > > > 7C%7C&sdata=tK%2B9QB7Ri3eXJI%2FdXmCbwr%2BDwzdLt51CPo0DB > pd%2BqOw%3D&res > > erved=0 > > > > -- > > Dario Binacchi > > Senior Embedded Linux Developer > > dario.binacchi@amarulasolutions.com > > __________________________________ > > > Amarula Solutions SRL > > Via Le Canevare 30, 31100 Treviso, Veneto, IT > > T. +39 042 243 5310 > info@amarulasolutions.com > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2F > www.amarulasolutions.com%2F&data=05%7C02%7Cpeng.fan%40nxp. > com%7C47c26bb6c16549ff778d08dd0257261d%7C686ea1d3bc2b4c6 > fa92cd99c5c301635%7C0%7C0%7C638669295519598876%7CUnkno > wn%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDA > wMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C > %7C%7C&sdata=ypZC9LExvvra%2BPcQIOE8HHnuRs3fmHjMVvRpox7Vd > AU%3D&reserved=0
On 11/11/2024 12:57, Dario Binacchi wrote: > > Thank you Peng, for the information. > > Do you think it would make sense to add the PLL nodes with SSCG to the > anatop node? > > anatop: clock-controller@30360000 { > compatible = "fsl,imx8mn-anatop", "fsl,imx8mm-anatop"; > reg = <0x30360000 0x10000>; > #clock-cells = <1>; > > clk_video_pll1_ref_sel: clock-video-pll1-ref-sel@28 { > compatible = "fsl,imx8mn-mux-clock"; No. Nodes per clock were long time ago NAKed. > #clock-cells = <0>; > clocks = <&osc_24m>, <&clk_dummy>, <&clk_dummy>, <&clk_dummy>; > fsl,anatop = <&anatop 0x28>; > fsl,bit-shift = <0>; > clock-output-names = "video_pll1_ref_sel"; > }; > > clk_video_pll1: clock-video-pll1@28 { > compatible = "fsl,pll14xx-clock"; > #clock-cells = <0>; > clocks = <&clk_video_pll1_ref_sel>; > ... > fsl,ssc-modfreq-hz = <6000>; > fsl,ssc-modrate-percent = <3>; > fsl,ssc-modmethod = "down-spread"; > }; > }; > > This example only considers the video PLL, so to be complete, it > should also add the clk_audio_pll1, > clk_audio_pll2 and clk_dram_pll nodes. It is based on an RFC series > that I sent about a year ago, > which was not accepted. In this way, the SSCG properties (i.e., > "fsl,ssc-modfreq-hz", "fsl,ssc-modrate-percent" > and "fsl,ssc-modmethod") would be added to the relevant nodes, and I > would take only the essential parts > from that series. This would still mean implementing the PLL driver > ("fsl,pll14xx-clock") and its mux ("fsl,imx8mn-mux-clock"). > > These clocks can then be added to the "clocks" list of the "ccm" node: > > clk: clock-controller@30380000 { > compatible = "fsl,imx8mn-ccm"; > ... > clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, > <&clk_ext3>, <&clk_ext4>, <&clk_video_pll1>, > <&clk_audio_pll1>, <&clk_audio_pll2>, <&clk_dram_pll>; > ... > } > These clocks can be added anyway. Best regards, Krzysztof
On 11/11/2024 02:49, Peng Fan wrote: >>> I don't understand now even more. Or I understand even less now. >> Why >>> binding references its own clocks via phandle? This makes no sense >> at >>> all, except of course assigned clocks, but that's because we have one >>> property for multiple cases. >> >> And BTW if that was the point then the example is confusing because >> the &clk phandle is not the device node in the example but it should. >> Neither description says which device's clocks are these. >> >> This is expressed very poorly in the binding, look: >> "Phandles of the PLL" - it clearly suggests some other clocks, not its >> own, that's so obvious I did not even think of asking. Patchset goes >> slow also because of poor explanation, lack of diagrams and expecting >> me to remember your clock hierarchy. > > > Dario may improve the patchset in new version. But let me just try > to explain a bit more about the hardware logic, I hope this could > give you some knowledge on i.MX clock and we could get some > suggestions on next: > > > OSC will generate 24MHz clock to Anatop module. > Anatop module takes 24MHz as input and produces various PLLs. > Clock Control Module(CCM) takes PLLs as input, and outputs the final > clocks to various IPs, saying video IPs. > > The Anatop module could produce PLLs with spread spectrum enabled. > The Clock Control module just divides the freq and output the end IPs. > The end IPs cares about spread spectrum for high quality clock, the > Clock Control modules does not care. Now back to binding, All above makes sense. The previous message: "Because in current design, ccm is taken as producer of CLK_IMX8M_VIDEO_PLL, not consumer. " confused me a lot because it suggests that these PLLs are provided by CCM. It turns out not... so the answer is like I said long time ago: you must take these clocks as inputs and this is done via clocks property. Not fsl,clocks or fsc,i-want-more-properties-clocks. > > There is a imx8m-anatop binding fsl,imx8m-anatop.yaml for anatop > and a imx8m-clock.yaml binding for clock control module. > > I think the patchset is to enable spread spectrum of a PLL globally, > not for a specific device saying video IP here. So the patchset put > the properties under the clock control module. I understand. This looks however as misrepresentation. If you do not have the video IP block enabled, why would you configure spread spectrum? IOW, spread spectrum as you described is needed for the final IP block and this final IP block should configure it. Properties belong there. It's kind of similar for some OPP/performance/bandwidth requests. Even more similar to clock frequencies. Which device requests to configure given clock frequencies? Final consumer, not clock controller. > > For example, there are VPU_JPEG, VPU_DECODE, both will use > video PLL with high quality. So the clock producer just produce > PLLs with Spread Spectrum(SS) enabled, and put the SS properties > under CCM or anatop node, not video IP nodes. > > > We could have a talk on IRC if Dario, Abel and you are available to > discuss on this topic. Best regards, Krzysztof
> Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: support > spread spectrum clocking > > On 11/11/2024 02:49, Peng Fan wrote: > >>> I don't understand now even more. Or I understand even less now. > >> Why > >>> binding references its own clocks via phandle? This makes no sense > >> at > >>> all, except of course assigned clocks, but that's because we have > >>> one property for multiple cases. > >> > >> And BTW if that was the point then the example is confusing > because > >> the &clk phandle is not the device node in the example but it should. > >> Neither description says which device's clocks are these. > >> > >> This is expressed very poorly in the binding, look: > >> "Phandles of the PLL" - it clearly suggests some other clocks, not > >> its own, that's so obvious I did not even think of asking. Patchset > >> goes slow also because of poor explanation, lack of diagrams and > >> expecting me to remember your clock hierarchy. > > > > > > Dario may improve the patchset in new version. But let me just try to > > explain a bit more about the hardware logic, I hope this could give > > you some knowledge on i.MX clock and we could get some > suggestions on > > next: > > > > > > OSC will generate 24MHz clock to Anatop module. > > Anatop module takes 24MHz as input and produces various PLLs. > > Clock Control Module(CCM) takes PLLs as input, and outputs the final > > clocks to various IPs, saying video IPs. > > > > The Anatop module could produce PLLs with spread spectrum > enabled. > > The Clock Control module just divides the freq and output the end IPs. > > The end IPs cares about spread spectrum for high quality clock, the > > Clock Control modules does not care. Now back to binding, > > All above makes sense. The previous message: > "Because in current design, ccm is taken as producer of > CLK_IMX8M_VIDEO_PLL, not consumer. " > > confused me a lot because it suggests that these PLLs are provided by > CCM. It turns out not... so the answer is like I said long time ago: you > must take these clocks as inputs and this is done via clocks property. > Not fsl,clocks or fsc,i-want-more-properties-clocks. > > > > > There is a imx8m-anatop binding fsl,imx8m-anatop.yaml for anatop > and a > > imx8m-clock.yaml binding for clock control module. > > > > I think the patchset is to enable spread spectrum of a PLL globally, > > not for a specific device saying video IP here. So the patchset put > > the properties under the clock control module. > > I understand. This looks however as misrepresentation. If you do not > have the video IP block enabled, why would you configure spread > spectrum? IOW, spread spectrum as you described is needed for the > final IP block and this final IP block should configure it. Properties > belong there. Multiple IPs use same PLLs as source and share same pll settings, it is better to configure Spread Spectrum(SS) at clock producer side, I think. Dario, Without talking about dt-bindings, another approach to enable SS is to enable SS for Video/Audio PLLs using driver parameters, and the parameter that needs for the PLLs could be passed from module parameter, such as clk_imx8mm.audio_ss_xx=. Then you no need bindings. Regards, Peng. > > It's kind of similar for some OPP/performance/bandwidth requests. > Even more similar to clock frequencies. Which device requests to > configure given clock frequencies? Final consumer, not clock controller. > > > > > > For example, there are VPU_JPEG, VPU_DECODE, both will use video > PLL > > with high quality. So the clock producer just produce PLLs with > Spread > > Spectrum(SS) enabled, and put the SS properties under CCM or > anatop > > node, not video IP nodes. > > > > > > We could have a talk on IRC if Dario, Abel and you are available to > > discuss on this topic. > > > > Best regards, > Krzysztof
On Wed, Nov 20, 2024 at 11:11 AM Peng Fan <peng.fan@nxp.com> wrote: > > > Subject: Re: [PATCH v3 1/8] dt-bindings: clock: imx8m-clock: support > > spread spectrum clocking > > > > On 11/11/2024 02:49, Peng Fan wrote: > > >>> I don't understand now even more. Or I understand even less now. > > >> Why > > >>> binding references its own clocks via phandle? This makes no sense > > >> at > > >>> all, except of course assigned clocks, but that's because we have > > >>> one property for multiple cases. > > >> > > >> And BTW if that was the point then the example is confusing > > because > > >> the &clk phandle is not the device node in the example but it should. > > >> Neither description says which device's clocks are these. > > >> > > >> This is expressed very poorly in the binding, look: > > >> "Phandles of the PLL" - it clearly suggests some other clocks, not > > >> its own, that's so obvious I did not even think of asking. Patchset > > >> goes slow also because of poor explanation, lack of diagrams and > > >> expecting me to remember your clock hierarchy. > > > > > > > > > Dario may improve the patchset in new version. But let me just try to > > > explain a bit more about the hardware logic, I hope this could give > > > you some knowledge on i.MX clock and we could get some > > suggestions on > > > next: > > > > > > > > > OSC will generate 24MHz clock to Anatop module. > > > Anatop module takes 24MHz as input and produces various PLLs. > > > Clock Control Module(CCM) takes PLLs as input, and outputs the final > > > clocks to various IPs, saying video IPs. > > > > > > The Anatop module could produce PLLs with spread spectrum > > enabled. > > > The Clock Control module just divides the freq and output the end IPs. > > > The end IPs cares about spread spectrum for high quality clock, the > > > Clock Control modules does not care. Now back to binding, > > > > All above makes sense. The previous message: > > "Because in current design, ccm is taken as producer of > > CLK_IMX8M_VIDEO_PLL, not consumer. " > > > > confused me a lot because it suggests that these PLLs are provided by > > CCM. It turns out not... so the answer is like I said long time ago: you > > must take these clocks as inputs and this is done via clocks property. > > Not fsl,clocks or fsc,i-want-more-properties-clocks. > > > > > > > > There is a imx8m-anatop binding fsl,imx8m-anatop.yaml for anatop > > and a > > > imx8m-clock.yaml binding for clock control module. > > > > > > I think the patchset is to enable spread spectrum of a PLL globally, > > > not for a specific device saying video IP here. So the patchset put > > > the properties under the clock control module. > > > > I understand. This looks however as misrepresentation. If you do not > > have the video IP block enabled, why would you configure spread > > spectrum? IOW, spread spectrum as you described is needed for the > > final IP block and this final IP block should configure it. Properties > > belong there. > > Multiple IPs use same PLLs as source and share same pll settings, > it is better to configure Spread Spectrum(SS) at clock producer side, > I think. I agree with you, and based on what has been discussed and understood so far, the correct place to add the properties for spread spectrum seems to be the CCM node. So, is it correct to think of a CCM node like this? clk: clock-controller@30380000 { compatible = "fsl,imx8mn-ccm"; reg = <0x30380000 0x10000>; interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>; #clock-cells = <1>; clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>, <&clk_ext3>, <&clk_ext4>, <&anatop IMX8MN_ANATOP_AUDIO_PLL1>, <&anatop IMX8MN_ANATOP_AUDIO_PLL2>, <&anatop IMX8MN_ANATOP_DRAM_PLL>, <&anatop IMX8MN_ANATOP_VIDEO_PLL>, clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", "clk_ext3", "clk_ext4", "pll_audio1", "pll_audio2", "pll_dram", "pll_video"; ... }; And if I want to set the spread spectrum for audio1 and video PLLs, should I apply the following configurations? &clk { fsl,ssc-modfreq-hz = <0>, <0>, <0>, <0>, <0>, <0>, <6800>, <0>, <0>, <8000>; fsl,ssc-modrate-percent = <0>, <0>, <0>, <0>, <0>, <0>, <3>, <0>, <0>, <5>; fsl,ssc-modmethod = "", "", "", "", "", "down-spread", "", "", "center-spread"; }; > > Dario, > > Without talking about dt-bindings, another approach to enable SS > is to enable SS for Video/Audio PLLs using driver parameters, > and the parameter that needs for the PLLs could be passed > from module parameter, such as clk_imx8mm.audio_ss_xx=. > > Then you no need bindings. As far as I know, I think it’s better to proceed with the dt-bindings approach. Thanks and regards, Dario > > Regards, > Peng. > > > > > It's kind of similar for some OPP/performance/bandwidth requests. > > Even more similar to clock frequencies. Which device requests to > > configure given clock frequencies? Final consumer, not clock controller. > > > > > > > > > > For example, there are VPU_JPEG, VPU_DECODE, both will use video > > PLL > > > with high quality. So the clock producer just produce PLLs with > > Spread > > > Spectrum(SS) enabled, and put the SS properties under CCM or > > anatop > > > node, not video IP nodes. > > > > > > > > > We could have a talk on IRC if Dario, Abel and you are available to > > > discuss on this topic. > > > > > > > > Best regards, > > Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml index c643d4a81478..7920393e518e 100644 --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml @@ -43,6 +43,40 @@ properties: ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8m-clock.h for the full list of i.MX8M clock IDs. + fsl,ssc-clocks: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: + Phandles of the PLL with spread spectrum generation hardware capability. + minItems: 1 + maxItems: 4 + + fsl,ssc-modfreq-hz: + description: + The values of modulation frequency (Hz unit) of spread spectrum + clocking for each PLL. + minItems: 1 + maxItems: 4 + + fsl,ssc-modrate-percent: + description: + The percentage values of modulation rate of spread spectrum + clocking for each PLL. + minItems: 1 + maxItems: 4 + + fsl,ssc-modmethod: + $ref: /schemas/types.yaml#/definitions/string-array + description: + The modulation techniques of spread spectrum clocking for + each PLL. + minItems: 1 + maxItems: 4 + items: + enum: + - down-spread + - up-spread + - center-spread + required: - compatible - reg @@ -76,6 +110,11 @@ allOf: - const: clk_ext2 - const: clk_ext3 - const: clk_ext4 + fsl,ssc-clocks: false + fsl,ssc-modfreq-hz: false + fsl,ssc-modrate-percent: false + fsl,ssc-modmethod: false + else: properties: clocks: @@ -101,6 +140,8 @@ additionalProperties: false examples: # Clock Control Module node: - | + #include <dt-bindings/clock/imx8mm-clock.h> + clock-controller@30380000 { compatible = "fsl,imx8mm-ccm"; reg = <0x30380000 0x10000>; @@ -109,6 +150,11 @@ examples: <&clk_ext3>, <&clk_ext4>; clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", "clk_ext3", "clk_ext4"; + fsl,ssc-clocks = <&clk IMX8MM_AUDIO_PLL1>, + <&clk IMX8MM_VIDEO_PLL1>; + fsl,ssc-modfreq-hz = <6818>, <2419>; + fsl,ssc-modrate-percent = <3>, <7>; + fsl,ssc-modmethod = "down-spread", "center-spread"; }; - |
The patch adds the DT bindings for enabling and tuning spread spectrum clocking generation. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- Changes in v3: - Added in v3 - The dt-bindings have been moved from fsl,imx8m-anatop.yaml to imx8m-clock.yaml. The anatop device (fsl,imx8m-anatop.yaml) is indeed more or less a syscon, so it represents a memory area accessible by ccm (imx8m-clock.yaml) to setup the PLLs. .../bindings/clock/imx8m-clock.yaml | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+)