| Message ID | 20241203134137.2114847-7-m.wilczynski@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [RFC,v1,01/14] clk: thead: Refactor TH1520 clock driver to share common code | expand |
On Tue, 03 Dec 2024 14:41:29 +0100, Michal Wilczynski wrote: > As support for clocks from new subsystems is being added to the T-Head > TH1520 SoC, the Device Tree binding YAML schema file name should reflect > this broader scope. The existing schema file 'thead,th1520-clk-ap.yaml' > includes the '-ap' suffix, indicating it's specific to the Application > Processor (AP) subsystem. > > Rename the YAML schema file to 'thead,th1520-clk.yaml' to generalize it > for all subsystems. Update all references to this schema file > accordingly. > > Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> > --- > .../clock/{thead,th1520-clk-ap.yaml => thead,th1520-clk.yaml} | 2 +- > MAINTAINERS | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > rename Documentation/devicetree/bindings/clock/{thead,th1520-clk-ap.yaml => thead,th1520-clk.yaml} (96%) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241203134137.2114847-7-m.wilczynski@samsung.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 03/12/2024 14:41, Michal Wilczynski wrote: > As support for clocks from new subsystems is being added to the T-Head > TH1520 SoC, the Device Tree binding YAML schema file name should reflect > this broader scope. The existing schema file 'thead,th1520-clk-ap.yaml' > includes the '-ap' suffix, indicating it's specific to the Application > Processor (AP) subsystem. > > Rename the YAML schema file to 'thead,th1520-clk.yaml' to generalize it > for all subsystems. Update all references to this schema file > accordingly. > > Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> > --- > .../clock/{thead,th1520-clk-ap.yaml => thead,th1520-clk.yaml} | 2 +- > MAINTAINERS | 2 +- NAK, don't rename just because you added one more compatible (and anyway never a separate patch). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml b/Documentation/devicetree/bindings/clock/thead,th1520-clk.yaml similarity index 96% rename from Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml rename to Documentation/devicetree/bindings/clock/thead,th1520-clk.yaml index 5a8f1041f766..416c8882942e 100644 --- a/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml +++ b/Documentation/devicetree/bindings/clock/thead,th1520-clk.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 --- -$id: http://devicetree.org/schemas/clock/thead,th1520-clk-ap.yaml# +$id: http://devicetree.org/schemas/clock/thead,th1520-clk.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: T-HEAD TH1520 sub-systems clock controller diff --git a/MAINTAINERS b/MAINTAINERS index bd4bbf07d588..2f8f529e6a31 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20183,7 +20183,7 @@ M: Fu Wei <wefu@redhat.com> L: linux-riscv@lists.infradead.org S: Maintained T: git https://github.com/pdp7/linux.git -F: Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml +F: Documentation/devicetree/bindings/clock/thead,th1520-clk.yaml F: Documentation/devicetree/bindings/mailbox/thead,th1520-mbox.yaml F: Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml F: Documentation/devicetree/bindings/pinctrl/thead,th1520-pinctrl.yaml
As support for clocks from new subsystems is being added to the T-Head TH1520 SoC, the Device Tree binding YAML schema file name should reflect this broader scope. The existing schema file 'thead,th1520-clk-ap.yaml' includes the '-ap' suffix, indicating it's specific to the Application Processor (AP) subsystem. Rename the YAML schema file to 'thead,th1520-clk.yaml' to generalize it for all subsystems. Update all references to this schema file accordingly. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> --- .../clock/{thead,th1520-clk-ap.yaml => thead,th1520-clk.yaml} | 2 +- MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename Documentation/devicetree/bindings/clock/{thead,th1520-clk-ap.yaml => thead,th1520-clk.yaml} (96%)