| Message ID | 20241218091153.30088-1-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [v2,1/3] dt-bindings: clock: add ID for eMMC for EN7581 | expand |
On Wed, Dec 18, 2024 at 10:11:33AM +0100, Christian Marangi wrote: > Add ID for eMMC for EN7581. This is to control clock selection of eMMC > between 200MHz and 150MHz. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > Changes v2: > - Drop additional define for EN7581_NUM_CLOCKS > > include/dt-bindings/clock/en7523-clk.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h > index 717d23a5e5ae..c4f8a161b981 100644 > --- a/include/dt-bindings/clock/en7523-clk.h > +++ b/include/dt-bindings/clock/en7523-clk.h > @@ -12,6 +12,8 @@ > #define EN7523_CLK_CRYPTO 6 > #define EN7523_CLK_PCIE 7 > Why the gap? > +#define EN7581_CLK_EMMC 8 > + > #define EN7523_NUM_CLOCKS 8 Can you delete this please? Your changelog appears to suggest you did, but I see it still.
On Wed, Dec 18, 2024 at 05:04:03PM +0000, Conor Dooley wrote: > On Wed, Dec 18, 2024 at 10:11:33AM +0100, Christian Marangi wrote: > > Add ID for eMMC for EN7581. This is to control clock selection of eMMC > > between 200MHz and 150MHz. > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > --- > > Changes v2: > > - Drop additional define for EN7581_NUM_CLOCKS > > > > include/dt-bindings/clock/en7523-clk.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h > > index 717d23a5e5ae..c4f8a161b981 100644 > > --- a/include/dt-bindings/clock/en7523-clk.h > > +++ b/include/dt-bindings/clock/en7523-clk.h > > @@ -12,6 +12,8 @@ > > #define EN7523_CLK_CRYPTO 6 > > #define EN7523_CLK_PCIE 7 > > > > Why the gap? > It's only present in en7523 so maybe it's a good idea to have the gap to make that more clear? > > +#define EN7581_CLK_EMMC 8 > > + > > #define EN7523_NUM_CLOCKS 8 > > Can you delete this please? Your changelog appears to suggest you did, > but I see it still. Yes sure didn't want to change this too much to cause regression downstream if anyone was using it. Will drop in a dedicated patch when I will post v3 tomorrow.
On Wed, Dec 18, 2024 at 06:20:27PM +0100, Christian Marangi wrote: > On Wed, Dec 18, 2024 at 05:04:03PM +0000, Conor Dooley wrote: > > On Wed, Dec 18, 2024 at 10:11:33AM +0100, Christian Marangi wrote: > > > Add ID for eMMC for EN7581. This is to control clock selection of eMMC > > > between 200MHz and 150MHz. > > > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > > --- > > > Changes v2: > > > - Drop additional define for EN7581_NUM_CLOCKS > > > > > > include/dt-bindings/clock/en7523-clk.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h > > > index 717d23a5e5ae..c4f8a161b981 100644 > > > --- a/include/dt-bindings/clock/en7523-clk.h > > > +++ b/include/dt-bindings/clock/en7523-clk.h > > > @@ -12,6 +12,8 @@ > > > #define EN7523_CLK_CRYPTO 6 > > > #define EN7523_CLK_PCIE 7 > > > > > > > Why the gap? > > > > It's only present in en7523 so maybe it's a good idea to have the gap to > make that more clear? > > > > +#define EN7581_CLK_EMMC 8 > > > + > > > #define EN7523_NUM_CLOCKS 8 > > > > Can you delete this please? Your changelog appears to suggest you did, > > but I see it still. > > Yes sure didn't want to change this too much to cause regression > downstream if anyone was using it. Will drop in a dedicated patch when I > will post v3 tomorrow. Oh, I'm dumb. I didn't notice 1 instead of 3, sorry.
On Wed, Dec 18, 2024 at 10:11:33AM +0100, Christian Marangi wrote: > Add ID for eMMC for EN7581. This is to control clock selection of eMMC > between 200MHz and 150MHz. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > Changes v2: > - Drop additional define for EN7581_NUM_CLOCKS > > include/dt-bindings/clock/en7523-clk.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h > index 717d23a5e5ae..c4f8a161b981 100644 > --- a/include/dt-bindings/clock/en7523-clk.h > +++ b/include/dt-bindings/clock/en7523-clk.h > @@ -12,6 +12,8 @@ > #define EN7523_CLK_CRYPTO 6 > #define EN7523_CLK_PCIE 7 > > +#define EN7581_CLK_EMMC 8 > + > #define EN7523_NUM_CLOCKS 8 > > #endif /* _DT_BINDINGS_CLOCK_AIROHA_EN7523_H_ */ Acked-by: Conor Dooley <conor.dooley@microchip.com>
diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h index 717d23a5e5ae..c4f8a161b981 100644 --- a/include/dt-bindings/clock/en7523-clk.h +++ b/include/dt-bindings/clock/en7523-clk.h @@ -12,6 +12,8 @@ #define EN7523_CLK_CRYPTO 6 #define EN7523_CLK_PCIE 7 +#define EN7581_CLK_EMMC 8 + #define EN7523_NUM_CLOCKS 8 #endif /* _DT_BINDINGS_CLOCK_AIROHA_EN7523_H_ */
Add ID for eMMC for EN7581. This is to control clock selection of eMMC between 200MHz and 150MHz. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- Changes v2: - Drop additional define for EN7581_NUM_CLOCKS include/dt-bindings/clock/en7523-clk.h | 2 ++ 1 file changed, 2 insertions(+)