diff mbox series

[v3,1/4] dt-bindings: clock: qcom: Add compatible for QCM6490 boards

Message ID 20250212-lpass_qcm6490_resets-v3-1-0b1cfb35b38e@quicinc.com (mailing list archive)
State Changes Requested, archived
Headers show
Series Update LPASS Audio clock driver for QCM6490 board | expand

Commit Message

Taniya Das Feb. 12, 2025, 8:22 a.m. UTC
Add the new QCM6490 compatible to support the reset functionality for
Low Power Audio subsystem.

Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
---
 .../devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Krzysztof Kozlowski Feb. 13, 2025, 8:15 a.m. UTC | #1
On Wed, Feb 12, 2025 at 01:52:19PM +0530, Taniya Das wrote:
> @@ -130,6 +131,19 @@ allOf:
>          reg:
>            maxItems: 1
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,qcm6490-lpassaudiocc
> +
> +    then:

You need to constrain everything, also clocks. See all other examples.

Best regards,
Krzysztof
Taniya Das Feb. 13, 2025, 9:16 a.m. UTC | #2
On 2/13/2025 1:45 PM, Krzysztof Kozlowski wrote:
> On Wed, Feb 12, 2025 at 01:52:19PM +0530, Taniya Das wrote:
>> @@ -130,6 +131,19 @@ allOf:
>>          reg:
>>            maxItems: 1
>>  
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: qcom,qcm6490-lpassaudiocc
>> +
>> +    then:
> 
> You need to constrain everything, also clocks. See all other examples.
> 

Sure, I will take care to update in the next patch.

> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml
index 488d63959424088ede67835eb4dcf3feef6d0848..3217cd3c3b602e62b5cf2270fb351a6988d025aa 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml
@@ -20,6 +20,7 @@  description: |
 properties:
   compatible:
     enum:
+      - qcom,qcm6490-lpassaudiocc
       - qcom,sc7280-lpassaoncc
       - qcom,sc7280-lpassaudiocc
       - qcom,sc7280-lpasscorecc
@@ -130,6 +131,19 @@  allOf:
         reg:
           maxItems: 1
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: qcom,qcm6490-lpassaudiocc
+
+    then:
+      properties:
+        reg:
+          items:
+            - description: lpass core cc register
+            - description: lpass audio csr register
+
 additionalProperties: false
 
 examples: