| Message ID | 20250307064708.209511-1-hanchunchao@inspur.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: mmp: Fix NULL vs IS_ERR() check | expand |
On 07/03/2025 07:47, Charles Han wrote: > The devm_kzalloc() function returns NULL on error, not error pointers. > Fix the check. > > Fixes: 03437e857b0a ("clk: mmp: Add Marvell PXA1908 APMU driver") > Signed-off-by: Charles Han <hanchunchao@inspur.com> > --- > drivers/clk/mmp/clk-pxa1908-apmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This one might be actually correct (in other cases you were blindly copying some code like returning -ENOMEM while code expects NULL). Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Quoting Charles Han (2025-03-06 22:47:07) > The devm_kzalloc() function returns NULL on error, not error pointers. > Fix the check. > > Fixes: 03437e857b0a ("clk: mmp: Add Marvell PXA1908 APMU driver") > Signed-off-by: Charles Han <hanchunchao@inspur.com> > --- Applied to clk-next
diff --git a/drivers/clk/mmp/clk-pxa1908-apmu.c b/drivers/clk/mmp/clk-pxa1908-apmu.c index 8cfb1258202f..d3a070687fc5 100644 --- a/drivers/clk/mmp/clk-pxa1908-apmu.c +++ b/drivers/clk/mmp/clk-pxa1908-apmu.c @@ -87,8 +87,8 @@ static int pxa1908_apmu_probe(struct platform_device *pdev) struct pxa1908_clk_unit *pxa_unit; pxa_unit = devm_kzalloc(&pdev->dev, sizeof(*pxa_unit), GFP_KERNEL); - if (IS_ERR(pxa_unit)) - return PTR_ERR(pxa_unit); + if (!pxa_unit) + return -ENOMEM; pxa_unit->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pxa_unit->base))
The devm_kzalloc() function returns NULL on error, not error pointers. Fix the check. Fixes: 03437e857b0a ("clk: mmp: Add Marvell PXA1908 APMU driver") Signed-off-by: Charles Han <hanchunchao@inspur.com> --- drivers/clk/mmp/clk-pxa1908-apmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)