| Message ID | 20250315-msm8937-v4-3-1f132e870a49@mainlining.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Initial support of MSM8937 and Xiaomi Redmi 3S | expand |
On Sat, Mar 15, 2025 at 03:57:37PM +0100, Barnabás Czémán wrote: > From: Adam Skladowski <a39.skl@gmail.com> > > Adreno 505 (MSM8937), Adreno 506(MSM8953) and Adreno 510(MSM8976) > require Always-on branch clock to be enabled, describe it. > > Signed-off-by: Adam Skladowski <a39.skl@gmail.com> > [reword commit, move alwayson on the first place] > Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> > --- > Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml > index 6ddc72fd85b04537ea270754a897b4e7eb269641..5028398cc3b517e404a92a2c30688f72eab4c1b3 100644 > --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml > +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml > @@ -152,11 +152,13 @@ allOf: > properties: > clocks: > minItems: 2 > - maxItems: 7 > + maxItems: 8 > > clock-names: > items: > anyOf: > + - const: alwayson > + description: GPU Always-On clock Are you adding bindings for devices which were not described previously? Then don't grow this pattern, but create if:then: with a strictly ordered list for them (and keeping order of other variants). Best regards, Krzysztof
On March 17, 2025 10:21:50 AM GMT+01:00, Krzysztof Kozlowski <krzk@kernel.org> wrote: >On Sat, Mar 15, 2025 at 03:57:37PM +0100, Barnabás Czémán wrote: >> From: Adam Skladowski <a39.skl@gmail.com> >> >> Adreno 505 (MSM8937), Adreno 506(MSM8953) and Adreno 510(MSM8976) >> require Always-on branch clock to be enabled, describe it. >> >> Signed-off-by: Adam Skladowski <a39.skl@gmail.com> >> [reword commit, move alwayson on the first place] >> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> >> --- >> Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml >> index 6ddc72fd85b04537ea270754a897b4e7eb269641..5028398cc3b517e404a92a2c30688f72eab4c1b3 100644 >> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml >> @@ -152,11 +152,13 @@ allOf: >> properties: >> clocks: >> minItems: 2 >> - maxItems: 7 >> + maxItems: 8 >> >> clock-names: >> items: >> anyOf: >> + - const: alwayson >> + description: GPU Always-On clock > >Are you adding bindings for devices which were not described previously? >Then don't grow this pattern, but create if:then: with a strictly >ordered list for them (and keeping order of other variants). > 8956, 8976, 8953 schemas are failing because of missing always-on clock. >Best regards, >Krzysztof >
On 17/03/2025 10:48, Barnabás Czémán wrote: > > > On March 17, 2025 10:21:50 AM GMT+01:00, Krzysztof Kozlowski <krzk@kernel.org> wrote: >> On Sat, Mar 15, 2025 at 03:57:37PM +0100, Barnabás Czémán wrote: >>> From: Adam Skladowski <a39.skl@gmail.com> >>> >>> Adreno 505 (MSM8937), Adreno 506(MSM8953) and Adreno 510(MSM8976) >>> require Always-on branch clock to be enabled, describe it. >>> >>> Signed-off-by: Adam Skladowski <a39.skl@gmail.com> >>> [reword commit, move alwayson on the first place] >>> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> >>> --- >>> Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ++++-- >>> 1 file changed, 4 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml >>> index 6ddc72fd85b04537ea270754a897b4e7eb269641..5028398cc3b517e404a92a2c30688f72eab4c1b3 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml >>> @@ -152,11 +152,13 @@ allOf: >>> properties: >>> clocks: >>> minItems: 2 >>> - maxItems: 7 >>> + maxItems: 8 >>> >>> clock-names: >>> items: >>> anyOf: >>> + - const: alwayson >>> + description: GPU Always-On clock >> >> Are you adding bindings for devices which were not described previously? >> Then don't grow this pattern, but create if:then: with a strictly >> ordered list for them (and keeping order of other variants). >> > 8956, 8976, 8953 schemas are failing because of missing always-on clock. Based on the commit msg and style of binding having a pattern instead of compatibles, I really cannot tell whether you add new devices or fix something for existing. and now I dug more and found: https://lore.kernel.org/all/f525b63f-a32c-41cf-b80f-5d85b6eb50c8@linaro.org/ There were some other patches as well :/ Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml index 6ddc72fd85b04537ea270754a897b4e7eb269641..5028398cc3b517e404a92a2c30688f72eab4c1b3 100644 --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml @@ -152,11 +152,13 @@ allOf: properties: clocks: minItems: 2 - maxItems: 7 + maxItems: 8 clock-names: items: anyOf: + - const: alwayson + description: GPU Always-On clock - const: core description: GPU Core clock - const: iface @@ -174,7 +176,7 @@ allOf: - const: rbcpr description: GPU RB Core Power Reduction clock minItems: 2 - maxItems: 7 + maxItems: 8 required: - clocks