From patchwork Sun Mar 23 22:39:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14026633 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C3B01EE013 for ; Sun, 23 Mar 2025 22:39:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742769588; cv=none; b=O290IhDiJJdiVqNNVkc6P+71Ed5LYkDmvjjINx3hqaHe917Sxn44LXTYeF3fD4OXeFRoU6dzgcK3KVfOw5ol/fdka10d/24Xc4R7Br8WxrYkhpkWdec/dLzUSn7qR0n7ZmNQwBLPCzYFvyWbeMZ/YBPr0Jve9a6LKlc15/ZCzNY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742769588; c=relaxed/simple; bh=2SEWJHOQRVHtm1hZDIQV8G5h9Ihj/ZSId7FCsdh0cUI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=igeqRAHd+5tUHb4IyVgxhy1bG7Pa8CY1jWLOmfX50/UI1pJA3x3piZ4oACyBrWsV57aLknuAHMVpLw+PjA7tJnl3OKfeHJFKadoIGmQZUFPZplHoidsv9jexNQ2SGIGkUsMnM3o7EB4C0So3Q6uL/6umMYf6pD6F2HZ0AKrChcs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DdIo1ocr; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DdIo1ocr" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-ac2a089fbbdso689707166b.1 for ; Sun, 23 Mar 2025 15:39:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742769580; x=1743374380; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QFi/wIa2zliLVLaoNCXevujk62BEru73nW/QKRcDHsY=; b=DdIo1ocr6oN1WklNPRlM4v5d7MVDSh5ol+XMGFqEPShgIb3z9VDnKq7j64GpehYkeo V7Q5zwbhXHjozJGe31PomdnLA9V3GY3+tRPOhlJ+Qq0YjXtmb0jS/i+9iiPblgToXjk7 CwspOU3w2RNjPAhm2uf1eMc4CN1t1vlgIZHXsuh1N5QqHqQrZJklXZZXj+OrdnAXHR32 Tv3qChqTcYXJeUhcyLBcu4syBqo+0hEupi7kPld0J4sMva324Fg8HBJcZrA7zj3hyqwM qRqNrvtOvb0RTJ+RXY1S6zSzrzSimFoKBSn4Ld1lIRcRIJOyKX161RHBMqlC7QsR3yt3 8LQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742769580; x=1743374380; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QFi/wIa2zliLVLaoNCXevujk62BEru73nW/QKRcDHsY=; b=YlRTixZXZl8S5zdIfb3uZYV+RPx5XO+mZsx3Bl6R+W8SwuvEn/vbi0Lro7kA5erxPq 5JcERfDc1G9ErzkqTEOCU4KY4hghDah8SXf5ibs5s6VOYVLawEpTMYBPclZrWbP9zM+L MYRIevkACe7tHEo9dwNctAkUffiBBsBGmksohW1PGsV+HZjFJdbOlcAqQ6zo338LPDfT ZLn7Cq1njBBweETtQ5LkZ8wi6p/lTZUWHmcN685OjIEWNSZWtAWx8vfvBsYK8+VSxp7S uvB0+m47EJaOHqr0PAaWrvy1IsHgEqiqmYzWoIAElH72d7dEkjV7iGMtoCqKTjIrVfXa adIA== X-Forwarded-Encrypted: i=1; AJvYcCWyB13jaFA8yJ3pkVz+QzpWedcGZtp7KaczgJUISU9euzMU0rTYeejarh96VYu+KO3NbiZC/u0LgG8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2gefFKUmqpZTp0sjim+mn9unkb1y+w5GlhqIDCNYfc5Lp4gbm BPxRbrBSsC8UZCjAlyw5Lk5z6B842lttchHkecDi2LrTpmWEmxTCa1D9ZXFAddw= X-Gm-Gg: ASbGncvnYYQqwQlbMiOS1hHKw6FJ8JxUW4qhkt50NV9q85HBMp2upqRY7uiUQ1NCs67 njFbt4MGDo2k7NyuttZXGmvi1eWPs0uqRdX3v43l/Wsc0eKr5cvgxw4T9HwPyZow7I8eZP1QfNM ptEQZs9USaN9p3MJgmPfmvCnkDLVo9GkzzWZ8dZ4xleqU6AsNc9Ryn1D7DoC26rHtxq7dcfuFsm sjLdx7MbMJ5gjrYFJGhcSdZopt/t0s2Ogyun7MVrN2bk8+J7HOxsJX94MPkt/hSeOCI3/TGJn8W E9oUGzoturCK+Ku62bWSlg0IuzfrCYn9lXLjrH8yofcuR9ieQgUu/U35QK9IUhSTifmUiV34oPU KZsy8jWqdjWmHtCoBxLuj2RKA/otH X-Google-Smtp-Source: AGHT+IExdWMeq50KMSeL2g8X5YzwdCsnSfpgrljF2A0N/7BkwT1ZoOB/F1xNUkswffcMZkq5HeqMZw== X-Received: by 2002:a17:907:86a7:b0:ac3:c6a2:a02d with SMTP id a640c23a62f3a-ac3cdb95075mr1563087566b.7.1742769579644; Sun, 23 Mar 2025 15:39:39 -0700 (PDT) Received: from puffmais.c.googlers.com (8.239.204.35.bc.googleusercontent.com. [35.204.239.8]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3ef86e44dsm559686666b.31.2025.03.23.15.39.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Mar 2025 15:39:39 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Sun, 23 Mar 2025 22:39:43 +0000 Subject: [PATCH 27/34] rtc: s5m: cache value of platform_get_device_id() during probe Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250323-s2mpg10-v1-27-d08943702707@linaro.org> References: <20250323-s2mpg10-v1-0-d08943702707@linaro.org> In-Reply-To: <20250323-s2mpg10-v1-0-d08943702707@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 platform_get_device_id() is called mulitple times during probe. This makes the code harder to read than necessary. Just get the ID once, which also trims the lengths of the lines involved. Signed-off-by: André Draszik --- drivers/rtc/rtc-s5m.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index db5c9b641277213aa1371776c63e2eda3f223465..31bdceac7aa245175a30eb13eaaf1f52f70e22c2 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -637,6 +637,8 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) static int s5m_rtc_probe(struct platform_device *pdev) { struct sec_pmic_dev *s5m87xx = dev_get_drvdata(pdev->dev.parent); + const struct platform_device_id * const id = + platform_get_device_id(pdev); struct s5m_rtc_info *info; struct i2c_client *i2c; const struct regmap_config *regmap_cfg; @@ -646,7 +648,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) if (!info) return -ENOMEM; - switch (platform_get_device_id(pdev)->driver_data) { + switch (id->driver_data) { case S2MPS15X: regmap_cfg = &s2mps14_rtc_regmap_config; info->regs = &s2mps15_rtc_regs; @@ -670,7 +672,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) default: return dev_err_probe(&pdev->dev, -ENODEV, "Device type %lu is not supported by RTC driver\n", - platform_get_device_id(pdev)->driver_data); + id_entry->driver_data); } i2c = devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, @@ -686,7 +688,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) info->dev = &pdev->dev; info->s5m87xx = s5m87xx; - info->device_type = platform_get_device_id(pdev)->driver_data; + info->device_type = id->driver_data; if (s5m87xx->irq_data) { info->irq = regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq);