| Message ID | 20250323-s2mpg10-v1-3-d08943702707@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Samsung S2MPG10 PMIC MFD-based drivers | expand |
On 23/03/2025 23:39, André Draszik wrote: > The upcoming Samsung S2MPG10 PMIC driver will need this symbol to > communicate with the IC. > > Export it. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- > drivers/firmware/samsung/exynos-acpm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/samsung/exynos-acpm.c > index a85b2dbdd9f0d7b1f327f54a0a283e4f32587a98..7525bee4c6715edb964fc770ac9d8b3dd2be2172 100644 > --- a/drivers/firmware/samsung/exynos-acpm.c > +++ b/drivers/firmware/samsung/exynos-acpm.c > @@ -741,6 +741,7 @@ const struct acpm_handle *devm_acpm_get_by_phandle(struct device *dev, > > return handle; > } > +EXPORT_SYMBOL_GPL(devm_acpm_get_by_phandle); If binding changes to parent-child relationship, this might not be needed. Best regards, Krzysztof
On Wed, 2025-03-26 at 08:03 +0100, Krzysztof Kozlowski wrote: > On 23/03/2025 23:39, André Draszik wrote: > > The upcoming Samsung S2MPG10 PMIC driver will need this symbol to > > communicate with the IC. > > > > Export it. > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > --- > > drivers/firmware/samsung/exynos-acpm.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/samsung/exynos-acpm.c > > index a85b2dbdd9f0d7b1f327f54a0a283e4f32587a98..7525bee4c6715edb964fc770ac9d8b3dd2be2172 100644 > > --- a/drivers/firmware/samsung/exynos-acpm.c > > +++ b/drivers/firmware/samsung/exynos-acpm.c > > @@ -741,6 +741,7 @@ const struct acpm_handle *devm_acpm_get_by_phandle(struct device *dev, > > > > return handle; > > } > > +EXPORT_SYMBOL_GPL(devm_acpm_get_by_phandle); > > If binding changes to parent-child relationship, this might not be needed. Indeed, I've instead added devm_acpm_get_by_node(), and clients are meant to pass the parent node pointer into it. Cheers, Andre'
diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/samsung/exynos-acpm.c index a85b2dbdd9f0d7b1f327f54a0a283e4f32587a98..7525bee4c6715edb964fc770ac9d8b3dd2be2172 100644 --- a/drivers/firmware/samsung/exynos-acpm.c +++ b/drivers/firmware/samsung/exynos-acpm.c @@ -741,6 +741,7 @@ const struct acpm_handle *devm_acpm_get_by_phandle(struct device *dev, return handle; } +EXPORT_SYMBOL_GPL(devm_acpm_get_by_phandle); static const struct acpm_match_data acpm_gs101 = { .initdata_base = ACPM_GS101_INITDATA_BASE,
The upcoming Samsung S2MPG10 PMIC driver will need this symbol to communicate with the IC. Export it. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- drivers/firmware/samsung/exynos-acpm.c | 1 + 1 file changed, 1 insertion(+)