From patchwork Mon Jul 11 15:36:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9223779 X-Patchwork-Delegate: sboyd@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A52BD604DB for ; Mon, 11 Jul 2016 15:33:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 935F526220 for ; Mon, 11 Jul 2016 15:33:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8723E27DCE; Mon, 11 Jul 2016 15:33:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B07C027DCD for ; Mon, 11 Jul 2016 15:33:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759296AbcGKPdj (ORCPT ); Mon, 11 Jul 2016 11:33:39 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:59072 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759185AbcGKPdi (ORCPT ); Mon, 11 Jul 2016 11:33:38 -0400 Received: from wuerfel.localnet ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue005) with ESMTPSA (Nemesis) id 0LrGGm-1bH15I3NAy-01335n; Mon, 11 Jul 2016 17:32:40 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Wan Zongshun , Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, jason@lakedaemon.net, Daniel Lezcano , linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Thomas Gleixner , Wan Zongshun Subject: Re: [PATCH v2 03/10] Clocksource: add nuc970 clocksource driver Date: Mon, 11 Jul 2016 17:36:13 +0200 Message-ID: <3277576.eNgdG7zPqq@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1468135649-19980-4-git-send-email-vw@iommu.org> References: <1468135649-19980-1-git-send-email-vw@iommu.org> <1468135649-19980-4-git-send-email-vw@iommu.org> MIME-Version: 1.0 X-Provags-ID: V03:K0:b6+Sin9Ay0K1OKBfZ6oHR7l6887E/mEyvTxFesD8irP3BflazDM THns6K2zrpvJ4QFxBcVlBu9q0Rx2eJLl21D0hpDFG7Za+keqOa1fUOcTaJ/K4te6xq6bJZl QeTdSecW5oy/oq9fmWihr7OuYNhPUamYP4wrmgpDxQC76cVfJ/CnxmFOswNeoDpeWMX1r/V QTqaS9cR7aHJis9pYfiCg== X-UI-Out-Filterresults: notjunk:1; V01:K0:id5ipT+NXLc=:uxumG96z7A4AcqG1fAkito VG9tt6Y6BFJV6RLpqY5G4zo856YrIjWMhNqmy8VExerx8H5Ib80OVh0UDJW9/k272IEriKJ2i wJvAS9823BHJHG2xZZS3JRHVf4+y2ifFOeZpo6kSgFhM2rxO5G9RjnP/xmprCRuJn+fsypHSe 4aqi0NIdnUBUYqlDj74Tv4xhK+kk+n09WC4jMnS3DICfj9rY8nLKsaNZu8AKGeN9ggDerKlnj Q/YmBW0v/hX50RC57H/QfIhbe9q+bUZPet2fEiWVr+OcargtF9DXTkDhe7m+Sfb99euERzSDU +XACLzbvWLpP90qGpYJg0vmPsi+UH3wugK6IPlTVw/kVSuD/SAssqHK0QxTcGL1JS/bN3k5jh FShlAguAatgoKLR+n9RFAUG7q2M8fTyjFMZvqEvSckC/4bHk9Ye56A0eW1UY73lCmpXFZLBiJ N7YE2NamdbEhFo8kIFJ/xJJWormTvloynyHpz9UaNAq1DJRxw7Rusoy9w0z0fe/FzHmq/YmqZ tjv6n4kkIeHRgD/Hk/E0hJA8tkVLY9rU07Qeo3Mns2wxl3pvt72ZHJPxReK5dtHGfebQSuTPl y8NQGOnVIySNXAqHYQvx+j6GmVuqaxxEM8NSZV4BmPOADMC+txagi3jqYVKF21utgT4TUC9FC tGs6BIMn2G8vPnGrl2xxVx+4R95o4Qsl0M+bvdSixj5XyDMwKKMf7COL0jCsUtCDoMxOeHEsU jowalE8ea9El5n7w Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sunday, July 10, 2016 3:27:23 PM CEST Wan Zongshun wrote: > > +config NUC900_TIMER > + bool "Clocksource timer for nuc900 platform" if COMPILE_TEST > + depends on ARM > + select CLKSRC_OF if OF > + select CLKSRC_MMIO > + help > + Enables the clocksource for the NUC900 platform. > I have put this patch into my randconfig build system and found that it lacks a dependency: Also the init function has changed its return type in linux-next: > +static void __init nuc970_timer_of_init(struct device_node *node) This now needs to return an error code or we get: ../include/linux/of.h:1004:20: error: comparison of distinct pointer types lacks a cast [-Werror] .data = (fn == (fn_type)NULL) ? fn : fn } Daniel Lezcano seems to have implemented a migration strategy, but I can't see what you are supposed to do here, since the CLOCKSOURCE_OF_DECLARE_RET macro is no longer part of linux-next. Arnd --- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index e18ef32776a3..59b9251eef37 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -523,7 +523,7 @@ config CLKSRC_ST_LPC config NUC900_TIMER bool "Clocksource timer for nuc900 platform" if COMPILE_TEST - depends on ARM + depends on ARM && GENERIC_CLOCKEVENTS select CLKSRC_OF if OF select CLKSRC_MMIO help