| Message ID | 4179b63bb3f151a49616c4ae2702de16702ad739.1694596125.git.ysato@users.sourceforge.jp (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
Hi Sato-san, On Wed, Sep 13, 2023 at 11:24 AM Yoshinori Sato <ysato@users.sourceforge.jp> wrote: > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> Thanks for your patch! Patch prefix should be "clk: renesas: ". > drivers/clk/renesas/Kconfig | 15 ++++++++++++++- > drivers/clk/renesas/Makefile | 1 + Please combine this patch with "[RFC PATCH v2 10/30] drivers/clk: SH7750 / SH7751 CPG Driver". > --- a/drivers/clk/renesas/Kconfig > +++ b/drivers/clk/renesas/Kconfig > @@ -2,7 +2,7 @@ > > config CLK_RENESAS > bool "Renesas SoC clock support" if COMPILE_TEST && !ARCH_RENESAS ... && !SUPERH > - default y if ARCH_RENESAS > + default y if ARCH_RENESAS || SUPERH > select CLK_EMEV2 if ARCH_EMEV2 > select CLK_RZA1 if ARCH_R7S72100 > select CLK_R7S9210 if ARCH_R7S9210 > @@ -39,6 +39,11 @@ config CLK_RENESAS > select CLK_R9A07G054 if ARCH_R9A07G054 > select CLK_R9A09G011 if ARCH_R9A09G011 > select CLK_SH73A0 if ARCH_SH73A0 > + select CLK_SH7750 if CPU_SUBTYPE_SH7750 > + select CLK_SH7750 if CPU_SUBTYPE_SH7750S > + select CLK_SH7750 if CPU_SUBTYPE_SH7750R > + select CLK_SH7750 if CPU_SUBTYPE_SH7751 > + select CLK_SH7750 if CPU_SUBTYPE_SH7751R > > if CLK_RENESAS > > @@ -218,6 +223,14 @@ config CLK_RZG2L > bool "Renesas RZ/{G2L,G2UL,V2L} family clock support" if COMPILE_TEST > select RESET_CONTROLLER > > +config CLK_SH7750 Probably you want to move this below CLK_SH73A0... > + bool "Renesas SH7750/7751 family clock support" ... and drop the "Renesas" part? Please add "if COMPILE_TEST" like all other clock drivers in this file. > + depends on CPU_SUBTYPE_SH7750 || CPU_SUBTYPE_SH7750S || \ > + CPU_SUBTYPE_SH7750R || \ > + CPU_SUBTYPE_SH7751 || CPU_SUBTYPE_SH7751R || COMPILE_TEST There is no need for a dependency rule. > + help > + This is a driver for SH7750 / SH7751 CPG. > + > # Generic > config CLK_RENESAS_CPG_MSSR > bool "CPG/MSSR clock support" if COMPILE_TEST Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/clk/renesas/Kconfig b/drivers/clk/renesas/Kconfig index 37632a0659d8..c4e2f7d0349d 100644 --- a/drivers/clk/renesas/Kconfig +++ b/drivers/clk/renesas/Kconfig @@ -2,7 +2,7 @@ config CLK_RENESAS bool "Renesas SoC clock support" if COMPILE_TEST && !ARCH_RENESAS - default y if ARCH_RENESAS + default y if ARCH_RENESAS || SUPERH select CLK_EMEV2 if ARCH_EMEV2 select CLK_RZA1 if ARCH_R7S72100 select CLK_R7S9210 if ARCH_R7S9210 @@ -39,6 +39,11 @@ config CLK_RENESAS select CLK_R9A07G054 if ARCH_R9A07G054 select CLK_R9A09G011 if ARCH_R9A09G011 select CLK_SH73A0 if ARCH_SH73A0 + select CLK_SH7750 if CPU_SUBTYPE_SH7750 + select CLK_SH7750 if CPU_SUBTYPE_SH7750S + select CLK_SH7750 if CPU_SUBTYPE_SH7750R + select CLK_SH7750 if CPU_SUBTYPE_SH7751 + select CLK_SH7750 if CPU_SUBTYPE_SH7751R if CLK_RENESAS @@ -218,6 +223,14 @@ config CLK_RZG2L bool "Renesas RZ/{G2L,G2UL,V2L} family clock support" if COMPILE_TEST select RESET_CONTROLLER +config CLK_SH7750 + bool "Renesas SH7750/7751 family clock support" + depends on CPU_SUBTYPE_SH7750 || CPU_SUBTYPE_SH7750S || \ + CPU_SUBTYPE_SH7750R || \ + CPU_SUBTYPE_SH7751 || CPU_SUBTYPE_SH7751R || COMPILE_TEST + help + This is a driver for SH7750 / SH7751 CPG. + # Generic config CLK_RENESAS_CPG_MSSR bool "CPG/MSSR clock support" if COMPILE_TEST diff --git a/drivers/clk/renesas/Makefile b/drivers/clk/renesas/Makefile index de907623fe3f..3f896cf31dc4 100644 --- a/drivers/clk/renesas/Makefile +++ b/drivers/clk/renesas/Makefile @@ -36,6 +36,7 @@ obj-$(CONFIG_CLK_R9A07G044) += r9a07g044-cpg.o obj-$(CONFIG_CLK_R9A07G054) += r9a07g044-cpg.o obj-$(CONFIG_CLK_R9A09G011) += r9a09g011-cpg.o obj-$(CONFIG_CLK_SH73A0) += clk-sh73a0.o +obj-$(CONFIG_CLK_SH7750) += clk-sh7750.o clk-shdiv.o # Family obj-$(CONFIG_CLK_RCAR_CPG_LIB) += rcar-cpg-lib.o
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> --- drivers/clk/renesas/Kconfig | 15 ++++++++++++++- drivers/clk/renesas/Makefile | 1 + 2 files changed, 15 insertions(+), 1 deletion(-)