diff mbox

[1/2] cpufreq: rcar: Add support for R8A7795 SoC

Message ID 57316A4E.7040100@rvc.renesas.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

khiemnguyen May 10, 2016, 4:57 a.m. UTC
After the commit "a399dc9fc50 cpufreq: shmobile: Use generic platdev
driver", will use cpufreq-dt-platdev driver to enable cpufreq-dt support.
Hence, follow the implementation to support new R8A7795 SoC.

Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@rvc.renesas.com>
---
  drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
  1 file changed, 1 insertion(+)

  	{ .compatible = "rockchip,rk2928", },

Comments

Viresh Kumar May 10, 2016, 5:07 a.m. UTC | #1
On 10-05-16, 11:57, Khiem Nguyen wrote:
> After the commit "a399dc9fc50 cpufreq: shmobile: Use generic platdev
> driver", will use cpufreq-dt-platdev driver to enable cpufreq-dt support.
> Hence, follow the implementation to support new R8A7795 SoC.
> 
> Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@rvc.renesas.com>
> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Geert Uytterhoeven May 10, 2016, 8:17 a.m. UTC | #2
Hi Viresh,

On Tue, May 10, 2016 at 7:07 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 10-05-16, 11:57, Khiem Nguyen wrote:
>> After the commit "a399dc9fc50 cpufreq: shmobile: Use generic platdev
>> driver", will use cpufreq-dt-platdev driver to enable cpufreq-dt support.
>> Hence, follow the implementation to support new R8A7795 SoC.
>>
>> Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@rvc.renesas.com>
>> ---
>>  drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
>>  1 file changed, 1 insertion(+)
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Quoting Viresh when this file was introduced:
| This is going to be done once per boot and this shouldn't hurt. And for new
| platforms we may do things differently as they are going to use
opp-v2 bindings.

As r8a7795/r8a7796 are not arm32 "shmobile", but arm64, perhaps we should
use this new "opp-v2" binding instead? Has it been finalized?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Viresh Kumar May 10, 2016, 8:19 a.m. UTC | #3
On 10-05-16, 10:17, Geert Uytterhoeven wrote:
> Hi Viresh,
> 
> On Tue, May 10, 2016 at 7:07 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On 10-05-16, 11:57, Khiem Nguyen wrote:
> >> After the commit "a399dc9fc50 cpufreq: shmobile: Use generic platdev
> >> driver", will use cpufreq-dt-platdev driver to enable cpufreq-dt support.
> >> Hence, follow the implementation to support new R8A7795 SoC.
> >>
> >> Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@rvc.renesas.com>
> >> ---
> >>  drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Quoting Viresh when this file was introduced:
> | This is going to be done once per boot and this shouldn't hurt. And for new
> | platforms we may do things differently as they are going to use
> opp-v2 bindings.
> 
> As r8a7795/r8a7796 are not arm32 "shmobile", but arm64, perhaps we should
> use this new "opp-v2" binding instead? Has it been finalized?

Yeah, that would be preferred.
diff mbox

Patch

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
b/drivers/cpufreq/cpufreq-dt-platdev.c
index ac4a0ba..32f6dda 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -53,6 +53,7 @@  static const struct of_device_id machines[] 
__initconst = {
  	{ .compatible = "renesas,r8a7791", },
  	{ .compatible = "renesas,r8a7793", },
  	{ .compatible = "renesas,r8a7794", },
+	{ .compatible = "renesas,r8a7795", },
  	{ .compatible = "renesas,sh73a0", },