| Message ID | 6155067d-aed5-4799-9e14-6dff7be1cb3a@stanley.mountain (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [next] clk: mmp: pxa1908-apbcp: Fix a NULL vs IS_ERR() bug in probe | expand |
On Wednesday 20 November 2024 18:18:44 Central European Standard Time Dan Carpenter wrote: > The devm_kzalloc() function doesn't return error pointers, it returns > NULL on error. Update the check to match. > > Fixes: a89233dbd4df ("clk: mmp: Add Marvell PXA1908 APBCP driver") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- Acked-by: Duje Mihanović <duje.mihanovic@skole.hr> Regards,
Quoting Dan Carpenter (2024-11-20 09:18:44) > The devm_kzalloc() function doesn't return error pointers, it returns > NULL on error. Update the check to match. > > Fixes: a89233dbd4df ("clk: mmp: Add Marvell PXA1908 APBCP driver") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- Applied to clk-next
diff --git a/drivers/clk/mmp/clk-pxa1908-apbcp.c b/drivers/clk/mmp/clk-pxa1908-apbcp.c index 08f3845cbb1b..f638d7e89b47 100644 --- a/drivers/clk/mmp/clk-pxa1908-apbcp.c +++ b/drivers/clk/mmp/clk-pxa1908-apbcp.c @@ -48,8 +48,8 @@ static int pxa1908_apbcp_probe(struct platform_device *pdev) struct pxa1908_clk_unit *pxa_unit; pxa_unit = devm_kzalloc(&pdev->dev, sizeof(*pxa_unit), GFP_KERNEL); - if (IS_ERR(pxa_unit)) - return PTR_ERR(pxa_unit); + if (!pxa_unit) + return -ENOMEM; pxa_unit->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pxa_unit->base))
The devm_kzalloc() function doesn't return error pointers, it returns NULL on error. Update the check to match. Fixes: a89233dbd4df ("clk: mmp: Add Marvell PXA1908 APBCP driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/clk/mmp/clk-pxa1908-apbcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)