| Message ID | 636308462efb579734de829fb6e9cbda81b982f7.1686126439.git.quic_varada@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Enable IPQ5332 USB2 | expand |
On 07/06/2023 13:56, Varadarajan Narayanan wrote: > Introduce CONFIG_PHY_QCOM_M31_USB for including the M31 phy driver > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> Is there any reason to keep Kconfig, Makefile and driver in different commits? > --- > drivers/phy/qualcomm/Kconfig | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig > index 67a45d9..8a363dd 100644 > --- a/drivers/phy/qualcomm/Kconfig > +++ b/drivers/phy/qualcomm/Kconfig > @@ -188,3 +188,14 @@ config PHY_QCOM_IPQ806X_USB > This option enables support for the Synopsis PHYs present inside the > Qualcomm USB3.0 DWC3 controller on ipq806x SoC. This driver supports > both HS and SS PHY controllers. > + > +config PHY_QCOM_M31_USB > + tristate "Qualcomm M31 HS PHY driver support" > + depends on (USB || USB_GADGET) && ARCH_QCOM > + select USB_PHY > + help > + Enable this to support M31 HS PHY transceivers on Qualcomm chips > + with DWC3 USB core. It handles PHY initialization, clock > + management required after resetting the hardware and power > + management. This driver is required even for peripheral only or > + host only mode configurations.
On 07/06/2023 13:20, Dmitry Baryshkov wrote: > On 07/06/2023 13:56, Varadarajan Narayanan wrote: >> Introduce CONFIG_PHY_QCOM_M31_USB for including the M31 phy driver >> >> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > Is there any reason to keep Kconfig, Makefile and driver in different > commits? KPI? Yearly objectives/goals? Best regards, Krzysztof
On Wed, Jun 07, 2023 at 08:37:05PM +0200, Krzysztof Kozlowski wrote: > On 07/06/2023 13:20, Dmitry Baryshkov wrote: > > On 07/06/2023 13:56, Varadarajan Narayanan wrote: > >> Introduce CONFIG_PHY_QCOM_M31_USB for including the M31 phy driver > >> > >> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > > Is there any reason to keep Kconfig, Makefile and driver in different > > commits? > > KPI? Yearly objectives/goals? No :-). Was not sure, hence split them. Will combine in the next version. Thanks Varada
diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig index 67a45d9..8a363dd 100644 --- a/drivers/phy/qualcomm/Kconfig +++ b/drivers/phy/qualcomm/Kconfig @@ -188,3 +188,14 @@ config PHY_QCOM_IPQ806X_USB This option enables support for the Synopsis PHYs present inside the Qualcomm USB3.0 DWC3 controller on ipq806x SoC. This driver supports both HS and SS PHY controllers. + +config PHY_QCOM_M31_USB + tristate "Qualcomm M31 HS PHY driver support" + depends on (USB || USB_GADGET) && ARCH_QCOM + select USB_PHY + help + Enable this to support M31 HS PHY transceivers on Qualcomm chips + with DWC3 USB core. It handles PHY initialization, clock + management required after resetting the hardware and power + management. This driver is required even for peripheral only or + host only mode configurations.
Introduce CONFIG_PHY_QCOM_M31_USB for including the M31 phy driver Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- drivers/phy/qualcomm/Kconfig | 11 +++++++++++ 1 file changed, 11 insertions(+)