[2/2] clk-mux: Improve a size determination in clk_hw_register_mux_table()

Commit Message

SF Markus Elfring Sept. 26, 2017, 4:22 p.m. UTC

From: Markus Elfring <[e-mail]>
Date: Tue, 26 Sep 2017 17:30:06 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[e-mail]>
---
 drivers/clk/clk-mux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Boyd Nov. 14, 2017, 1:57 a.m. UTC | #1

On 09/26, SF Markus Elfring wrote:
> From: Markus Elfring <[e-mail]>
> Date: Tue, 26 Sep 2017 17:30:06 +0200
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <[e-mail]>
> ---

Applied to clk-next

Patch

diff --git a/drivers/clk/clk-mux.c b/drivers/clk/clk-mux.c
index 1746dbf2f7ea..39cabe157163 100644
--- a/drivers/clk/clk-mux.c
+++ b/drivers/clk/clk-mux.c
@@ -134,7 +134,7 @@  struct clk_hw *clk_hw_register_mux_table(struct device *dev, const char *name,
 	}
 
 	/* allocate the mux */
-	mux = kzalloc(sizeof(struct clk_mux), GFP_KERNEL);
+	mux = kzalloc(sizeof(*mux), GFP_KERNEL);
 	if (!mux)
 		return ERR_PTR(-ENOMEM);