diff mbox series

PM / devfreq: tegra30: add COMMON_CLK dependency

Message ID 87v9qk4yrk.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Superseded, archived
Headers show
Series PM / devfreq: tegra30: add COMMON_CLK dependency | expand

Commit Message

Kuninori Morimoto Dec. 13, 2019, 4:47 a.m. UTC
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Compile-testing the new driver on platforms without CONFIG_COMMON_CLK
leads to a link error:

	drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
	tegra30-devfreq.c:(.text+0x288): undefined reference to `clk_set_min_rate'

Add a dependency on COMMON_CLK to avoid this.

Fixes: 35f8dbc727212 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/devfreq/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Chanwoo Choi Dec. 13, 2019, 4:57 a.m. UTC | #1
On 12/13/19 1:47 PM, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Compile-testing the new driver on platforms without CONFIG_COMMON_CLK
> leads to a link error:
> 
> 	drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
> 	tegra30-devfreq.c:(.text+0x288): undefined reference to `clk_set_min_rate'
> 
> Add a dependency on COMMON_CLK to avoid this.
> 
> Fixes: 35f8dbc727212 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver")
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  drivers/devfreq/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index defe1d4..a78191c 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -94,6 +94,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
>  
>  config ARM_TEGRA_DEVFREQ
>  	tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
> +	depends on COMMON_CLK
>  	depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
>  		ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
>  		ARCH_TEGRA_210_SOC || \
> 

Thanks for the fixup.

But, it was merged as following:
- https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/commit/?h=devfreq-next&id=252ef98ed524612667e2e2a0ce065fe21e80ec93

Thanks.
Kuninori Morimoto Dec. 13, 2019, 5:09 a.m. UTC | #2
Hi Chanwoo

> > Compile-testing the new driver on platforms without CONFIG_COMMON_CLK
> > leads to a link error:
> > 
> > 	drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
> > 	tegra30-devfreq.c:(.text+0x288): undefined reference to `clk_set_min_rate'
> > 
> > Add a dependency on COMMON_CLK to avoid this.
> > 
> > Fixes: 35f8dbc727212 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver")
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
(snip)
> Thanks for the fixup.
> 
> But, it was merged as following:
> - https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/commit/?h=devfreq-next&id=252ef98ed524612667e2e2a0ce065fe21e80ec93

Thanks, nice to know !!


Thank you for your help !!
Best regards
---
Kuninori Morimoto
Kuninori Morimoto Dec. 17, 2019, 5:12 a.m. UTC | #3
Hi Chanwoo again

> > > Compile-testing the new driver on platforms without CONFIG_COMMON_CLK
> > > leads to a link error:
> > > 
> > > 	drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
> > > 	tegra30-devfreq.c:(.text+0x288): undefined reference to `clk_set_min_rate'
> > > 
> > > Add a dependency on COMMON_CLK to avoid this.
> > > 
> > > Fixes: 35f8dbc727212 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver")
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> (snip)
> > Thanks for the fixup.
> > 
> > But, it was merged as following:
> > - https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/commit/?h=devfreq-next&id=252ef98ed524612667e2e2a0ce065fe21e80ec93

It is for v5.6 ?
SH needs it for v5.5-rcX

Thank you for your help !!
Best regards
---
Kuninori Morimoto
diff mbox series

Patch

diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index defe1d4..a78191c 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -94,6 +94,7 @@  config ARM_EXYNOS_BUS_DEVFREQ
 
 config ARM_TEGRA_DEVFREQ
 	tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
+	depends on COMMON_CLK
 	depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
 		ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
 		ARCH_TEGRA_210_SOC || \