| Message ID | 9796f8e752c4de94b0939e4512bc646a5e72fc32.1697694811.git.quic_varada@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Enable cpufreq for IPQ5332 & IPQ9574 | expand |
On Thu, 19 Oct 2023 at 11:42, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > The config IPQ_APSS_6018 should depend on QCOM_SMEM, to > avoid the following error. Which error? > > Fixes: 5e77b4ef1b19 ("clk: qcom: Add ipq6018 apss clock controller") > Reported-by: kernel test robot <yujie.liu@intel.com> > Closes: https://lore.kernel.org/r/202310181650.g8THtfsm-lkp@intel.com/ > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > drivers/clk/qcom/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index 3194c8b..ad1acd9 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -131,6 +131,7 @@ config IPQ_APSS_6018 > tristate "IPQ APSS Clock Controller" > select IPQ_APSS_PLL > depends on QCOM_APCS_IPC || COMPILE_TEST > + depends on QCOM_SMEM > help > Support for APSS clock controller on IPQ platforms. The > APSS clock controller manages the Mux and enable block that feeds the > -- > 2.7.4 >
On Thu, Oct 19, 2023 at 04:12:25PM +0300, Dmitry Baryshkov wrote: > On Thu, 19 Oct 2023 at 11:42, Varadarajan Narayanan > <quic_varada@quicinc.com> wrote: > > > > The config IPQ_APSS_6018 should depend on QCOM_SMEM, to > > avoid the following error. > > Which error? Sorry. I assumed that it would refer to the info mentioned in the 'Reported-by' & 'Closes' tags. Have included the error message in the commit log, addressed other comments and posted v5. Kindly take a look. Thanks Varada > > Fixes: 5e77b4ef1b19 ("clk: qcom: Add ipq6018 apss clock controller") > > Reported-by: kernel test robot <yujie.liu@intel.com> > > Closes: https://lore.kernel.org/r/202310181650.g8THtfsm-lkp@intel.com/ > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > drivers/clk/qcom/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > > index 3194c8b..ad1acd9 100644 > > --- a/drivers/clk/qcom/Kconfig > > +++ b/drivers/clk/qcom/Kconfig > > @@ -131,6 +131,7 @@ config IPQ_APSS_6018 > > tristate "IPQ APSS Clock Controller" > > select IPQ_APSS_PLL > > depends on QCOM_APCS_IPC || COMPILE_TEST > > + depends on QCOM_SMEM > > help > > Support for APSS clock controller on IPQ platforms. The > > APSS clock controller manages the Mux and enable block that feeds the > > -- > > 2.7.4 > > > > > -- > With best wishes > Dmitry
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig index 3194c8b..ad1acd9 100644 --- a/drivers/clk/qcom/Kconfig +++ b/drivers/clk/qcom/Kconfig @@ -131,6 +131,7 @@ config IPQ_APSS_6018 tristate "IPQ APSS Clock Controller" select IPQ_APSS_PLL depends on QCOM_APCS_IPC || COMPILE_TEST + depends on QCOM_SMEM help Support for APSS clock controller on IPQ platforms. The APSS clock controller manages the Mux and enable block that feeds the
The config IPQ_APSS_6018 should depend on QCOM_SMEM, to avoid the following error. Fixes: 5e77b4ef1b19 ("clk: qcom: Add ipq6018 apss clock controller") Reported-by: kernel test robot <yujie.liu@intel.com> Closes: https://lore.kernel.org/r/202310181650.g8THtfsm-lkp@intel.com/ Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- drivers/clk/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+)