From patchwork Tue Mar 13 11:20:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Whitehead X-Patchwork-Id: 10278213 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5ED1460231 for ; Tue, 13 Mar 2018 11:20:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 50B2828F4D for ; Tue, 13 Mar 2018 11:20:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 45B4C28F6A; Tue, 13 Mar 2018 11:20:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3699F28F4D for ; Tue, 13 Mar 2018 11:20:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932503AbeCMLUm (ORCPT ); Tue, 13 Mar 2018 07:20:42 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:43196 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752411AbeCMLUm (ORCPT ); Tue, 13 Mar 2018 07:20:42 -0400 Received: by mail-io0-f195.google.com with SMTP id l12so15261489ioc.10; Tue, 13 Mar 2018 04:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:reply-to:from:date:message-id:subject:to; bh=Q5OL2ZwahxHqWya+3dpXRkhy6S5K0e+aYsXIhHsgpNc=; b=Mr1eW3R+CSVjBVHsxQqc7d/dgEJpA5WMlMnqgpLh5Nwyr+jFjwVn9PIeDhGFVkAN7m sYjiFB7BFAgFDgtdHCHXyCB/wVhZF+D1wZiLBUgcelbzSkas46V0l5+0eha2zSS1v7Ku Z4ZJBaJFLR/V3wo8e78y5h9V58HJv3CIld/kXFscDvaxVMeHhInIOhk3PY+ivwSvg9Sc jX/sDe4b9OL+o4jX+08iWyhglrL3psVbZ5sg/OAB3EzRHbhT9PxjFmf0rz1b8rWbDokt nvlA9COaqp9d6mkCxd2P6+ewCDRZQp1nd/z8BaqUIv6dVq06pF81LZ2slwJ5v7t/ka3L ye2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:from:date:message-id :subject:to; bh=Q5OL2ZwahxHqWya+3dpXRkhy6S5K0e+aYsXIhHsgpNc=; b=nKbLY8PB7r4Wmp3P18IAHfbtQrshJdlMet+0+ZWVHWwFE/NGw/wg28IZTUop4SP+7e nyHaehtzd4YCqu2jb7gkMKWf7Jbfa7bcP9ilBL78sKJVBsWCO6w3Mn8o3QGJC40s0RFd wzujHm7Prmao2siZO6MX36GW3azo9B3dDF99x7OmLknXfx6IfvKlI1PbbIvMCOf7qa6+ PNYcns/E7LX3itudyUEhL9D0OdluODmmQE8nJysrfaMsCBurcsEhkQaqfi+WFalNJOgk 44qkLjrfBs3QJT0xPB+Y/SqIbM4sgQDozHu5sXnjw/PLfQPmCNo9FxZFdH/cAogtxNYA jT/w== X-Gm-Message-State: AElRT7HJj6LdZq2vkD2b6Jkf8UO7LUS1Nub0MBgdX4jtdPYa6Dylixlc q2y2t9i2PuMJp9u3WW7Pm/WMwqE5eckvVlnze1Hq X-Google-Smtp-Source: AG47ELvtJKmxkVttmMZD1UjHAunW2A4yLcvefBuW4pcSkHpnco9fRwKYRL1fMJMJ+O/1QlbjVAjfCKubQr92lana0b4= X-Received: by 10.107.162.84 with SMTP id l81mr267839ioe.2.1520940040690; Tue, 13 Mar 2018 04:20:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.163.198 with HTTP; Tue, 13 Mar 2018 04:20:19 -0700 (PDT) Reply-To: whiteheadm@acm.org From: tedheadster Date: Tue, 13 Mar 2018 07:20:19 -0400 Message-ID: Subject: x86 : Kconfig : INTEL_PMC_CORE not specific enough To: linux-clk@vger.kernel.org, platform-driver-x86@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, rajneesh.bhardwaj@intel.com, vishwanath.somayaji@intel.com, irina.tirdea@intel.com Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Intel PMC Core and CLK API teams, I am trying to build a minimal kernel config on old regression-testing hardware. Presently there is the following drivers/platform/x86/Kconfig item: config PMC_ATOM def_bool y depends on PCI select COMMON_CLK This creates a cascade of Kconfig "select" statements and pulls in two files: drivers/clk/x86/clk-pmc-atom.c drivers/platform/x86/intel_pmc_core.c The Kconfig seems too general to me. Compiling for my i586 Pentium-I pulls in these files (I think) unnecessarily. Why does _anybody_ with a PCI bus need these ATOM-specific files? Would this change (or something similar) make sense? diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index d10ffe5..6a026fa 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1217,5 +1217,5 @@ endif # X86_PLATFORM_DEVICES config PMC_ATOM def_bool y - depends on PCI + depends on PCI && MATOM select COMMON_CLK