| Message ID | 1574235842-7930-1-git-send-email-kalyani.akula@xilinx.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add Xilinx's ZynqMP AES-GCM driver support | expand |
Hi Herbert, Any review comments on below patch set. Regards, Kalyani > -----Original Message----- > From: Kalyani Akula <kalyani.akula@xilinx.com> > Sent: Wednesday, November 20, 2019 1:14 PM > To: linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: git <git@xilinx.com>; Harsh Jain <harshj@xilinx.com>; Sarat Chand > Savitala <saratcha@xilinx.com>; Mohan Marutirao Dhanawade > <mohand@xilinx.com>; Kalyani Akula <kalyania@xilinx.com>; Kalyani Akula > <kalyania@xilinx.com> > Subject: [PATCH V4 0/4] Add Xilinx's ZynqMP AES-GCM driver support > > This patch set adds support for > - dt-binding docs for Xilinx ZynqMP AES driver > - Adds device tree node for ZynqMP AES driver > - Adds communication layer support for aes in zynqmp.c > - Adds Xilinx ZynqMP driver for AES Algorithm > > V4 Changes : > - Addressed review comments. > > V3 Changes : > - Added software fallback in cases where HW doesnt have the capability to > handle the request. > - Removed use of global variable for storing the driver data. > - Enabled CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y and executed all > the kernel selftests. Also covered tests with tcrypt module. > > V2 Changes : > - Converted RFC PATCH to PATCH > - Removed ALG_SET_KEY_TYPE that was added to support keytype > attribute. Taken using setkey interface. > - Removed deprecated BLKCIPHER in Kconfig > - Erased Key/IV from the buffer. > - Renamed zynqmp-aes driver to zynqmp-aes-gcm. > - Addressed few other review comments > > > Kalyani Akula (4): > dt-bindings: crypto: Add bindings for ZynqMP AES driver > ARM64: zynqmp: Add Xilinix AES node. > firmware: xilinx: Add ZynqMP aes API for AES functionality > crypto: Add Xilinx AES driver > > .../devicetree/bindings/crypto/xlnx,zynqmp-aes.txt | 12 + > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 5 + > drivers/crypto/Kconfig | 11 + > drivers/crypto/Makefile | 1 + > drivers/crypto/xilinx/Makefile | 3 + > drivers/crypto/xilinx/zynqmp-aes-gcm.c | 469 > +++++++++++++++++++++ > drivers/firmware/xilinx/zynqmp.c | 23 + > include/linux/firmware/xlnx-zynqmp.h | 2 + > 8 files changed, 526 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/crypto/xlnx,zynqmp-aes.txt > create mode 100644 drivers/crypto/xilinx/Makefile create mode 100644 > drivers/crypto/xilinx/zynqmp-aes-gcm.c > > -- > 1.9.5
On Mon, Jan 20, 2020 at 06:59:22AM +0000, Kalyani Akula wrote: > Hi Herbert, > > Any review comments on below patch set. Please resubmit your patch series once you have acks for the non-crypto bits ready. Please also state how you want it to be merged, i.e., whether only the crypto patch is meant for the crypto tree or whether it needs to go in as a whole. Thanks,
Hi Herbert, On 20. 01. 20 8:55, Herbert Xu wrote: > On Mon, Jan 20, 2020 at 06:59:22AM +0000, Kalyani Akula wrote: >> Hi Herbert, >> >> Any review comments on below patch set. > > Please resubmit your patch series once you have acks for the > non-crypto bits ready. Please also state how you want it to > be merged, i.e., whether only the crypto patch is meant for > the crypto tree or whether it needs to go in as a whole. All these drivers which requires firmware interface extension can be added via your tree or I can take them via arm-soc tree with your ack. It is really up to you. I am happy to just ack patches out of crypto and feel free to take them via your tree. Or please let me know when you are done with review and I will take them. Kalyani: Please fix that stuff I have reported and we are waiting for v5. Thanks, Michal
On Tue, Jan 21, 2020 at 10:26:07AM +0100, Michal Simek wrote: > > All these drivers which requires firmware interface extension can be > added via your tree or I can take them via arm-soc tree with your ack. > > It is really up to you. I am happy to just ack patches out of crypto and > feel free to take them via your tree. > Or please let me know when you are done with review and I will take them. Thanks Michal. If you could ack them once they've been resubmitted then I can just take them via the cryptodev tree. Thanks,
On 22. 01. 20 6:51, Herbert Xu wrote: > On Tue, Jan 21, 2020 at 10:26:07AM +0100, Michal Simek wrote: >> >> All these drivers which requires firmware interface extension can be >> added via your tree or I can take them via arm-soc tree with your ack. >> >> It is really up to you. I am happy to just ack patches out of crypto and >> feel free to take them via your tree. >> Or please let me know when you are done with review and I will take them. > > Thanks Michal. If you could ack them once they've been resubmitted > then I can just take them via the cryptodev tree. Great. Michal