mbox series

[v2,0/7] crypto: fixes in preparation of new fuzz tests

Message ID 20190410064635.11813-1-ebiggers@kernel.org (mailing list archive)
Headers show
Series crypto: fixes in preparation of new fuzz tests | expand

Message

Eric Biggers April 10, 2019, 6:46 a.m. UTC
This series contains the remaining fixes in preparation of the
comparison fuzz tests I've proposed in the series
"crypto: fuzz algorithms against their generic implementation".

I will send a new version of the testmgr patches separately.

These fixes and my latest tests can also be retrieved from git at:

	Repository: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git
	Branch: cryptofuzz-vs-generic

Eric Biggers (7):
  crypto: lrw - don't access already-freed walk.iv
  crypto: salsa20 - don't access already-freed walk.iv
  crypto: arm/aes-neonbs - don't access already-freed walk.iv
  crypto: arm64/aes-neonbs - don't access already-freed walk.iv
  crypto: gcm - fix incompatibility between "gcm" and "gcm_base"
  crypto: ccm - fix incompatibility between "ccm" and "ccm_base"
  crypto: vmx - return correct error code on failed setkey

 arch/arm/crypto/aes-neonbs-glue.c   |  2 ++
 arch/arm64/crypto/aes-neonbs-glue.c |  2 ++
 crypto/ccm.c                        | 43 ++++++++++++-----------------
 crypto/gcm.c                        | 32 ++++++---------------
 crypto/lrw.c                        |  4 ++-
 crypto/salsa20_generic.c            |  2 +-
 drivers/crypto/vmx/aes.c            |  7 +++--
 drivers/crypto/vmx/aes_cbc.c        |  7 +++--
 drivers/crypto/vmx/aes_ctr.c        |  5 ++--
 drivers/crypto/vmx/aes_xts.c        |  9 +++---
 10 files changed, 50 insertions(+), 63 deletions(-)

Comments

Ard Biesheuvel April 10, 2019, 6:08 p.m. UTC | #1
On Tue, 9 Apr 2019 at 23:48, Eric Biggers <ebiggers@kernel.org> wrote:
>
> This series contains the remaining fixes in preparation of the
> comparison fuzz tests I've proposed in the series
> "crypto: fuzz algorithms against their generic implementation".
>
> I will send a new version of the testmgr patches separately.
>
> These fixes and my latest tests can also be retrieved from git at:
>
>         Repository: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git
>         Branch: cryptofuzz-vs-generic
>
> Eric Biggers (7):
>   crypto: lrw - don't access already-freed walk.iv
>   crypto: salsa20 - don't access already-freed walk.iv
>   crypto: arm/aes-neonbs - don't access already-freed walk.iv
>   crypto: arm64/aes-neonbs - don't access already-freed walk.iv
>   crypto: gcm - fix incompatibility between "gcm" and "gcm_base"
>   crypto: ccm - fix incompatibility between "ccm" and "ccm_base"
>   crypto: vmx - return correct error code on failed setkey
>

For the series

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

>  arch/arm/crypto/aes-neonbs-glue.c   |  2 ++
>  arch/arm64/crypto/aes-neonbs-glue.c |  2 ++
>  crypto/ccm.c                        | 43 ++++++++++++-----------------
>  crypto/gcm.c                        | 32 ++++++---------------
>  crypto/lrw.c                        |  4 ++-
>  crypto/salsa20_generic.c            |  2 +-
>  drivers/crypto/vmx/aes.c            |  7 +++--
>  drivers/crypto/vmx/aes_cbc.c        |  7 +++--
>  drivers/crypto/vmx/aes_ctr.c        |  5 ++--
>  drivers/crypto/vmx/aes_xts.c        |  9 +++---
>  10 files changed, 50 insertions(+), 63 deletions(-)
>
> --
> 2.21.0
>
Herbert Xu April 18, 2019, 2:24 p.m. UTC | #2
Eric Biggers <ebiggers@kernel.org> wrote:
> This series contains the remaining fixes in preparation of the
> comparison fuzz tests I've proposed in the series
> "crypto: fuzz algorithms against their generic implementation".
> 
> I will send a new version of the testmgr patches separately.
> 
> These fixes and my latest tests can also be retrieved from git at:
> 
>        Repository: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git
>        Branch: cryptofuzz-vs-generic
> 
> Eric Biggers (7):
>  crypto: lrw - don't access already-freed walk.iv
>  crypto: salsa20 - don't access already-freed walk.iv
>  crypto: arm/aes-neonbs - don't access already-freed walk.iv
>  crypto: arm64/aes-neonbs - don't access already-freed walk.iv
>  crypto: gcm - fix incompatibility between "gcm" and "gcm_base"
>  crypto: ccm - fix incompatibility between "ccm" and "ccm_base"
>  crypto: vmx - return correct error code on failed setkey
> 
> arch/arm/crypto/aes-neonbs-glue.c   |  2 ++
> arch/arm64/crypto/aes-neonbs-glue.c |  2 ++
> crypto/ccm.c                        | 43 ++++++++++++-----------------
> crypto/gcm.c                        | 32 ++++++---------------
> crypto/lrw.c                        |  4 ++-
> crypto/salsa20_generic.c            |  2 +-
> drivers/crypto/vmx/aes.c            |  7 +++--
> drivers/crypto/vmx/aes_cbc.c        |  7 +++--
> drivers/crypto/vmx/aes_ctr.c        |  5 ++--
> drivers/crypto/vmx/aes_xts.c        |  9 +++---
> 10 files changed, 50 insertions(+), 63 deletions(-)

Patches 1-4 and 7 applied.  Thanks.