[v2,0/3] crypto: shash - Enforce descsize limit in init_tfm

Message

Herbert Xu Dec. 8, 2019, 5:42 a.m. UTC

As it stands we only enforce descsize limits when an algorithm is
registered.  However, as descsize is dynamic and may be set at
init_tfm time this is not enough.  This is why hmac has its own
descsize check.

This series adds descsize limit enforcement at init_tfm time so
that the API takes over the responsibility of checking descsize
after the algorithm's init_tfm has completed.

v2 addresses the issues raised during review, including adding
a WARN_ON_ONCE to crypto_shash_init_tfm.

Thanks,

Comments

Eric Biggers Dec. 11, 2019, 3:32 a.m. UTC | #1

On Sun, Dec 08, 2019 at 01:42:29PM +0800, Herbert Xu wrote:
> As it stands we only enforce descsize limits when an algorithm is
> registered.  However, as descsize is dynamic and may be set at
> init_tfm time this is not enough.  This is why hmac has its own
> descsize check.
> 
> This series adds descsize limit enforcement at init_tfm time so
> that the API takes over the responsibility of checking descsize
> after the algorithm's init_tfm has completed.
> 
> v2 addresses the issues raised during review, including adding
> a WARN_ON_ONCE to crypto_shash_init_tfm.
> 
> Thanks,

I left some nits on patches 1 and 2, but not too important.  Feel free to add:

Reviewed-by: Eric Biggers <[e-mail]>

Herbert Xu Dec. 11, 2019, 8:30 a.m. UTC | #2

On Tue, Dec 10, 2019 at 07:32:11PM -0800, Eric Biggers wrote:
>
> I left some nits on patches 1 and 2, but not too important.  Feel free to add:
> 
> Reviewed-by: Eric Biggers <[e-mail]>

Thanks.  I've added your suggestions as well as your review tag.