mbox series

[0/3] crypto: AEAD fuzz tests and doc improvement

Message ID 20200304224405.152829-1-ebiggers@kernel.org (mailing list archive)
Headers show
Series crypto: AEAD fuzz tests and doc improvement | expand

Message

Eric Biggers March 4, 2020, 10:44 p.m. UTC 
- Make the AEAD fuzz tests avoid implementation-defined behavior for
  rfc4106, rfc4309, rfc4543, and rfc7539esp.  This replaces
  "[PATCH v2] crypto: testmgr - sync both RFC4106 IV copies"

- Adjust the order of the AEAD fuzz tests to be more logical.

- Improve the documentation for the AEAD scatterlist layout.

(I was also going to add a patch that makes the inauthentic AEAD tests
start mutating the IVs, but it turns out that "ccm" needs special
handling so I've left that for later.)

Eric Biggers (3):
  crypto: testmgr - use consistent IV copies for AEADs that need it
  crypto: testmgr - do comparison tests before inauthentic input tests
  crypto: aead - improve documentation for scatterlist layout

 crypto/testmgr.c      | 28 +++++++++++++++----------
 include/crypto/aead.h | 48 ++++++++++++++++++++++++-------------------
 2 files changed, 44 insertions(+), 32 deletions(-)

Comments

Gilad Ben-Yossef March 8, 2020, 2:44 p.m. UTC | #1 
On Thu, Mar 5, 2020 at 12:44 AM Eric Biggers <ebiggers@kernel.org> wrote:
>
> - Make the AEAD fuzz tests avoid implementation-defined behavior for
>   rfc4106, rfc4309, rfc4543, and rfc7539esp.  This replaces
>   "[PATCH v2] crypto: testmgr - sync both RFC4106 IV copies"
>
> - Adjust the order of the AEAD fuzz tests to be more logical.
>
> - Improve the documentation for the AEAD scatterlist layout.
>
> (I was also going to add a patch that makes the inauthentic AEAD tests
> start mutating the IVs, but it turns out that "ccm" needs special
> handling so I've left that for later.)

For the whole series:
Tested-by: Gilad Ben-Yossef <gilad@benyossef.com>

Thank you Eric!
Gilad

>
> Eric Biggers (3):
>   crypto: testmgr - use consistent IV copies for AEADs that need it
>   crypto: testmgr - do comparison tests before inauthentic input tests
>   crypto: aead - improve documentation for scatterlist layout
>
>  crypto/testmgr.c      | 28 +++++++++++++++----------
>  include/crypto/aead.h | 48 ++++++++++++++++++++++++-------------------
>  2 files changed, 44 insertions(+), 32 deletions(-)
>
> --
> 2.25.1
>