| Message ID | 20200319161233.8134-1-andrew.smirnov@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | enable CAAM's HWRNG as default | expand |
On 3/19/2020 6:12 PM, Andrey Smirnov wrote: > Everyone: > > This series is a continuation of original [discussion]. I don't know > if what's in the series is enough to use CAAMs HWRNG system wide, but > I am hoping that with enough iterations and feedback it will be. > Andrey, thanks for the effort! Herbert, Greg, I hope it's ok to go with the fsl-mc bus dependency "bus: fsl-mc: add api to retrieve mc version" https://patchwork.kernel.org/patch/11447637/ included in this series through cryptodev-2.6 tree. It applies cleanly on latest linux-next (next-20200320), and it has been Acked-by Laurențiu (one of the fsl-mc bus maintainers). Thank you, Horia [...] > > Andrei Botila (1): > bus: fsl-mc: add api to retrieve mc version > > Andrey Smirnov (8): > crypto: caam - allocate RNG instantiation descriptor with GFP_DMA > crypto: caam - use struct hwrng's .init for initialization > crypto: caam - drop global context pointer and init_done > crypto: caam - simplify RNG implementation > crypto: caam - check if RNG job failed > crypto: caam - invalidate entropy register during RNG initialization > crypto: caam - enable prediction resistance in HRWNG > crypto: caam - limit single JD RNG output to maximum of 16 bytes > > drivers/bus/fsl-mc/fsl-mc-bus.c | 33 +-- > drivers/crypto/caam/Kconfig | 1 + > drivers/crypto/caam/caamrng.c | 405 ++++++++++++-------------------- > drivers/crypto/caam/ctrl.c | 88 +++++-- > drivers/crypto/caam/desc.h | 2 + > drivers/crypto/caam/intern.h | 7 +- > drivers/crypto/caam/jr.c | 13 +- > drivers/crypto/caam/regs.h | 7 +- > include/linux/fsl/mc.h | 16 ++ > 9 files changed, 276 insertions(+), 296 deletions(-) >
On Fri, Mar 20, 2020 at 06:13:18PM +0200, Horia Geantă wrote: > On 3/19/2020 6:12 PM, Andrey Smirnov wrote: > > Everyone: > > > > This series is a continuation of original [discussion]. I don't know > > if what's in the series is enough to use CAAMs HWRNG system wide, but > > I am hoping that with enough iterations and feedback it will be. > > > Andrey, thanks for the effort! > > Herbert, Greg, > > I hope it's ok to go with the fsl-mc bus dependency > "bus: fsl-mc: add api to retrieve mc version" > https://patchwork.kernel.org/patch/11447637/ > included in this series through cryptodev-2.6 tree. > > It applies cleanly on latest linux-next (next-20200320), > and it has been Acked-by Laurențiu (one of the fsl-mc bus maintainers). No objection from me. greg k-h
On Thu, Mar 19, 2020 at 09:12:24AM -0700, Andrey Smirnov wrote: > Everyone: > > This series is a continuation of original [discussion]. I don't know > if what's in the series is enough to use CAAMs HWRNG system wide, but > I am hoping that with enough iterations and feedback it will be. > > Changes since [v1]: > > - Original hw_random replaced with the one using output of TRNG directly > > - SEC4 DRNG IP block exposed via crypto API > > - Small fix regarding use of GFP_DMA added to the series > > Chagnes since [v2]: > > - msleep in polling loop to avoid wasting CPU cycles > > - caam_trng_read() bails out early if 'wait' is set to 'false' > > - fixed typo in ZII's name > > Changes since [v3]: > > - DRNG's .cra_name is now "stdrng" > > - collected Reviewd-by tag from Lucas > > - typo fixes in commit messages of the series > > Changes since [v4]: > > - Dropped "crypto: caam - RNG4 TRNG errata" and "crypto: caam - > enable prediction resistance in HRWNG" to limit the scope of the > series. Those two patches are not yet ready and can be submitted > separately later. > > - Collected Tested-by from Chris > > Changes since [v5]: > > - Series is converted back to implementing HWRNG using a job ring > as per feedback from Horia. > > Changes since [v6]: > > - "crypto: caam - drop global context pointer and init_done" > changed to use devres group to allow freeing HWRNG resource > independently of the parent device lifecycle. Code to deal with > circular deallocation dependency is added as well > > - Removed worker self-scheduling in "crypto: caam - simplify RNG > implementation". It didn't bring much value, but meant that > simple cleanup with just a call to flush_work() wasn't good > enough. > > - Added a simple function with a FIXME item for MC firmware check in > "crypto: caam - enable prediction resistance in HRWNG" > > - "crypto: caam - limit single JD RNG output to maximum of 16 > bytes" now shrinks async FIFO size from 32K to 64 bytes, since > having a buffer that big doesn't seem to do any good given that > througput of TRNG > > Changes since [v7]: > > - Collected Reviewd-bys from Horia > > - updated "crypto: caam - simplify RNG implementation" to drop > custom type and fix comments > > - updated "crypto: caam - enable prediction resistance in HRWNG" > to integrate code from Andrei Botila > > - updated "crypto: caam - drop global context pointer and > init_done" to use .priv instead of container_of for private data > pointer > > Changes since [v8] > > - Collected more Reviewd-bys from Horia > > - Pulled "bus: fsl-mc: add api to retrieve mc version" into the set_ > > - Moved RNG quality setting back to "crypto: caam - limit single > JD RNG output to maximum of 16 bytes" where it belongs > > - Fixed comparison and checkpatch warnings in "crypto: caam - > enable prediction resistance in HRWNG" per feedback from Horia > > > Feedback is welcome! > > Thanks, > Andrey Smirnov > > [discussion] https://patchwork.kernel.org/patch/9850669/ > [v1] https://lore.kernel.org/lkml/20191029162916.26579-1-andrew.smirnov@gmail.com > [v2] https://lore.kernel.org/lkml/20191118153843.28136-1-andrew.smirnov@gmail.com > [v3] https://lore.kernel.org/lkml/20191120165341.32669-1-andrew.smirnov@gmail.com > [v4] https://lore.kernel.org/lkml/20191121155554.1227-1-andrew.smirnov@gmail.com > [v5] https://lore.kernel.org/lkml/20191203162357.21942-1-andrew.smirnov@gmail.com > [v6] https://lore.kernel.org/lkml/20200108154047.12526-1-andrew.smirnov@gmail.com > [v7] https://lore.kernel.org/lkml/20200127165646.19806-1-andrew.smirnov@gmail.com > [v8] https://lore.kernel.org/lkml/20200316150047.30828-1-andrew.smirnov@gmail.com > > Andrei Botila (1): > bus: fsl-mc: add api to retrieve mc version > > Andrey Smirnov (8): > crypto: caam - allocate RNG instantiation descriptor with GFP_DMA > crypto: caam - use struct hwrng's .init for initialization > crypto: caam - drop global context pointer and init_done > crypto: caam - simplify RNG implementation > crypto: caam - check if RNG job failed > crypto: caam - invalidate entropy register during RNG initialization > crypto: caam - enable prediction resistance in HRWNG > crypto: caam - limit single JD RNG output to maximum of 16 bytes > > drivers/bus/fsl-mc/fsl-mc-bus.c | 33 +-- > drivers/crypto/caam/Kconfig | 1 + > drivers/crypto/caam/caamrng.c | 405 ++++++++++++-------------------- > drivers/crypto/caam/ctrl.c | 88 +++++-- > drivers/crypto/caam/desc.h | 2 + > drivers/crypto/caam/intern.h | 7 +- > drivers/crypto/caam/jr.c | 13 +- > drivers/crypto/caam/regs.h | 7 +- > include/linux/fsl/mc.h | 16 ++ > 9 files changed, 276 insertions(+), 296 deletions(-) All applied. Thanks.
Everyone: This series is a continuation of original [discussion]. I don't know if what's in the series is enough to use CAAMs HWRNG system wide, but I am hoping that with enough iterations and feedback it will be. Changes since [v1]: - Original hw_random replaced with the one using output of TRNG directly - SEC4 DRNG IP block exposed via crypto API - Small fix regarding use of GFP_DMA added to the series Chagnes since [v2]: - msleep in polling loop to avoid wasting CPU cycles - caam_trng_read() bails out early if 'wait' is set to 'false' - fixed typo in ZII's name Changes since [v3]: - DRNG's .cra_name is now "stdrng" - collected Reviewd-by tag from Lucas - typo fixes in commit messages of the series Changes since [v4]: - Dropped "crypto: caam - RNG4 TRNG errata" and "crypto: caam - enable prediction resistance in HRWNG" to limit the scope of the series. Those two patches are not yet ready and can be submitted separately later. - Collected Tested-by from Chris Changes since [v5]: - Series is converted back to implementing HWRNG using a job ring as per feedback from Horia. Changes since [v6]: - "crypto: caam - drop global context pointer and init_done" changed to use devres group to allow freeing HWRNG resource independently of the parent device lifecycle. Code to deal with circular deallocation dependency is added as well - Removed worker self-scheduling in "crypto: caam - simplify RNG implementation". It didn't bring much value, but meant that simple cleanup with just a call to flush_work() wasn't good enough. - Added a simple function with a FIXME item for MC firmware check in "crypto: caam - enable prediction resistance in HRWNG" - "crypto: caam - limit single JD RNG output to maximum of 16 bytes" now shrinks async FIFO size from 32K to 64 bytes, since having a buffer that big doesn't seem to do any good given that througput of TRNG Changes since [v7]: - Collected Reviewd-bys from Horia - updated "crypto: caam - simplify RNG implementation" to drop custom type and fix comments - updated "crypto: caam - enable prediction resistance in HRWNG" to integrate code from Andrei Botila - updated "crypto: caam - drop global context pointer and init_done" to use .priv instead of container_of for private data pointer Changes since [v8] - Collected more Reviewd-bys from Horia - Pulled "bus: fsl-mc: add api to retrieve mc version" into the set_ - Moved RNG quality setting back to "crypto: caam - limit single JD RNG output to maximum of 16 bytes" where it belongs - Fixed comparison and checkpatch warnings in "crypto: caam - enable prediction resistance in HRWNG" per feedback from Horia Feedback is welcome! Thanks, Andrey Smirnov [discussion] https://patchwork.kernel.org/patch/9850669/ [v1] https://lore.kernel.org/lkml/20191029162916.26579-1-andrew.smirnov@gmail.com [v2] https://lore.kernel.org/lkml/20191118153843.28136-1-andrew.smirnov@gmail.com [v3] https://lore.kernel.org/lkml/20191120165341.32669-1-andrew.smirnov@gmail.com [v4] https://lore.kernel.org/lkml/20191121155554.1227-1-andrew.smirnov@gmail.com [v5] https://lore.kernel.org/lkml/20191203162357.21942-1-andrew.smirnov@gmail.com [v6] https://lore.kernel.org/lkml/20200108154047.12526-1-andrew.smirnov@gmail.com [v7] https://lore.kernel.org/lkml/20200127165646.19806-1-andrew.smirnov@gmail.com [v8] https://lore.kernel.org/lkml/20200316150047.30828-1-andrew.smirnov@gmail.com Andrei Botila (1): bus: fsl-mc: add api to retrieve mc version Andrey Smirnov (8): crypto: caam - allocate RNG instantiation descriptor with GFP_DMA crypto: caam - use struct hwrng's .init for initialization crypto: caam - drop global context pointer and init_done crypto: caam - simplify RNG implementation crypto: caam - check if RNG job failed crypto: caam - invalidate entropy register during RNG initialization crypto: caam - enable prediction resistance in HRWNG crypto: caam - limit single JD RNG output to maximum of 16 bytes drivers/bus/fsl-mc/fsl-mc-bus.c | 33 +-- drivers/crypto/caam/Kconfig | 1 + drivers/crypto/caam/caamrng.c | 405 ++++++++++++-------------------- drivers/crypto/caam/ctrl.c | 88 +++++-- drivers/crypto/caam/desc.h | 2 + drivers/crypto/caam/intern.h | 7 +- drivers/crypto/caam/jr.c | 13 +- drivers/crypto/caam/regs.h | 7 +- include/linux/fsl/mc.h | 16 ++ 9 files changed, 276 insertions(+), 296 deletions(-) -- 2.21.0