mbox series

[v3,0/31] crypto: skcipher - Add support for no chaining and partial chaining

Message ID 20200728071746.GA22352@gondor.apana.org.au (mailing list archive)
Headers show
Series crypto: skcipher - Add support for no chaining and partial chaining | expand

Message

Herbert Xu July 28, 2020, 7:17 a.m. UTC 
This patch-set adds support to the Crypto API and algif_skcipher
for algorithms that cannot be chained, as well as ones that can
be chained if you withhold a certain number of blocks at the end.

The vast majority of algorithms can be chained already, e.g., cbc
and lrw.  Everything else can either be modified to support chaining,
e.g., chacha and xts, or they cannot chain at all, e.g., keywrap.

Some drivers that implement algorithms which can be chained with
modification may not be able to support chaining due to hardware
limitations.  For now they're treated the same way as ones that
cannot be chained at all.

The algorithm arc4 has been left out of all this owing to ongoing
discussions regarding its future.

Thanks,

Comments

Eric Biggers July 28, 2020, 5:19 p.m. UTC | #1 
On Tue, Jul 28, 2020 at 05:17:46PM +1000, Herbert Xu wrote:
> This patch-set adds support to the Crypto API and algif_skcipher
> for algorithms that cannot be chained, as well as ones that can
> be chained if you withhold a certain number of blocks at the end.
> 
> The vast majority of algorithms can be chained already, e.g., cbc
> and lrw.  Everything else can either be modified to support chaining,
> e.g., chacha and xts, or they cannot chain at all, e.g., keywrap.
> 
> Some drivers that implement algorithms which can be chained with
> modification may not be able to support chaining due to hardware
> limitations.  For now they're treated the same way as ones that
> cannot be chained at all.
> 
> The algorithm arc4 has been left out of all this owing to ongoing
> discussions regarding its future.
> 

Can you elaborate on the use case for supporting chaining on algorithms that
don't currently support it?

Also, the self-tests need to be updated to test all this.

- Eric
Herbert Xu July 29, 2020, 3:40 a.m. UTC | #2 
On Tue, Jul 28, 2020 at 10:19:21AM -0700, Eric Biggers wrote:
>
> Can you elaborate on the use case for supporting chaining on algorithms that
> don't currently support it?

OK I will describe the algif issue in more detail and also add
a mention of sunrpc.  In fact I might try to convert sunrpc to use
this new API.

> Also, the self-tests need to be updated to test all this.

Yes.

Thanks,