mbox series

[v2,0/2] crypto: xor - defer and optimize boot time benchmark

Message ID 20200926102651.31598-1-ardb@kernel.org (mailing list archive)
Headers show
Series crypto: xor - defer and optimize boot time benchmark | expand

Message

Ard Biesheuvel Sept. 26, 2020, 10:26 a.m. UTC 
Doug reports [0] that the XOR boot time benchmark takes more time than
necessary, and runs at a time when there is little room for other
boot time tasks to run concurrently.

Let's fix this by #1 deferring the benchmark, and #2 uses a faster
implementation.

Changes since v2:
- incorporate Doug's review feedback re coarse clocks and the use of pr_info
- add Doug's ack to #1

[0] https://lore.kernel.org/linux-arm-kernel/20200921172603.1.Id9450c1d3deef17718bd5368580a3c44895209ee@changeid/

Cc: Douglas Anderson <dianders@chromium.org>
Cc: David Laight <David.Laight@aculab.com>

Ard Biesheuvel (2):
  crypto: xor - defer load time benchmark to a later time
  crypto: xor - use ktime for template benchmarking

 crypto/xor.c | 67 +++++++++++++-------
 1 file changed, 44 insertions(+), 23 deletions(-)

Comments

Herbert Xu Oct. 2, 2020, 11:55 a.m. UTC | #1 
On Sat, Sep 26, 2020 at 12:26:49PM +0200, Ard Biesheuvel wrote:
> Doug reports [0] that the XOR boot time benchmark takes more time than
> necessary, and runs at a time when there is little room for other
> boot time tasks to run concurrently.
> 
> Let's fix this by #1 deferring the benchmark, and #2 uses a faster
> implementation.
> 
> Changes since v2:
> - incorporate Doug's review feedback re coarse clocks and the use of pr_info
> - add Doug's ack to #1
> 
> [0] https://lore.kernel.org/linux-arm-kernel/20200921172603.1.Id9450c1d3deef17718bd5368580a3c44895209ee@changeid/
> 
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: David Laight <David.Laight@aculab.com>
> 
> Ard Biesheuvel (2):
>   crypto: xor - defer load time benchmark to a later time
>   crypto: xor - use ktime for template benchmarking
> 
>  crypto/xor.c | 67 +++++++++++++-------
>  1 file changed, 44 insertions(+), 23 deletions(-)

All applied.  Thanks.