[4.19,0/2] fix divide zero error in padata_do_parallel()

Message ID	20210803125301.77629-1-yangyingliang@huawei.com (mailing list archive)
Headers	show Return-Path: <linux-crypto-owner@kernel.org> From: Yang Yingliang <yangyingliang@huawei.com> To: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>, <stable@vger.kernel.org> CC: <steffen.klassert@secunet.com>, <daniel.m.jordan@oracle.com>, <herbert@gondor.apana.org.au>, <gregkh@linuxfoundation.org>, <sashal@kernel.org> Subject: [PATCH 4.19 0/2] fix divide zero error in padata_do_parallel() Date: Tue, 3 Aug 2021 20:52:59 +0800 Message-ID: <20210803125301.77629-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII Precedence: bulk
Series	fix divide zero error in padata_do_parallel() \| expand [4.19,0/2] fix divide zero error in padata_do_parallel() [4.19,1/2] padata: validate cpumask without removed CPU during offline [4.19,2/2] padata: add separate cpuhp node for CPUHP_PADATA_DEAD

Message ID

20210803125301.77629-1-yangyingliang@huawei.com (mailing list archive)

Headers

From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
        <stable@vger.kernel.org>
CC: <steffen.klassert@secunet.com>, <daniel.m.jordan@oracle.com>,
        <herbert@gondor.apana.org.au>, <gregkh@linuxfoundation.org>,
        <sashal@kernel.org>
Subject: [PATCH 4.19 0/2] fix divide zero error in padata_do_parallel()
Date: Tue, 3 Aug 2021 20:52:59 +0800
Message-ID: <20210803125301.77629-1-yangyingliang@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

Series

fix divide zero error in padata_do_parallel() | expand

Message

Yang Yingliang Aug. 3, 2021, 12:52 p.m. UTC

It can reproduced by the following commands:

  # modprobe pcrypt
  # echo 2 > /sys/kernel/pcrypt/pencrypt/parallel_cpumask
  # echo 0 > /sys/devices/system/cpu/cpu1/online
  # modprobe tcrypt alg="pcrypt(rfc4106(gcm(aes)))" type=3

[  229.549005] divide error: 0000 [#1] SMP PTI
[  229.549130] CPU: 32 PID: 9565 Comm: cryptomgr_test Kdump: loaded Not tainted 4.19.200 #3
[  229.549381] Hardware name: Huawei 2288H V5/BC11SPSCB0, BIOS 0.68 05/03/2018
[  229.549607] RIP: 0010:padata_do_parallel+0x96/0x150
[  229.549750] Code: 5e 10 89 56 18 f0 0f c1 6b 20 8b 35 78 b1 24 01 48 8b 7b 28 e8 eb d6 20 00 89 c1 8d 45 01 31 d2 8b 35 62 b1 24 01 48 8b 7b 28 <f7> f1 41 89 d7 e8 d0 45 21 00 45 85 ff 41 89 c4 7e 19 31 ed 48 8b
[  229.550335] RSP: 0018:ffffa48b8e1cbbc8 EFLAGS: 00010246
[  229.550498] RAX: 0000000000000000 RBX: ffff964940883bc0 RCX: 0000000000000000
[  229.550720] RDX: 0000000000000000 RSI: 0000000000000038 RDI: ffff9687b6e45650
[  229.550943] RBP: 00000000ffffffff R08: 0000000000000000 R09: ffff96c7af6f6200
[  229.551165] R10: ffff9687b6e45650 R11: ffff968839629000 R12: 0000000000000010
[  229.551388] R13: ffff9687b6997f50 R14: ffff96c7ad84d700 R15: ffffffff9287a220
[  229.551610] FS:  0000000000000000(0000) GS:ffff9687bfc80000(0000) knlGS:0000000000000000
[  229.551863] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  229.552044] CR2: 00007fad13d47564 CR3: 000000759480a004 CR4: 00000000007606e0
[  229.552265] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[  229.552488] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[  229.552710] PKRU: 55555554
[  229.552796] Call Trace:
[  229.552878]  pcrypt_aead_encrypt+0xbb/0xc7 [pcrypt]
[  229.553028]  __test_aead+0x654/0x15d0
[  229.553139]  ? _cond_resched+0x15/0x40
[  229.553257]  ? crypto_create_tfm+0x4e/0xe0
[  229.553385]  ? crypto_spawn_tfm2+0x2e/0x50
[  229.553513]  ? _cond_resched+0x15/0x40
[  229.553632]  ? crypto_acomp_scomp_free_ctx+0x30/0x30
[  229.553786]  test_aead+0x21/0xa0
[  229.553889]  alg_test_aead+0x3f/0xa0
[  229.554001]  alg_test.part.15+0x178/0x380
[  229.554127]  ? __switch_to+0x8c/0x400
[  229.554239]  ? __switch_to_asm+0x41/0x70
[  229.554362]  ? __switch_to_asm+0x35/0x70
[  229.554486]  ? __schedule+0x25d/0x850
[  229.554602]  ? __wake_up_common+0x76/0x170
[  229.554727]  ? crypto_acomp_scomp_free_ctx+0x30/0x30
[  229.554884]  cryptomgr_test+0x40/0x50
[  229.554999]  kthread+0x113/0x130
[  229.555099]  ? kthread_create_worker_on_cpu+0x70/0x70
[  229.555255]  ret_from_fork+0x35/0x40


Daniel Jordan (2):
  padata: validate cpumask without removed CPU during offline
  padata: add separate cpuhp node for CPUHP_PADATA_DEAD

 include/linux/cpuhotplug.h |  1 +
 include/linux/padata.h     |  6 ++++--
 kernel/padata.c            | 28 ++++++++++++++++++++--------
 3 files changed, 25 insertions(+), 10 deletions(-)

Comments

Greg KH Aug. 6, 2021, 6:43 a.m. UTC | #1

On Tue, Aug 03, 2021 at 08:52:59PM +0800, Yang Yingliang wrote:
> It can reproduced by the following commands:
> 
>   # modprobe pcrypt
>   # echo 2 > /sys/kernel/pcrypt/pencrypt/parallel_cpumask
>   # echo 0 > /sys/devices/system/cpu/cpu1/online
>   # modprobe tcrypt alg="pcrypt(rfc4106(gcm(aes)))" type=3
> 
> [  229.549005] divide error: 0000 [#1] SMP PTI
> [  229.549130] CPU: 32 PID: 9565 Comm: cryptomgr_test Kdump: loaded Not tainted 4.19.200 #3
> [  229.549381] Hardware name: Huawei 2288H V5/BC11SPSCB0, BIOS 0.68 05/03/2018
> [  229.549607] RIP: 0010:padata_do_parallel+0x96/0x150
> [  229.549750] Code: 5e 10 89 56 18 f0 0f c1 6b 20 8b 35 78 b1 24 01 48 8b 7b 28 e8 eb d6 20 00 89 c1 8d 45 01 31 d2 8b 35 62 b1 24 01 48 8b 7b 28 <f7> f1 41 89 d7 e8 d0 45 21 00 45 85 ff 41 89 c4 7e 19 31 ed 48 8b
> [  229.550335] RSP: 0018:ffffa48b8e1cbbc8 EFLAGS: 00010246
> [  229.550498] RAX: 0000000000000000 RBX: ffff964940883bc0 RCX: 0000000000000000
> [  229.550720] RDX: 0000000000000000 RSI: 0000000000000038 RDI: ffff9687b6e45650
> [  229.550943] RBP: 00000000ffffffff R08: 0000000000000000 R09: ffff96c7af6f6200
> [  229.551165] R10: ffff9687b6e45650 R11: ffff968839629000 R12: 0000000000000010
> [  229.551388] R13: ffff9687b6997f50 R14: ffff96c7ad84d700 R15: ffffffff9287a220
> [  229.551610] FS:  0000000000000000(0000) GS:ffff9687bfc80000(0000) knlGS:0000000000000000
> [  229.551863] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [  229.552044] CR2: 00007fad13d47564 CR3: 000000759480a004 CR4: 00000000007606e0
> [  229.552265] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [  229.552488] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> [  229.552710] PKRU: 55555554
> [  229.552796] Call Trace:
> [  229.552878]  pcrypt_aead_encrypt+0xbb/0xc7 [pcrypt]
> [  229.553028]  __test_aead+0x654/0x15d0
> [  229.553139]  ? _cond_resched+0x15/0x40
> [  229.553257]  ? crypto_create_tfm+0x4e/0xe0
> [  229.553385]  ? crypto_spawn_tfm2+0x2e/0x50
> [  229.553513]  ? _cond_resched+0x15/0x40
> [  229.553632]  ? crypto_acomp_scomp_free_ctx+0x30/0x30
> [  229.553786]  test_aead+0x21/0xa0
> [  229.553889]  alg_test_aead+0x3f/0xa0
> [  229.554001]  alg_test.part.15+0x178/0x380
> [  229.554127]  ? __switch_to+0x8c/0x400
> [  229.554239]  ? __switch_to_asm+0x41/0x70
> [  229.554362]  ? __switch_to_asm+0x35/0x70
> [  229.554486]  ? __schedule+0x25d/0x850
> [  229.554602]  ? __wake_up_common+0x76/0x170
> [  229.554727]  ? crypto_acomp_scomp_free_ctx+0x30/0x30
> [  229.554884]  cryptomgr_test+0x40/0x50
> [  229.554999]  kthread+0x113/0x130
> [  229.555099]  ? kthread_create_worker_on_cpu+0x70/0x70
> [  229.555255]  ret_from_fork+0x35/0x40
> 
> 
> Daniel Jordan (2):
>   padata: validate cpumask without removed CPU during offline
>   padata: add separate cpuhp node for CPUHP_PADATA_DEAD
> 
>  include/linux/cpuhotplug.h |  1 +
>  include/linux/padata.h     |  6 ++++--
>  kernel/padata.c            | 28 ++++++++++++++++++++--------
>  3 files changed, 25 insertions(+), 10 deletions(-)

All now queued up, thanks!

greg k-h