mbox series

[00/12] crypto: qat - PFVF fixes and refactoring

Message ID 20210928114440.355368-1-giovanni.cabiddu@intel.com (mailing list archive)
Headers show
Series crypto: qat - PFVF fixes and refactoring | expand

Message

Cabiddu, Giovanni Sept. 28, 2021, 11:44 a.m. UTC
This set includes few fixes and refactors in the QAT driver, mainly
related to the PFVF communication mechanism.

Here is a summary of the changes:
* Patches #1 and #2 fix a bug in the PFVF protocol related to collision
  detection;
* Patch #3 optimizes the PFVF protocol protocol by removing an unnecessary
  timeout;
* Patch #4 makes the VF to PF interrupt related logic device specific;
* Patches #5 and #6 remove duplicated logic across devices and homegrown
  logic;
* Patches #7 to #12 are just refactoring of the PFVF code in preparation
  for updates to the protocol.

Giovanni Cabiddu (3):
  crypto: qat - detect PFVF collision after ACK
  crypto: qat - disregard spurious PFVF interrupts
  crypto: qat - use hweight for bit counting

Marco Chiappero (9):
  crypto: qat - remove unnecessary collision prevention step in PFVF
  crypto: qat - fix handling of VF to PF interrupts
  crypto: qat - remove duplicated logic across GEN2 drivers
  crypto: qat - make pfvf send message direction agnostic
  crypto: qat - move pfvf collision detection values
  crypto: qat - rename pfvf collision constants
  crypto: qat - add VF and PF wrappers to common send function
  crypto: qat - extract send and wait from adf_vf2pf_request_version()
  crypto: qat - share adf_enable_pf2vf_comms() from adf_pf2vf_msg.c

 .../crypto/qat/qat_4xxx/adf_4xxx_hw_data.c    |   4 +-
 .../crypto/qat/qat_c3xxx/adf_c3xxx_hw_data.c  |  89 +------
 .../crypto/qat/qat_c3xxx/adf_c3xxx_hw_data.h  |  13 +-
 .../crypto/qat/qat_c62x/adf_c62x_hw_data.c    |  87 +------
 .../crypto/qat/qat_c62x/adf_c62x_hw_data.h    |  12 -
 .../crypto/qat/qat_common/adf_accel_devices.h |   5 +
 .../crypto/qat/qat_common/adf_common_drv.h    |   9 +-
 .../crypto/qat/qat_common/adf_gen2_hw_data.c  |  98 ++++++++
 .../crypto/qat/qat_common/adf_gen2_hw_data.h  |  27 ++
 drivers/crypto/qat/qat_common/adf_isr.c       |  20 +-
 drivers/crypto/qat/qat_common/adf_pf2vf_msg.c | 238 ++++++++++--------
 drivers/crypto/qat/qat_common/adf_pf2vf_msg.h |   9 -
 drivers/crypto/qat/qat_common/adf_vf2pf_msg.c |   4 +-
 drivers/crypto/qat/qat_common/adf_vf_isr.c    |   6 +
 .../qat/qat_dh895xcc/adf_dh895xcc_hw_data.c   | 123 ++++-----
 .../qat/qat_dh895xcc/adf_dh895xcc_hw_data.h   |  14 +-
 16 files changed, 361 insertions(+), 397 deletions(-)

Comments

Herbert Xu Oct. 8, 2021, 12:23 p.m. UTC | #1
On Tue, Sep 28, 2021 at 12:44:28PM +0100, Giovanni Cabiddu wrote:
> This set includes few fixes and refactors in the QAT driver, mainly
> related to the PFVF communication mechanism.
> 
> Here is a summary of the changes:
> * Patches #1 and #2 fix a bug in the PFVF protocol related to collision
>   detection;
> * Patch #3 optimizes the PFVF protocol protocol by removing an unnecessary
>   timeout;
> * Patch #4 makes the VF to PF interrupt related logic device specific;
> * Patches #5 and #6 remove duplicated logic across devices and homegrown
>   logic;
> * Patches #7 to #12 are just refactoring of the PFVF code in preparation
>   for updates to the protocol.
> 
> Giovanni Cabiddu (3):
>   crypto: qat - detect PFVF collision after ACK
>   crypto: qat - disregard spurious PFVF interrupts
>   crypto: qat - use hweight for bit counting
> 
> Marco Chiappero (9):
>   crypto: qat - remove unnecessary collision prevention step in PFVF
>   crypto: qat - fix handling of VF to PF interrupts
>   crypto: qat - remove duplicated logic across GEN2 drivers
>   crypto: qat - make pfvf send message direction agnostic
>   crypto: qat - move pfvf collision detection values
>   crypto: qat - rename pfvf collision constants
>   crypto: qat - add VF and PF wrappers to common send function
>   crypto: qat - extract send and wait from adf_vf2pf_request_version()
>   crypto: qat - share adf_enable_pf2vf_comms() from adf_pf2vf_msg.c
> 
>  .../crypto/qat/qat_4xxx/adf_4xxx_hw_data.c    |   4 +-
>  .../crypto/qat/qat_c3xxx/adf_c3xxx_hw_data.c  |  89 +------
>  .../crypto/qat/qat_c3xxx/adf_c3xxx_hw_data.h  |  13 +-
>  .../crypto/qat/qat_c62x/adf_c62x_hw_data.c    |  87 +------
>  .../crypto/qat/qat_c62x/adf_c62x_hw_data.h    |  12 -
>  .../crypto/qat/qat_common/adf_accel_devices.h |   5 +
>  .../crypto/qat/qat_common/adf_common_drv.h    |   9 +-
>  .../crypto/qat/qat_common/adf_gen2_hw_data.c  |  98 ++++++++
>  .../crypto/qat/qat_common/adf_gen2_hw_data.h  |  27 ++
>  drivers/crypto/qat/qat_common/adf_isr.c       |  20 +-
>  drivers/crypto/qat/qat_common/adf_pf2vf_msg.c | 238 ++++++++++--------
>  drivers/crypto/qat/qat_common/adf_pf2vf_msg.h |   9 -
>  drivers/crypto/qat/qat_common/adf_vf2pf_msg.c |   4 +-
>  drivers/crypto/qat/qat_common/adf_vf_isr.c    |   6 +
>  .../qat/qat_dh895xcc/adf_dh895xcc_hw_data.c   | 123 ++++-----
>  .../qat/qat_dh895xcc/adf_dh895xcc_hw_data.h   |  14 +-
>  16 files changed, 361 insertions(+), 397 deletions(-)

All applied.  Thanks.