mbox series

[v2,0/2] random: fix some data races

Message ID 20211220224157.111959-1-ebiggers@kernel.org (mailing list archive)
Headers show
Series random: fix some data races | expand

Message

Eric Biggers Dec. 20, 2021, 10:41 p.m. UTC 
This series fixes some data races in random.c.

Changed v1 => v2:
   - Remove unneeded 'inline' keywords
   - Use READ_ONCE() instead of smp_load_acquire()
   - Updated commit message
   - Added patch to fix data race on crng init time

Eric Biggers (2):
  random: fix data race on crng_node_pool
  random: fix data race on crng init time

 drivers/char/random.c | 61 +++++++++++++++++++++++--------------------
 1 file changed, 33 insertions(+), 28 deletions(-)

Comments

Paul E. McKenney Dec. 20, 2021, 11:40 p.m. UTC | #1 
On Mon, Dec 20, 2021 at 04:41:55PM -0600, Eric Biggers wrote:
> This series fixes some data races in random.c.
> 
> Changed v1 => v2:
>    - Remove unneeded 'inline' keywords
>    - Use READ_ONCE() instead of smp_load_acquire()
>    - Updated commit message
>    - Added patch to fix data race on crng init time
> 
> Eric Biggers (2):
>   random: fix data race on crng_node_pool
>   random: fix data race on crng init time

From a memory-ordering viewpoint:

Acked-by: Paul E. McKenney <paulmck@kernel.org>

>  drivers/char/random.c | 61 +++++++++++++++++++++++--------------------
>  1 file changed, 33 insertions(+), 28 deletions(-)
> 
> -- 
> 2.34.1
>
Jason A. Donenfeld Dec. 21, 2021, 12:15 p.m. UTC | #2 
All applied to crng/random.git. Thanks for the series.

Jason