From patchwork Wed Mar 16 19:20:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 12783083 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ECC3C43217 for ; Wed, 16 Mar 2022 19:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245535AbiCPTVi (ORCPT ); Wed, 16 Mar 2022 15:21:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235986AbiCPTVh (ORCPT ); Wed, 16 Mar 2022 15:21:37 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 706B6532CF; Wed, 16 Mar 2022 12:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=X2j8KWKH7mPGrGuSOCsj6/Zr05knYdm/d0qKjoRqe/A=; b=bdC3zFz0aD/kHDcjfAyZbfQHBp 7D/NlBM1amLmkH4B4sqKV2ufqUvJD88hTlKpyZ6VqDgekjK4FNGYILRpxkEqmQPADEL6WPYAAzU3c Sgrf+0emCMPKxF4geOisKrAEZIi126v6w7X5ziKEvg+Vo5Kfv7gQeEp68Rya/2NrsCbuCdD1F1eRO BniaXaZDMgIYFHq/3z0YvLS2w5qVtTdqdrrvR04+Nr2xp3obBSzkGzIwryyT9w7ppsZfrvdhEgpU1 CvVbeb1+V8VRryF0rtfXsRiz/tX5kbeNaIbViAt6lEitADJHoianGTvyLAizZrpPdjB0SFmWrUO/U gzvEtNsQ==; Received: from [2601:1c0:6280:3f0::aa0b] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUZBu-00EArp-Lx; Wed, 16 Mar 2022 19:20:14 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Jens Axboe , Amit Shah , Arnd Bergmann , Greg Kroah-Hartman , Eli Cohen , Saeed Mahameed , Leon Romanovsky , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , =?utf-8?b?TWljaGHFgiBNaXJvc8WC?= =?utf-8?b?YXc=?= , Sebastian Andrzej Siewior , Krzysztof Opasiak , Igor Kotrasinski , Valentina Manea , Shuah Khan , Shuah Khan , Jussi Kivilinna , Joachim Fritschi , Herbert Xu , Thomas Gleixner , Steven Rostedt , Ingo Molnar , Karol Herbst , Pekka Paalanen , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Borislav Petkov , "H. Peter Anvin" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, x86@kernel.org Subject: [PATCH 0/9] treewide: eliminate anonymous module_init & module_exit Date: Wed, 16 Mar 2022 12:20:01 -0700 Message-Id: <20220316192010.19001-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org There are a number of drivers that use "module_init(init)" and "module_exit(exit)", which are anonymous names and can lead to confusion or ambiguity when reading System.map, crashes/oops/bugs, or an initcall_debug log. Give each of these init and exit functions unique driver-specific names to eliminate the anonymous names. Example 1: (System.map) ffffffff832fc78c t init ffffffff832fc79e t init ffffffff832fc8f8 t init ffffffff832fca05 t init ffffffff832fcbd2 t init ffffffff83328f0e t init ffffffff8332c5b1 t init ffffffff8332d9eb t init ffffffff8332f0aa t init ffffffff83330e25 t init ffffffff833317a5 t init ffffffff8333dd6b t init Example 2: (initcall_debug log) calling init+0x0/0x12 @ 1 initcall init+0x0/0x12 returned 0 after 15 usecs calling init+0x0/0x60 @ 1 initcall init+0x0/0x60 returned 0 after 2 usecs calling init+0x0/0x9a @ 1 initcall init+0x0/0x9a returned 0 after 74 usecs calling init+0x0/0x73 @ 1 initcall init+0x0/0x73 returned 0 after 6 usecs calling init+0x0/0x73 @ 1 initcall init+0x0/0x73 returned 0 after 4 usecs calling init+0x0/0xf5 @ 1 initcall init+0x0/0xf5 returned 0 after 27 usecs calling init+0x0/0x7d @ 1 initcall init+0x0/0x7d returned 0 after 11 usecs calling init+0x0/0xc9 @ 1 initcall init+0x0/0xc9 returned 0 after 19 usecs calling init+0x0/0x9d @ 1 initcall init+0x0/0x9d returned 0 after 37 usecs calling init+0x0/0x63f @ 1 initcall init+0x0/0x63f returned 0 after 411 usecs calling init+0x0/0x171 @ 1 initcall init+0x0/0x171 returned 0 after 61 usecs calling init+0x0/0xef @ 1 initcall init+0x0/0xef returned 0 after 3 usecs Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Paolo Bonzini Cc: Stefan Hajnoczi Cc: Jens Axboe Cc: Amit Shah Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Eli Cohen Cc: Saeed Mahameed Cc: Leon Romanovsky Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Florian Westphal Cc: "David S. Miller" Cc: Jakub Kicinski Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Felipe Balbi Cc: Michał Mirosław Cc: Sebastian Andrzej Siewior Cc: Krzysztof Opasiak Cc: Igor Kotrasinski Cc: Valentina Manea Cc: Shuah Khan Cc: Shuah Khan Cc: Jussi Kivilinna Cc: Joachim Fritschi Cc: Herbert Xu Cc: Thomas Gleixner Cc: Steven Rostedt Cc: Ingo Molnar Cc: Karol Herbst Cc: Pekka Paalanen Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: netfilter-devel@vger.kernel.org Cc: coreteam@netfilter.org Cc: netdev@vger.kernel.org Cc: linux-block@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: linux-rdma@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: linux-usb@vger.kernel.org Cc: nouveau@lists.freedesktop.org Cc: virtualization@lists.linux-foundation.org Cc: x86@kernel.org patches: [PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit [PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit [PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit [PATCH 7/9] usb: usbip: eliminate anonymous module_init & module_exit [PATCH 8/9] x86/crypto: eliminate anonymous module_init & module_exit [PATCH 9/9] testmmiotrace: eliminate anonymous module_init & module_exit diffstat: arch/x86/crypto/blowfish_glue.c | 8 ++++---- arch/x86/crypto/camellia_glue.c | 8 ++++---- arch/x86/crypto/serpent_avx2_glue.c | 8 ++++---- arch/x86/crypto/twofish_glue.c | 8 ++++---- arch/x86/crypto/twofish_glue_3way.c | 8 ++++---- arch/x86/mm/testmmiotrace.c | 8 ++++---- drivers/block/virtio_blk.c | 8 ++++---- drivers/char/virtio_console.c | 8 ++++---- drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 ++++---- drivers/scsi/virtio_scsi.c | 8 ++++---- drivers/usb/gadget/legacy/inode.c | 8 ++++---- drivers/usb/gadget/legacy/serial.c | 10 +++++----- drivers/usb/gadget/udc/dummy_hcd.c | 8 ++++---- drivers/usb/usbip/vudc_main.c | 8 ++++---- net/ipv4/netfilter/nf_nat_h323.c | 8 ++++---- 15 files changed, 61 insertions(+), 61 deletions(-) Reviewed-by: Ira Weiny