| Message ID | 20220321174548.510516-1-mic@digikod.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | Explain panic() calls for keyring initialization | expand |
On Mon, 2022-03-21 at 18:45 +0100, Mickaël Salaün wrote: > > Mickaël Salaün (1): > certs: Explain the rational to call panic() Nit: "rationale". Even in Simplified English, I believe "rational" is a completely different word. > certs/blacklist.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Also, isn't it about time we changed this to call it a denylist?
On 21/03/2022 19:29, David Woodhouse wrote: > On Mon, 2022-03-21 at 18:45 +0100, Mickaël Salaün wrote: >> >> Mickaël Salaün (1): >> certs: Explain the rational to call panic() > > Nit: "rationale". Even in Simplified English, I believe "rational" is a > completely different word. Right, "rational" is an adjective. > >> certs/blacklist.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) > > Also, isn't it about time we changed this to call it a denylist? > It is important to note that this word is part of the kernel ABI because of the keyring name.
As suggested by Jarkko and explained by Paul, let's document the panic() calls from the blacklist keyring initialization. This series applies on top of commit 50c486fe3108 ("certs: Allow root user to append signed hashes to the blacklist keyring"). This can smoothly be rebased on top of Jarkko's next branch. [1] https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=50c486fe310890c134b5cb36cf9a4135475a6074 Regards, Mickaël Salaün (1): certs: Explain the rational to call panic() certs/blacklist.c | 8 ++++++++ 1 file changed, 8 insertions(+) base-commit: 50c486fe310890c134b5cb36cf9a4135475a6074