| Message ID | 20220509133417.56043-1-giovanni.cabiddu@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | crypto: qat - re-enable algorithms | expand |
On Mon, May 09, 2022 at 02:34:07PM +0100, Giovanni Cabiddu wrote: > This set is an extension of a previous set called `crypto: qat - fix dm-crypt > related issues` which aims to re-enable the algorithms in the QAT driver > after [1]. > > This fixes a number of issues with the implementation of the QAT algs, > both symmetric and asymmetric. > In particular this set enables the QAT driver to handle correctly the > flags CRYPTO_TFM_REQ_MAY_BACKLOG and CRYPTO_TFM_REQ_MAY_SLEEP, > fixes an hidden issue in RSA and DH which appeared after commit f5ff79fddf0e, > related to the usage of dma_free_coherent() from a tasklet, and includes > important fixes in the akcipher algorithms. > > One item to mention is that, differently from the previous set, this > one does not removes the flag CRYPTO_ALG_ALLOCATES_MEMORY which will > be removed after the conversation in [2] is closed. > > [1] https://lore.kernel.org/linux-crypto/YiEyGoHacN80FcOL@silpixa00400314/ > [2] https://lore.kernel.org/linux-crypto/Yl6PlqyucVLCzwF5@silpixa00400314/ > > Changes from v2: > - Removed `crypto: qat - set to zero DH parameters before free` from > set. > - Added fixes tags to patches `crypto: qat - add param check for RSA` > and `crypto: qat - add param check for DH` > > Changes from v1: > - Clarified commit message in `crypto: qat - refactor submission logic` > to indicate why the patch should be included in stable kernels > - Removed `crypto: qat - use memzero_explicit() for algs` from set > after feedback from Greg KH > - Replaced memzero_explicit() with memset() in `crypto: qat - set to > zero DH parameters before free` after feedback from Greg KH > > Giovanni Cabiddu (10): > crypto: qat - use pre-allocated buffers in datapath > crypto: qat - refactor submission logic > crypto: qat - add backlog mechanism > crypto: qat - fix memory leak in RSA > crypto: qat - remove dma_free_coherent() for RSA > crypto: qat - remove dma_free_coherent() for DH > crypto: qat - add param check for RSA > crypto: qat - add param check for DH > crypto: qat - honor CRYPTO_TFM_REQ_MAY_SLEEP flag > crypto: qat - re-enable registration of algorithms > > drivers/crypto/qat/qat_4xxx/adf_drv.c | 7 - > drivers/crypto/qat/qat_common/Makefile | 1 + > drivers/crypto/qat/qat_common/adf_transport.c | 11 + > drivers/crypto/qat/qat_common/adf_transport.h | 1 + > .../qat/qat_common/adf_transport_internal.h | 1 + > drivers/crypto/qat/qat_common/qat_algs.c | 153 +++++---- > drivers/crypto/qat/qat_common/qat_algs_send.c | 86 +++++ > drivers/crypto/qat/qat_common/qat_algs_send.h | 11 + > drivers/crypto/qat/qat_common/qat_asym_algs.c | 304 +++++++++--------- > drivers/crypto/qat/qat_common/qat_crypto.c | 10 +- > drivers/crypto/qat/qat_common/qat_crypto.h | 44 +++ > 11 files changed, 392 insertions(+), 237 deletions(-) > create mode 100644 drivers/crypto/qat/qat_common/qat_algs_send.c > create mode 100644 drivers/crypto/qat/qat_common/qat_algs_send.h All applied. Thanks.
This set is an extension of a previous set called `crypto: qat - fix dm-crypt related issues` which aims to re-enable the algorithms in the QAT driver after [1]. This fixes a number of issues with the implementation of the QAT algs, both symmetric and asymmetric. In particular this set enables the QAT driver to handle correctly the flags CRYPTO_TFM_REQ_MAY_BACKLOG and CRYPTO_TFM_REQ_MAY_SLEEP, fixes an hidden issue in RSA and DH which appeared after commit f5ff79fddf0e, related to the usage of dma_free_coherent() from a tasklet, and includes important fixes in the akcipher algorithms. One item to mention is that, differently from the previous set, this one does not removes the flag CRYPTO_ALG_ALLOCATES_MEMORY which will be removed after the conversation in [2] is closed. [1] https://lore.kernel.org/linux-crypto/YiEyGoHacN80FcOL@silpixa00400314/ [2] https://lore.kernel.org/linux-crypto/Yl6PlqyucVLCzwF5@silpixa00400314/ Changes from v2: - Removed `crypto: qat - set to zero DH parameters before free` from set. - Added fixes tags to patches `crypto: qat - add param check for RSA` and `crypto: qat - add param check for DH` Changes from v1: - Clarified commit message in `crypto: qat - refactor submission logic` to indicate why the patch should be included in stable kernels - Removed `crypto: qat - use memzero_explicit() for algs` from set after feedback from Greg KH - Replaced memzero_explicit() with memset() in `crypto: qat - set to zero DH parameters before free` after feedback from Greg KH Giovanni Cabiddu (10): crypto: qat - use pre-allocated buffers in datapath crypto: qat - refactor submission logic crypto: qat - add backlog mechanism crypto: qat - fix memory leak in RSA crypto: qat - remove dma_free_coherent() for RSA crypto: qat - remove dma_free_coherent() for DH crypto: qat - add param check for RSA crypto: qat - add param check for DH crypto: qat - honor CRYPTO_TFM_REQ_MAY_SLEEP flag crypto: qat - re-enable registration of algorithms drivers/crypto/qat/qat_4xxx/adf_drv.c | 7 - drivers/crypto/qat/qat_common/Makefile | 1 + drivers/crypto/qat/qat_common/adf_transport.c | 11 + drivers/crypto/qat/qat_common/adf_transport.h | 1 + .../qat/qat_common/adf_transport_internal.h | 1 + drivers/crypto/qat/qat_common/qat_algs.c | 153 +++++---- drivers/crypto/qat/qat_common/qat_algs_send.c | 86 +++++ drivers/crypto/qat/qat_common/qat_algs_send.h | 11 + drivers/crypto/qat/qat_common/qat_asym_algs.c | 304 +++++++++--------- drivers/crypto/qat/qat_common/qat_crypto.c | 10 +- drivers/crypto/qat/qat_common/qat_crypto.h | 44 +++ 11 files changed, 392 insertions(+), 237 deletions(-) create mode 100644 drivers/crypto/qat/qat_common/qat_algs_send.c create mode 100644 drivers/crypto/qat/qat_common/qat_algs_send.h