mbox series

[0/2] hwrng: nomadik - two simple cleanups

Message ID 20230702173503.163152-1-martin@kaiser.cx (mailing list archive)
Headers show
Series hwrng: nomadik - two simple cleanups | expand

Message

Martin Kaiser July 2, 2023, 5:35 p.m. UTC 
Use devm_clk_get_enabled to fix a (theoretical) race condition during removal.
Call dev_error_probe to print an error message and exit.

Both changes were compile-tested only, I don't have this hardware.

Martin Kaiser (2):
  hwrng: nomadik - keep clock enabled while hwrng is registered
  hwrng: nomadik - use dev_err_probe

 drivers/char/hw_random/nomadik-rng.c | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)

Comments

Herbert Xu July 14, 2023, 8:56 a.m. UTC | #1 
On Sun, Jul 02, 2023 at 07:35:01PM +0200, Martin Kaiser wrote:
> Use devm_clk_get_enabled to fix a (theoretical) race condition during removal.
> Call dev_error_probe to print an error message and exit.
> 
> Both changes were compile-tested only, I don't have this hardware.
> 
> Martin Kaiser (2):
>   hwrng: nomadik - keep clock enabled while hwrng is registered
>   hwrng: nomadik - use dev_err_probe
> 
>  drivers/char/hw_random/nomadik-rng.c | 19 +++++--------------
>  1 file changed, 5 insertions(+), 14 deletions(-)
> 
> -- 
> 2.30.2

All applied.  Thanks.