[v5,0/7] crypto: stm32 - Save and restore between each request

Message ID	ZAMQjOdi8GfqDUQI@gondor.apana.org.au (mailing list archive)
Headers	show Return-Path: <linux-crypto-owner@vger.kernel.org> Date: Sat, 4 Mar 2023 17:34:04 +0800 From: Herbert Xu <herbert@gondor.apana.org.au> To: Linus Walleij <linus.walleij@linaro.org> Cc: Lionel Debieve <lionel.debieve@foss.st.com>, Li kunyu <kunyu@nfschina.com>, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mcoquelin.stm32@gmail.com Subject: [v5 PATCH 0/7] crypto: stm32 - Save and restore between each request Message-ID: <ZAMQjOdi8GfqDUQI@gondor.apana.org.au> References: <Y/hQdzsKMYgkIfMY@gondor.apana.org.au> <Y/yIbPBVCPx9K/0s@gondor.apana.org.au> <CACRpkdZC4z2Xng4=k94rmM=AFzNzTdXkvtkArMnK7afouz=7VA@mail.gmail.com> <Y/3FYZJeLE7DVPBf@gondor.apana.org.au> <Y/3IA4OjmUmjMgh1@gondor.apana.org.au> <Y/3N6zFOZeehJQ/p@gondor.apana.org.au> <CACRpkdZ3rCsOWqooNkPL6m7vZ2Z2Frh2sdxruKhrS0t3QHcSKw@mail.gmail.com> <Y/6sCC2nH0FcD6kJ@gondor.apana.org.au> <CACRpkdYN-SDfxXKLt3HWGVkWb3V1rABwvWuytwDrzfTqm81fNA@mail.gmail.com> <ZAA8doNUjYmTRScB@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <ZAA8doNUjYmTRScB@gondor.apana.org.au> Precedence: bulk
Series	crypto: stm32 - Save and restore between each request \| expand [v5,0/7] crypto: stm32 - Save and restore between each request [v5,1/7] crypto: stm32 - Save 54 CSR registers [v5,2/7] crypto: stm32 - Move polling into do_one_request [v5,3/7] crypto: stm32 - Simplify finup [v5,4/7] crypto: stm32 - Remove unused hdev->err field [v5,5/7] crypto: stm32 - Move hash state into separate structure [v5,6/7] crypto: stm32 - Remove unused HASH_FLAGS_ERRORS [v5,7/7] crypto: stm32 - Save and restore between each request

Message ID

ZAMQjOdi8GfqDUQI@gondor.apana.org.au (mailing list archive)

Headers

Date: Sat, 4 Mar 2023 17:34:04 +0800
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Lionel Debieve <lionel.debieve@foss.st.com>,
        Li kunyu <kunyu@nfschina.com>, davem@davemloft.net,
        linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com, mcoquelin.stm32@gmail.com
Subject: [v5 PATCH 0/7] crypto: stm32 - Save and restore between each request
Message-ID: <ZAMQjOdi8GfqDUQI@gondor.apana.org.au>
References: <Y/hQdzsKMYgkIfMY@gondor.apana.org.au>
 <Y/yIbPBVCPx9K/0s@gondor.apana.org.au>
 <CACRpkdZC4z2Xng4=k94rmM=AFzNzTdXkvtkArMnK7afouz=7VA@mail.gmail.com>
 <Y/3FYZJeLE7DVPBf@gondor.apana.org.au>
 <Y/3IA4OjmUmjMgh1@gondor.apana.org.au>
 <Y/3N6zFOZeehJQ/p@gondor.apana.org.au>
 <CACRpkdZ3rCsOWqooNkPL6m7vZ2Z2Frh2sdxruKhrS0t3QHcSKw@mail.gmail.com>
 <Y/6sCC2nH0FcD6kJ@gondor.apana.org.au>
 <CACRpkdYN-SDfxXKLt3HWGVkWb3V1rABwvWuytwDrzfTqm81fNA@mail.gmail.com>
 <ZAA8doNUjYmTRScB@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZAA8doNUjYmTRScB@gondor.apana.org.au>
Precedence: bulk

Series

crypto: stm32 - Save and restore between each request | expand

Message

Herbert Xu March 4, 2023, 9:34 a.m. UTC

On Thu, Mar 02, 2023 at 02:04:38PM +0800, Herbert Xu wrote:
> 
> I think I see the problem.  My patch wasn't waiting for the hash
> computation to complete before saving the state so obviously it
> will get the wrong hash state every single time.
> 
> I'll fix this up and some other inconsistencies (my reading of the
> documentation is that there are 54 registers (0-53), not 53) and
> resend the patch.

I've split the patch up into smaller chunks for easier testing.

Cheers,