[0/3] crypto: mxs-dcp - Fix tcrypt on imx6

Message

Leonard Crestez Oct. 2, 2018, 7:01 p.m. UTC

The mxs-dcp driver currently fails to probe on imx6. Fix the whole thing
by porting a cleaned/squashed version of fixes carried in the NXP vendor
tree.

Tested with "modprobe tcrypt" and CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=n
on imx6sl imx6sll imx6ull: no failures.

I'm not very familiar with crypto and did not write write these fixes so
a skeptical review would be appreciated.

Previously:
  https://lore.kernel.org/patchwork/patch/989652/

Dan Douglass (1):
  crypto: mxs-dcp - Implement sha import/export

Radu Solea (2):
  crypto: mxs-dcp - Fix SHA null hashes and output length
  crypto: mxs-dcp - Fix AES issues

 drivers/crypto/mxs-dcp.c | 121 ++++++++++++++++++++++++++++++++-------
 1 file changed, 101 insertions(+), 20 deletions(-)

Comments

Herbert Xu Oct. 8, 2018, 5:52 a.m. UTC | #1

On Tue, Oct 02, 2018 at 07:01:46PM +0000, Leonard Crestez wrote:
> The mxs-dcp driver currently fails to probe on imx6. Fix the whole thing
> by porting a cleaned/squashed version of fixes carried in the NXP vendor
> tree.
> 
> Tested with "modprobe tcrypt" and CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=n
> on imx6sl imx6sll imx6ull: no failures.
> 
> I'm not very familiar with crypto and did not write write these fixes so
> a skeptical review would be appreciated.
> 
> Previously:
>   https://lore.kernel.org/patchwork/patch/989652/
> 
> Dan Douglass (1):
>   crypto: mxs-dcp - Implement sha import/export
> 
> Radu Solea (2):
>   crypto: mxs-dcp - Fix SHA null hashes and output length
>   crypto: mxs-dcp - Fix AES issues
> 
>  drivers/crypto/mxs-dcp.c | 121 ++++++++++++++++++++++++++++++++-------
>  1 file changed, 101 insertions(+), 20 deletions(-)

All applied.  Thanks.