| Message ID | cover.1558445259.git.christophe.leroy@c-s.fr (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fixing selftests failure on Talitos driver | expand |
On 5/21/2019 4:34 PM, Christophe Leroy wrote: > Several test failures have popped up following recent changes to crypto > selftests. > > This series fixes (most of) them. > > The last three patches are trivial cleanups. > Thanks Christophe. For the series: Reviewed-by: Horia Geantă <horia.geanta@nxp.com> Have you validated the changes also on SEC 2.x+? Asking since IIRC you mentioned having only HW with SEC 1 and changes in patch "crypto: talitos - fix AEAD processing." look quite complex. Thanks, Horia
Horia Geanta <horia.geanta@nxp.com> a écrit : > On 5/21/2019 4:34 PM, Christophe Leroy wrote: >> Several test failures have popped up following recent changes to crypto >> selftests. >> >> This series fixes (most of) them. >> >> The last three patches are trivial cleanups. >> > Thanks Christophe. > > For the series: > Reviewed-by: Horia Geantă <horia.geanta@nxp.com> > > Have you validated the changes also on SEC 2.x+? > Asking since IIRC you mentioned having only HW with SEC 1 and > changes in patch > "crypto: talitos - fix AEAD processing." look quite complex. When I ported the driver to SEC1 some years ago I only had a SEC 1.2 (mpc885) but I now have also a board with a mpc8321E which embeds a SEC 2.2 so I also tested the changes on it. Christophe > > Thanks, > Horia
On Tue, May 21, 2019 at 01:34:06PM +0000, Christophe Leroy wrote: > Several test failures have popped up following recent changes to crypto > selftests. > > This series fixes (most of) them. > > The last three patches are trivial cleanups. > > Christophe Leroy (15): > crypto: talitos - fix skcipher failure due to wrong output IV > crypto: talitos - rename alternative AEAD algos. > crypto: talitos - reduce max key size for SEC1 > crypto: talitos - check AES key size > crypto: talitos - fix CTR alg blocksize > crypto: talitos - check data blocksize in ablkcipher. > crypto: talitos - fix ECB algs ivsize > crypto: talitos - Do not modify req->cryptlen on decryption. > crypto: talitos - HMAC SNOOP NO AFEU mode requires SW icv checking. > crypto: talitos - properly handle split ICV. > crypto: talitos - Align SEC1 accesses to 32 bits boundaries. > crypto: talitos - fix AEAD processing. > Revert "crypto: talitos - export the talitos_submit function" > crypto: talitos - use IS_ENABLED() in has_ftr_sec1() > crypto: talitos - use SPDX-License-Identifier > > drivers/crypto/talitos.c | 281 ++++++++++++++++++++++------------------------- > drivers/crypto/talitos.h | 45 ++------ > 2 files changed, 139 insertions(+), 187 deletions(-) Patch 1 was already applied. 2-15 applied. Thanks.