mbox series

[0/3] PSP TEE driver update and bug fixes

Message ID cover.1615276206.git.Rijo-john.Thomas@amd.com (mailing list archive)
Headers show
Series PSP TEE driver update and bug fixes | expand

Message

Rijo Thomas March 9, 2021, 8:11 a.m. UTC
The first patch helps to improve the response time by reducing the
polling time of the tee command status variable.

Second patch is a bug fix to handle multi-threaded use-case.
During testing, race condition was seen due to missing synchronisation
in writes to the TEE ring buffer. This patch helps to resolve that.

Third patch is to update the copyright year for the tee driver files.

Rijo Thomas (3):
  crypto: ccp - reduce tee command status polling interval from 5ms to
    1ms
  crypto: ccp - fix command queuing to TEE ring buffer
  crypto: ccp - update copyright year for tee

 drivers/crypto/ccp/tee-dev.c | 57 ++++++++++++++++++++++++------------
 drivers/crypto/ccp/tee-dev.h | 20 +++++++++++--
 2 files changed, 57 insertions(+), 20 deletions(-)

Comments

Tom Lendacky March 9, 2021, 4:36 p.m. UTC | #1
On 3/9/21 2:11 AM, Rijo Thomas wrote:
> The first patch helps to improve the response time by reducing the
> polling time of the tee command status variable.
> 
> Second patch is a bug fix to handle multi-threaded use-case.
> During testing, race condition was seen due to missing synchronisation
> in writes to the TEE ring buffer. This patch helps to resolve that.
> 
> Third patch is to update the copyright year for the tee driver files.
> 

Just something to think about and not as part of this patch series, but
think about submitting a patch that adds you as maintainer of the TEE
portion of the driver (see how the SEV portion is handled).

Thanks,
Tom

> Rijo Thomas (3):
>   crypto: ccp - reduce tee command status polling interval from 5ms to
>     1ms
>   crypto: ccp - fix command queuing to TEE ring buffer
>   crypto: ccp - update copyright year for tee
> 
>  drivers/crypto/ccp/tee-dev.c | 57 ++++++++++++++++++++++++------------
>  drivers/crypto/ccp/tee-dev.h | 20 +++++++++++--
>  2 files changed, 57 insertions(+), 20 deletions(-)
>
Rijo Thomas March 10, 2021, 4:27 a.m. UTC | #2
On 09/03/21 10:06 pm, Tom Lendacky wrote:
> On 3/9/21 2:11 AM, Rijo Thomas wrote:
>> The first patch helps to improve the response time by reducing the
>> polling time of the tee command status variable.
>>
>> Second patch is a bug fix to handle multi-threaded use-case.
>> During testing, race condition was seen due to missing synchronisation
>> in writes to the TEE ring buffer. This patch helps to resolve that.
>>
>> Third patch is to update the copyright year for the tee driver files.
>>
> 
> Just something to think about and not as part of this patch series, but
> think about submitting a patch that adds you as maintainer of the TEE
> portion of the driver (see how the SEV portion is handled).
> 

Sure Tom. I will add myself as maintainer for TEE portion of driver.
I will post that as a separate patch.

Thanks,
Rijo

> Thanks,
> Tom
> 
>> Rijo Thomas (3):
>>   crypto: ccp - reduce tee command status polling interval from 5ms to
>>     1ms
>>   crypto: ccp - fix command queuing to TEE ring buffer
>>   crypto: ccp - update copyright year for tee
>>
>>  drivers/crypto/ccp/tee-dev.c | 57 ++++++++++++++++++++++++------------
>>  drivers/crypto/ccp/tee-dev.h | 20 +++++++++++--
>>  2 files changed, 57 insertions(+), 20 deletions(-)
>>