mbox series

[0/5] crypto virtio cleanups

Message ID cover.1738562694.git.lukas@wunner.de (mailing list archive)
Headers show
Series crypto virtio cleanups | expand

Message

Lukas Wunner Feb. 3, 2025, 1:37 p.m. UTC
Here's an assortment of trivial crypto virtio cleanups
which I accumulated while working on commit 5b553e06b321
("crypto: virtio - Drop sign/verify operations").

I've used qemu + libgcrypt backend to ascertain that all
boot-time crypto selftests still pass after these changes.
I've also verified that a KEYCTL_PKEY_ENCRYPT operation
using virtio-pkcs1-rsa produces correct output.

Thanks!

Lukas Wunner (5):
  crypto: virtio - Fix kernel-doc of virtcrypto_dev_stop()
  crypto: virtio - Simplify RSA key size caching
  crypto: virtio - Drop superfluous ctx->tfm backpointer
  crypto: virtio - Drop superfluous [as]kcipher_ctx pointer
  crypto: virtio - Drop superfluous [as]kcipher_req pointer

 .../virtio/virtio_crypto_akcipher_algs.c      | 41 ++++++++-----------
 drivers/crypto/virtio/virtio_crypto_mgr.c     |  2 +-
 .../virtio/virtio_crypto_skcipher_algs.c      | 17 ++------
 3 files changed, 21 insertions(+), 39 deletions(-)

Comments

zhenwei pi Feb. 5, 2025, 7:52 a.m. UTC | #1
This series looks good to me, thanks!

Reviewed-by: zhenwei pi <pizhenwei@bytedance.com>

On 2/3/25 21:37, Lukas Wunner wrote:
> Here's an assortment of trivial crypto virtio cleanups
> which I accumulated while working on commit 5b553e06b321
> ("crypto: virtio - Drop sign/verify operations").
> 
> I've used qemu + libgcrypt backend to ascertain that all
> boot-time crypto selftests still pass after these changes.
> I've also verified that a KEYCTL_PKEY_ENCRYPT operation
> using virtio-pkcs1-rsa produces correct output.
> 
> Thanks!
> 
> Lukas Wunner (5):
>    crypto: virtio - Fix kernel-doc of virtcrypto_dev_stop()
>    crypto: virtio - Simplify RSA key size caching
>    crypto: virtio - Drop superfluous ctx->tfm backpointer
>    crypto: virtio - Drop superfluous [as]kcipher_ctx pointer
>    crypto: virtio - Drop superfluous [as]kcipher_req pointer
> 
>   .../virtio/virtio_crypto_akcipher_algs.c      | 41 ++++++++-----------
>   drivers/crypto/virtio/virtio_crypto_mgr.c     |  2 +-
>   .../virtio/virtio_crypto_skcipher_algs.c      | 17 ++------
>   3 files changed, 21 insertions(+), 39 deletions(-)
>
Herbert Xu Feb. 16, 2025, 5:24 a.m. UTC | #2
On Mon, Feb 03, 2025 at 02:37:00PM +0100, Lukas Wunner wrote:
> Here's an assortment of trivial crypto virtio cleanups
> which I accumulated while working on commit 5b553e06b321
> ("crypto: virtio - Drop sign/verify operations").
> 
> I've used qemu + libgcrypt backend to ascertain that all
> boot-time crypto selftests still pass after these changes.
> I've also verified that a KEYCTL_PKEY_ENCRYPT operation
> using virtio-pkcs1-rsa produces correct output.
> 
> Thanks!
> 
> Lukas Wunner (5):
>   crypto: virtio - Fix kernel-doc of virtcrypto_dev_stop()
>   crypto: virtio - Simplify RSA key size caching
>   crypto: virtio - Drop superfluous ctx->tfm backpointer
>   crypto: virtio - Drop superfluous [as]kcipher_ctx pointer
>   crypto: virtio - Drop superfluous [as]kcipher_req pointer
> 
>  .../virtio/virtio_crypto_akcipher_algs.c      | 41 ++++++++-----------
>  drivers/crypto/virtio/virtio_crypto_mgr.c     |  2 +-
>  .../virtio/virtio_crypto_skcipher_algs.c      | 17 ++------
>  3 files changed, 21 insertions(+), 39 deletions(-)
> 
> -- 
> 2.43.0

All applied.  Thanks.