From patchwork Wed Nov 18 15:33:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7650611 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CD207BF90C for ; Wed, 18 Nov 2015 15:34:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 92D562062B for ; Wed, 18 Nov 2015 15:34:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A13E02060C for ; Wed, 18 Nov 2015 15:34:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755415AbbKRPed (ORCPT ); Wed, 18 Nov 2015 10:34:33 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:56797 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754017AbbKRPec (ORCPT ); Wed, 18 Nov 2015 10:34:32 -0500 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue005) with ESMTPSA (Nemesis) id 0MNQCL-1a1Wet13bV-006wsS; Wed, 18 Nov 2015 16:33:58 +0100 From: Arnd Bergmann To: Herbert Xu , linux-crypto@vger.kernel.org Cc: Leilei Zhao , Nicolas Ferre , linux-arm-kernel@lists.infradead.org, Ludovic Desroches , linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH v3] crypto: atmel: fix bogus select Date: Wed, 18 Nov 2015 16:33:54 +0100 Message-ID: <12173927.U7ILfy5BBh@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:h0WvGw8BJo+YwmC/x4Kd/Sx4EUVsX75VGb6+6sgFCamhoofy4bU Twyy6/3ixXquYWIQOGDdrtkVkQnrKGXqx5pit3VI5vMg0UpCnc2UnaD7aIIeOJuNHeSpqp2 xZSIiRGj29QIk/kBMFjUw3urpfICbyqUnfFH+KkehcTlW8nOc6YmnUjiGCDCMHv8o83BTsF ipErkQVZwvFXuV+tfapdw== X-UI-Out-Filterresults: notjunk:1; V01:K0:s5lDWnk/hLE=:dqAlHFGo0opyEuHQuwWxzZ UsuBQeOybG79Ne5A4a3HqKZ91PI959MgGMRPTBxezxlTNttxRXy/N6beTiDvDCUSsPeVEaRG2 W6BbYuQmzEdDMt3to43YAEgJVURhkzrf9N8bWIf3F5rSrKgbrY5+7WvnpXIqXVrv7fsv0vzb7 xppkKtQAsVpywkteG7VWkrcQUs1A96byhRSvY2BEGiRebZ2kqykKY0riFGH6tfHDgXajTa+ud sKTW/LkfWXWxlwWuDbcmdmwSJamfNOTt6o8wOXT7VGm/aEwdD2OS4YIpRn7EWANMmTHASajYy ETCE42BKfKaYwbMWKRiAvLfWwFU1+Y0KXjvmPyK/1io/NSd0KpH1BTE2xKmFMhSu/LZkRYyDY QhvmaXqvwTSiZIOUQ53w01qPuX+S6bqFFv/EawmiAvqBx4l/WvfwXjL+XrmtVuQ7/InRrqlBp kXsCfR2RI0V5D5FYFozacqtEfnaCXzqHsWTtwkM+g1DFA/GPt7hIHb6Cb2tNMMcS+kTSJYMhf hCB/ameswmdlm+EeM3Jz9uyLg9fMlJlpgfDTWooVSRlov2lJaEZ/1ZHLRK3gySIzlOYpwCtZv IDkz7EyCAwA0pamFs4Eav/FJSOLTs4YlXVHnNnzkLipD9kgVZ/djk80aFoAJlcPUvLFQhSYya ksr7aLu0tKSWhJHjFWe9/pYnvZzjWMDK8kwjkBMgvj5P5MLLdNAb08Mw85qoCFQppw2tdt7jk pAIATHrl9HA/1LLQ Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From 0d53d42a56e9a3769847fd03c703876f2c063fb4 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Tue, 27 Jan 2015 22:34:04 +0100 Subject: [PATCH] [SUBMITTED] crypto: atmel: fix bogus select The Atmel at91 crypto driver unconditionally selects AT_HDMAC, which results in a Kconfig warning if that driver is not enabled: warning: (CRYPTO_DEV_ATMEL_AES) selects AT_HDMAC which has unmet direct dependencies (DMADEVICES && ARCH_AT91) The crypto driver itself does not actually have a dependency on a particular dma engine, other than this being the one that is used in at91. Removing the 'select' gets rid of the warning, but can cause the driver to be unusable if the HDMAC is not enabled at the same time. To work around that, this patch clarifies the runtime dependency to be 'AT_HDMAC || AT_XDMAC', but adds an alternative for COMPILE_TEST, which lets the driver get build on all systems. The ARCH_AT91 dependency is implied by AT_XDMAC || AT_HDMAC now and no longer needs to be listed separately. Signed-off-by: Arnd Bergmann --- I found this one in my backlog, it still seems relevant and I forgot to send a new version after the last round of comments. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 2569e043317e..5357bc1f9e4b 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -378,10 +378,9 @@ config CRYPTO_DEV_BFIN_CRC config CRYPTO_DEV_ATMEL_AES tristate "Support for Atmel AES hw accelerator" - depends on ARCH_AT91 + depends on AT_XDMAC || AT_HDMAC || COMPILE_TEST select CRYPTO_AES select CRYPTO_BLKCIPHER - select AT_HDMAC help Some Atmel processors have AES hw accelerator. Select this if you want to use the Atmel module for