From patchwork Mon Mar 9 17:36:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 5970331 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D1AA09F380 for ; Mon, 9 Mar 2015 17:36:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1885020251 for ; Mon, 9 Mar 2015 17:36:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 485EB2024D for ; Mon, 9 Mar 2015 17:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753014AbbCIRgx (ORCPT ); Mon, 9 Mar 2015 13:36:53 -0400 Received: from mail-ig0-f169.google.com ([209.85.213.169]:37850 "EHLO mail-ig0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752449AbbCIRgx (ORCPT ); Mon, 9 Mar 2015 13:36:53 -0400 Received: by igbhn18 with SMTP id hn18so23094688igb.2; Mon, 09 Mar 2015 10:36:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=ANEyEBq+YVJW/6B09uyU5m/L/HpYdEsKxAywCYggUOw=; b=qlo/lxobsA0bBpjNHOXLglhZtE5hfOwf+w5z+ZA7/KaNDpiRSSN0IjNPga8oQb6zAD MPCDdlL7mmkBVhRbj+5IcWaVMbthN1lovKsBdqp6QKf4lBHwlLpCUD/ra1uXWqPE7vxg 7hqP2IacT8uLmWP49ALInGXy1TnkM9DYqKCRBHhbGebiR31V6qEXIJpyZIpVRl5IBvLb H0uV4wNwICH8BCIidfWbd+pgDwYfwZuURJZkcOtWYMFZ2wNY/k+sfH271nFOr3Qz8C+m V26RnoMs0jfB8tUkSV1RrYzW54MY3P4tuL+YBAhaAXGrl124m5fc7ZezoZkiY3XnFXU4 K3NQ== X-Received: by 10.43.14.10 with SMTP id po10mr27814920icb.64.1425922612316; Mon, 09 Mar 2015 10:36:52 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([172.22.64.149]) by mx.google.com with ESMTPSA id f142sm12517893ioe.3.2015.03.09.10.36.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Mar 2015 10:36:50 -0700 (PDT) From: Dmitry Torokhov To: linux-crypto@vger.kernel.org, Deepak Saxena Cc: linux-kernel@vger.kernel.org, Herbert Xu Subject: [PATCH 1/4] hwrng: omap - remove incorrect __exit markups Date: Mon, 9 Mar 2015 10:36:35 -0700 Message-Id: <1425922598-16538-1-git-send-email-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.2.0.rc0.207.ga3a616c Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov --- drivers/char/hw_random/omap-rng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c index d14dcf7..7f3597d 100644 --- a/drivers/char/hw_random/omap-rng.c +++ b/drivers/char/hw_random/omap-rng.c @@ -408,7 +408,7 @@ err_ioremap: return ret; } -static int __exit omap_rng_remove(struct platform_device *pdev) +static int omap_rng_remove(struct platform_device *pdev) { struct omap_rng_dev *priv = platform_get_drvdata(pdev); @@ -460,7 +460,7 @@ static struct platform_driver omap_rng_driver = { .of_match_table = of_match_ptr(omap_rng_of_match), }, .probe = omap_rng_probe, - .remove = __exit_p(omap_rng_remove), + .remove = omap_rng_remove, }; module_platform_driver(omap_rng_driver);