From patchwork Mon Mar 9 17:36:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 5970381 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 09DAE9F444 for ; Mon, 9 Mar 2015 17:38:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3EDBE201B4 for ; Mon, 9 Mar 2015 17:38:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D78F20259 for ; Mon, 9 Mar 2015 17:38:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753331AbbCIRg6 (ORCPT ); Mon, 9 Mar 2015 13:36:58 -0400 Received: from mail-ie0-f176.google.com ([209.85.223.176]:46969 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753554AbbCIRg4 (ORCPT ); Mon, 9 Mar 2015 13:36:56 -0400 Received: by iecrd18 with SMTP id rd18so14536709iec.13; Mon, 09 Mar 2015 10:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DYkf9HD6Jo7tCAGZFof2IxrzQh9DOewn6w39bR1Bo0k=; b=sGMOFSTDGGZF1OWwVuDGuddOgYFQ+jo8GQWMjoUBHYDCc30Takm/eSyWKPsUSdRCMq fpAVwKIfrpLfMqotvb0HCHn8p5J9JWs2vsEfyaWcAX6hFOA60aD3V3wfLGVCxqhd1mWs OF0cu6Mc18sQ5O45wk+9lQ7g0LxKINTbX05fZcxOHPbjS7Vs/jXNmYGt7ZJR+TVGlRoh Xej+m0FR0OY6miVpFXaKPcbOcgIBSDhpljDSJqYCGcM5SXpKtkG5OVKeyxNYwfY+vCxl tWHQky3pujyQKl1/gPnLjefJutw5gr0oPJcBpRUUnr/1hDKEmyBPYpMmH8tFOuuK988y KSeA== X-Received: by 10.107.159.20 with SMTP id i20mr5059439ioe.12.1425922615758; Mon, 09 Mar 2015 10:36:55 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([172.22.64.149]) by mx.google.com with ESMTPSA id f142sm12517893ioe.3.2015.03.09.10.36.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Mar 2015 10:36:54 -0700 (PDT) From: Dmitry Torokhov To: linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Herbert Xu Subject: [PATCH 3/4] hwrng: octeon - remove incorrect __exit markups Date: Mon, 9 Mar 2015 10:36:37 -0700 Message-Id: <1425922598-16538-3-git-send-email-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.2.0.rc0.207.ga3a616c In-Reply-To: <1425922598-16538-1-git-send-email-dmitry.torokhov@gmail.com> References: <1425922598-16538-1-git-send-email-dmitry.torokhov@gmail.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes Signed-off-by: Dmitry Torokhov --- drivers/char/hw_random/octeon-rng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/hw_random/octeon-rng.c b/drivers/char/hw_random/octeon-rng.c index be1c3f6..6234a4a 100644 --- a/drivers/char/hw_random/octeon-rng.c +++ b/drivers/char/hw_random/octeon-rng.c @@ -105,7 +105,7 @@ static int octeon_rng_probe(struct platform_device *pdev) return 0; } -static int __exit octeon_rng_remove(struct platform_device *pdev) +static int octeon_rng_remove(struct platform_device *pdev) { struct hwrng *rng = platform_get_drvdata(pdev); @@ -119,7 +119,7 @@ static struct platform_driver octeon_rng_driver = { .name = "octeon_rng", }, .probe = octeon_rng_probe, - .remove = __exit_p(octeon_rng_remove), + .remove = octeon_rng_remove, }; module_platform_driver(octeon_rng_driver);