From patchwork Thu Mar 12 21:00:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 5999211 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DB7E8BF90F for ; Thu, 12 Mar 2015 21:01:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 11390200E9 for ; Thu, 12 Mar 2015 21:01:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2116020160 for ; Thu, 12 Mar 2015 21:01:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932217AbbCLVBF (ORCPT ); Thu, 12 Mar 2015 17:01:05 -0400 Received: from mail-ie0-f170.google.com ([209.85.223.170]:36750 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932348AbbCLVAm (ORCPT ); Thu, 12 Mar 2015 17:00:42 -0400 Received: by iegc3 with SMTP id c3so62535578ieg.3; Thu, 12 Mar 2015 14:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l9UHI99C5k30GDyJEu/l3RFnFm5/Mmq0iRakSKGNqZY=; b=X3jumbL6NgRvmtMevc0iwdXJB3s9FNxtr6AA/7YBvnVydUfEiE0rVnHKOaGITMIsa9 s1GyqUuTQA7aLsJZzXl8wjhQyOnWYJqxQDsgwmWGmnvYIsOjYcJZ6eAD1Lfl+uL2QtrE lipPkVYmomM5T78QjNbrEvJ8NWHZhCBRfIN79bKOxMDZPMLunSNIhRK0nepehV2bjFjF oCwMMtfL//2av5LNKywGKE2SnPQkY7HzeFlXd7zHLPZKHjcUE09UhebFIIexxytVdTcP mu2K20mXizEWZfbFRqwZE8nqX2ORIr7ZzedkF5TSk0A7o1oltnqi2KHx9aw0XnjIRwsn OvDQ== X-Received: by 10.50.43.138 with SMTP id w10mr104393937igl.19.1426194032678; Thu, 12 Mar 2015 14:00:32 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([172.22.64.149]) by mx.google.com with ESMTPSA id c8sm1267igx.9.2015.03.12.14.00.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 12 Mar 2015 14:00:31 -0700 (PDT) From: Dmitry Torokhov To: Herbert Xu Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] hwrng: iproc-rng200 - make use of devm_hwrng_register Date: Thu, 12 Mar 2015 14:00:07 -0700 Message-Id: <1426194007-22182-7-git-send-email-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.2.0.rc0.207.ga3a616c In-Reply-To: <1426194007-22182-1-git-send-email-dmitry.torokhov@gmail.com> References: <1426194007-22182-1-git-send-email-dmitry.torokhov@gmail.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This allows us to get rid of driver's remove() method. Signed-off-by: Dmitry Torokhov --- drivers/char/hw_random/iproc-rng200.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c index 2dbaf5c..3eaf7cb 100644 --- a/drivers/char/hw_random/iproc-rng200.c +++ b/drivers/char/hw_random/iproc-rng200.c @@ -208,29 +208,17 @@ static int iproc_rng200_probe(struct platform_device *pdev) priv->rng.cleanup = iproc_rng200_cleanup, /* Register driver */ - ret = hwrng_register(&priv->rng); + ret = devm_hwrng_register(dev, &priv->rng); if (ret) { dev_err(dev, "hwrng registration failed\n"); return ret; } - platform_set_drvdata(pdev, priv); - dev_info(dev, "hwrng registered\n"); return 0; } -static int iproc_rng200_remove(struct platform_device *pdev) -{ - struct iproc_rng200_dev *priv = platform_get_drvdata(pdev); - - /* Unregister driver */ - hwrng_unregister(&priv->rng); - - return 0; -} - static const struct of_device_id iproc_rng200_of_match[] = { { .compatible = "brcm,iproc-rng200", }, {}, @@ -243,7 +231,6 @@ static struct platform_driver iproc_rng200_driver = { .of_match_table = iproc_rng200_of_match, }, .probe = iproc_rng200_probe, - .remove = iproc_rng200_remove, }; module_platform_driver(iproc_rng200_driver);