From patchwork Mon Mar 23 20:33:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 6075401 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 13B879F2A9 for ; Mon, 23 Mar 2015 20:33:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 40763202EB for ; Mon, 23 Mar 2015 20:33:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E1382034A for ; Mon, 23 Mar 2015 20:33:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752512AbbCWUd2 (ORCPT ); Mon, 23 Mar 2015 16:33:28 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:35392 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752603AbbCWUdQ (ORCPT ); Mon, 23 Mar 2015 16:33:16 -0400 Received: by wibdy8 with SMTP id dy8so57814741wib.0 for ; Mon, 23 Mar 2015 13:33:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ytuPml76wB3Cs+5gyZS09Iyu86WfBa2Hi8GAqfWdoBg=; b=WC27Qw9y18ngp+ogq0ucsSAHmjOm3L4aQc336p55tt/oR2ZvwAWO0Ngvj3p/u67jFT xAujAQ8jAe1P0sGN3ZvhyVFEavtkCIMUDiepmomJPMHI+RffhkBSDgwt3WdfMD3Si5u5 5PZnuGVCPcgXk4FgIrreRQrV124bRMfsrFm6G2IxX9cwpbVNPxoHeUJxG/a6kCQNIcxn c2RsRQgSZ12UpOz4tFmDRt1tDC4iUA5rvXMMFUwqfpGwhgJJa8mIYI7hlacl/ACMBwB4 mKN6XC3eFRN8SvAngFoFBbvv5BnAxkXW0NuvtqsybmDVbWlVTzYE6y7igfm10gBHyX2u dAtA== X-Gm-Message-State: ALoCoQmRKIc2r1U0Fe4gzpY1ebTETQNO8Bz9AZ0SaT80cFY+/My9/YuTYFt17MkBOQBBAzU6Iprf X-Received: by 10.194.20.67 with SMTP id l3mr1704095wje.94.1427142794153; Mon, 23 Mar 2015 13:33:14 -0700 (PDT) Received: from ards-macbook-pro.local (62.82.106.185.static.user.ono.com. [62.82.106.185]) by mx.google.com with ESMTPSA id ch6sm3010517wjc.3.2015.03.23.13.33.12 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Mar 2015 13:33:13 -0700 (PDT) From: Ard Biesheuvel To: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Ard Biesheuvel Subject: [PATCH] crypto/arm: fix big-endian bug in ghash Date: Mon, 23 Mar 2015 21:33:09 +0100 Message-Id: <1427142789-13960-1-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 1.8.3.2 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This fixes a bug in the new v8 Crypto Extensions GHASH code that only manifests itself in big-endian mode. Signed-off-by: Ard Biesheuvel --- arch/arm/crypto/ghash-ce-core.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/crypto/ghash-ce-core.S b/arch/arm/crypto/ghash-ce-core.S index e643a15eadf2..f6ab8bcc9efe 100644 --- a/arch/arm/crypto/ghash-ce-core.S +++ b/arch/arm/crypto/ghash-ce-core.S @@ -40,7 +40,7 @@ * struct ghash_key const *k, const char *head) */ ENTRY(pmull_ghash_update) - vld1.8 {SHASH}, [r3] + vld1.64 {SHASH}, [r3] vld1.64 {XL}, [r1] vmov.i8 MASK, #0xe1 vext.8 SHASH2, SHASH, SHASH, #8