diff mbox

crypto: CRYPTO_DEV_IMGTEC_HASH should depend on HAS_DMA

Message ID 1429812238-9306-1-git-send-email-geert@linux-m68k.org (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show

Commit Message

Geert Uytterhoeven April 23, 2015, 6:03 p.m. UTC
If NO_DMA=y:

    drivers/built-in.o: In function `img_hash_write_via_dma_stop':
    img-hash.c:(.text+0xa2b822): undefined reference to `dma_unmap_sg'
    drivers/built-in.o: In function `img_hash_xmit_dma':
    img-hash.c:(.text+0xa2b8d8): undefined reference to `dma_map_sg'
    img-hash.c:(.text+0xa2b948): undefined reference to `dma_unmap_sg'

Also move the "depends" section below the "tristate" line while we're at
it.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/crypto/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Herbert Xu April 24, 2015, 12:20 p.m. UTC | #1
On Thu, Apr 23, 2015 at 08:03:58PM +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     drivers/built-in.o: In function `img_hash_write_via_dma_stop':
>     img-hash.c:(.text+0xa2b822): undefined reference to `dma_unmap_sg'
>     drivers/built-in.o: In function `img_hash_xmit_dma':
>     img-hash.c:(.text+0xa2b8d8): undefined reference to `dma_map_sg'
>     img-hash.c:(.text+0xa2b948): undefined reference to `dma_unmap_sg'
> 
> Also move the "depends" section below the "tristate" line while we're at
> it.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied.
diff mbox

Patch

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 800bf41718e185e8..033c0c86f6ec051a 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -446,8 +446,9 @@  config CRYPTO_DEV_VMX
 source "drivers/crypto/vmx/Kconfig"
 
 config CRYPTO_DEV_IMGTEC_HASH
-	depends on MIPS || COMPILE_TEST
 	tristate "Imagination Technologies hardware hash accelerator"
+	depends on MIPS || COMPILE_TEST
+	depends on HAS_DMA
 	select CRYPTO_ALGAPI
 	select CRYPTO_MD5
 	select CRYPTO_SHA1